Checklist for Program

[former_member194669]

All,

This may be a general question.

We have multi continental development centres , the programmers usually complete their coding and submit for testing.

So i am looking some kind CHECKLIST document that these are the points covered while doing the programming say for example

1. All selection screen input have provided f4 help

2. All selection screen input have f1 documentation.

...

..

Something like that

Anybody have these info please share it here.

a®

[Former Member]

Why not just use a standard template for creating the programs?

[Former Member]

a®s ,

it wud be project specific.. so wont be a right place to ask i think.

[matt]

No, I think it could be a useful discussion - but don't ask for documents!.

It isn't project specific. Writing good ABAP goes across projects.

matt

[Former Member]

Hi,

Why not start a wiki on the subject and encourage people to contribute to that?

Regards,

Nick

[matt]

>

> Hi,
> 
> Why not start a wiki on the subject and encourage people to contribute to that?
> 
> Regards,
> Nick

Good point, but maybe we could have the discussion bit here first?

[former_member194669]

Matt,

I also think about, keep this thread open few more days to get feedback

Any other feedback on this ?

a®

[GauthamV]

We will see different documents maintained in diiferent companies for checklist and review.

So its really upto you to decide what are the points required to be used in the checklist

for your requirement.

If you need any other information sure we can help you out.

[suredarreddy_pulimamidi]

Hi,

I am adding few to the list.

1. All selection screen input have provided f4 help

2. All selection screen input have f1 documentation.

3. Coding is done as per the project naming standards.

4. Data element references used or not

5. Internal table declarations(standard internal table) or field symbol declaration

6. Validations on the selection screen fields done or not

7. Modularization is used or not

8. fields fetched from the data base table are in the same sequence are not and the sequence should be matched with the internal table feilds declaration

9.after each select checking the sy-subrc value.

10. Any joins used if used avioding them using for all entries.

11.Before using the for all entries checking the driver internal table contains any entires sorting the internal table and deleting the duplicate records.

regards,

Surendar Reddy.

[Former Member]

Hi,

1. Chect internal table for not initial if FOR ALL ENTRIES used

2. Check for extended syntex chaeck and Code inspector chek.

3. Binary serch for Read table.

[matt]

>

> 3. Binary serch for Read table.

Well, if you need a binary search, then maybe you're using the wrong kind of table. SORTED or HASHED may be better.

[former_member194669]

All,

As this forum is for abap general, i have posted this.

If my question is not clear to any, i am sorry about not giving much details.

Here is my details i am looking.

1 I am not looking this on the basis of performance or code review point of view

2, I am looking this list more what are mandatory points that required in a report.

say in the first mail i said if a programmer gives a report for code review. Before going into code review i need to have checklist.

These are some of items i find

1. Program documentation to given (Thru se63)

2. All Input fields have F1 documentation

3. All input fields that have check tables should have f4 help

4. All radio buttons should have f1 documentation

5. All check box should have F1 documentation

6. If report is ALV output then LAYOUT to be as input field in selection screen

7. File upload should have Dialog box selection

8. All programs should have with progress indicator message during execution

9. If selection input error happens cursor should go to field that have error

.....

I looking these kind details and not on performance points of view

a®

[Former Member]

Hi,

A few more points:

During File Upload:

a) Label each text box clearly to understand Presentation server file path/ Application server file path to be mentioned.

b) Disable Presentation server file selection option in case of background execution.

c) Show the progress of file upload in the status bar