Solved: Re: Issue with gui_download function module

former_member936723 · ‎2009 Dec 08

Hi All,

I have an issue with gui_download function module that it is creating one extra line while downloading my internal table data into text file,which i donot want.i have searched for various threads but couldnot get the proper reply.Or please provide me some other Function Module which will not create one extra line.Please help.

Former Member · ‎2009 Dec 15

Hi Ankita

Just try this and your problem will be solved.

CALL FUNCTION 'GUI_DOWNLOAD'
    EXPORTING
      FILENAME                        = FILEPATH
     FILETYPE                        = 'ASC'
     WRITE_FIELD_SEPARATOR           = 'X'    
TABLES
      DATA_TAB                        = IT_OUTPUT

Former Member · ‎2009 Dec 08

Hi Ankita,

Is it adding a blank line or line with some data?

Can you plz share your code with us so that we can check if there is any problem with your call?

Regards

Avinash

Former Member · ‎2009 Dec 08

Hello,

GUI_DOWNLOAD only uses data from your internal table to download. So check in the debugging mode if there is a addition blank line in the internal table before passing it to GUI_DOWNLOAD.

Vikranth

former_member936723 · ‎2009 Dec 08

Hi,

No my internal table does not contain any extra line.I have already checked it.

Former Member · ‎2009 Dec 08

Hello,

What is the type of the file you are trying to download? Also post how you are calling GUI_DOWNLOAD. That might give a clue as to identify whats wrong.

Vikranth

former_member936723 · ‎2009 Dec 08

Hi,

Plz check my code below

APPEND IT_OUTPUT -

this is my internal table.

DESCRIBE TABLE IT_OUTPUT LINES ln.

FILE_LEN = LN.----

I am passinf the internal table legth

CLEAR IT_OUTPUT.

IF IT_OUTPUT[] IS NOT INITIAL.

CONCATENATE FLN SY-DATUM SY-UZEIT '.txt'

INTO FILEPATH.

CALL FUNCTION 'GUI_DOWNLOAD'

EXPORTING

FILENAME = FILEPATH

FILETYPE = 'ASC'

WRITE_FIELD_SEPARATOR = 'X'

TRUNC_TRAILING_BLANKS = 'X'

WK1_T_SIZE = FILE_LEN

TRUNC_TRAILING_BLANKS_EOL = ''
WRITE_LF = ''
WRITE_LF_AFTER_LAST_LINE = ''

TABLES

DATA_TAB = IT_OUTPUT

OTHERS = 22

Former Member · ‎2009 Dec 08

Can you post your original code how you are filling the internal table and what aexactly are y9ou doing.So we can copy to our systems and check for the same.

Sas

Former Member · ‎2009 Dec 08

Hello,

I dont see the use for using the file length here. May be thats the reason for the extra line. Try removing it and check


APPEND IT_OUTPUT ---------this is my internal table.
CLEAR IT_OUTPUT.
IF IT_OUTPUT[] IS NOT INITIAL.

CONCATENATE FLN SY-DATUM SY-UZEIT '.txt'
INTO FILEPATH.

CALL FUNCTION 'GUI_DOWNLOAD'
EXPORTING
FILENAME = FILEPATH
FILETYPE = 'ASC'
* WRITE_FIELD_SEPARATOR = 'X'
TRUNC_TRAILING_BLANKS = 'X'
*WK1_T_SIZE = FILE_LEN   " Comment this and check
* TRUNC_TRAILING_BLANKS_EOL = ''
* WRITE_LF = ''
* WRITE_LF_AFTER_LAST_LINE = ''
TABLES
DATA_TAB = IT_OUTPUT
* OTHERS = 22

Vikranth

Former Member · ‎2009 Dec 08

Hi Ankita,

Is there any requirement to pass the file length?

Usually it is not necessary to pass file length.Try by removing that.

Regards

Avinash

Former Member · ‎2009 Dec 08

Hi Ankita,

The problem is in your file.

Try using a field separator = 'X' and try.This will only create one tab space and problem will get solved.

Regards,

Subhashini

Former Member · ‎2009 Dec 08

Clear/ Refresh the internal table before you use it.

Regs, Arka

former_member936723 · ‎2009 Dec 08

Hi ,

Please check for radio button R4

Moderator message - Please respect the 2,500 character maximum when posting. Post only the relevant portions of code. And use code tags.

Edited by: Rob Burbank on Dec 8, 2009 9:23 AM

former_member936723 · ‎2009 Dec 08

No it is still giving the same blank line.

Former Member · ‎2009 Dec 08

Hi,

Why are you using WK1_T_SIZE. That is the column width of Text columns. Comment out this and it should work fine. By the way you were passing the number of rows to WK1_T_SIZE and not the size of the table. For getting the size of the table you should multiply the rows * column width

Regards,

former_member156446 · ‎2009 Dec 08

its not with gui_download..

CALL FUNCTION 'GUI_DOWNLOAD'
      EXPORTING
        filename                = l_fullpath
        filetype                = 'ASC'
        append                  = 'X'
      TABLES
        data_tab                = t_output  " check this table, this would have the extra line... 
      EXCEPTIONS
        file_write_error        = 1
        no_batch                = 2
        gui_refuse_filetransfer = 3
        invalid_type            = 4
        no_authority            = 5
        unknown_error           = 6
        header_not_allowed      = 7
        separator_not_allowed   = 8
        filesize_not_allowed    = 9
        header_too_long         = 10
        dp_error_create         = 11
        dp_error_send           = 12
        dp_error_write          = 13
        unknown_dp_error        = 14
        access_denied           = 15
        dp_out_of_memory        = 16
        disk_full               = 17
        dp_timeout              = 18
        file_not_found          = 19
        dataprovider_exception  = 20
        control_flush_error     = 21
        OTHERS                  = 22.
    IF sy-subrc <> 0.
      MESSAGE ID sy-msgid TYPE sy-msgty NUMBER sy-msgno
              WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4.
    ENDIF.

Former Member · ‎2009 Dec 08

Hi,

Is it creating a blank line at the end of file?

Regards,

Subhashini

former_member936723 · ‎2009 Dec 08

Hi,

Yes it is creating one blank line at end of the file.

Former Member · ‎2009 Dec 08

Ankita 1 points :

1)Can you post your code for easy analaysis...

Sas

former_member206377 · ‎2009 Dec 08

Can you post the code?

Former Member · ‎2009 Dec 08

why dont you try the ws_download?

former_member936723 · ‎2009 Dec 08

But WS_DOWNLOAD has become obselete now.

Former Member · ‎2009 Dec 08

dont loose your time.

define a new iternal table with the same structure as the other.

loop at  old_it.
if old_it-field1 <>  ' '.  "is not initial
move-corresponding old_it to new_it.
append new_it.
clear new_it.
endloop.

i dont know how to post the opposit of ( = ). second line of code before ' '.

former_member936723 · ‎2009 Dec 08

no this is also not working.same blank line is coming

Former Member · ‎2009 Dec 08

debug it before the FM. if your iternal table has an empty line the problem is in your table else something with your FM

Former Member · ‎2009 Dec 08

You are downloading it as a Text file. What do you mean by a blank line at the end here?

former_member936723 · ‎2009 Dec 08

i mean to say one extra blank line is coming along with my data in the text file which i donot want.how can i get rid of this blank line.

former_member206377 · ‎2009 Dec 08

Hi Ankita,

I) have you tried setting parameter 'write_lf_after_last_line' to 'space'

if the above does not work you can use one work around. Its rather lengthy solution .

1. The following settings were needed to stop all line feed /carriage returns in the file creation and

remove new unwanted spacing .

CALL FUNCTION 'GUI_DOWNLOAD'

EXPORTING

filename = g_file

filetype = 'ASC'

trunc_trailing_blanks = 'X' "PREVENT EXTRA SPACES

write_lf = ' ' "PREVENT LINE FEED

2. Then set up your own carriage returns via hexadecimal symbols like below:

*holds hexadecimal carriage return character

DATA: BEGIN OF xt,

xx(1) TYPE x,

END OF xt.

INITIALIZATION.

*set carriage return value

xt-xx = '0D'. "carriage return '0D', line feed '0A'

3. Finallyyou need to insert the carriage return before saving it to the data table to be output to file.

CONCATENATE w_dtl xt INTO w_dat-data.

This should be done to every record except the last one .

Former Member · ‎2009 Dec 08

ankita

if you are getting data


pernr begda       endda
1       12/01/09  12/31/99
2       11/01/09   12/31/99
3       12/02/09   12/31/99

Now where is the extra space concept in txt file?

Please use

{code)

(code}

to post code.When i copy your code its too hard to make it line by line

and remember if it exceeds certain 2500 character try to break the code and paste by parts (post by post)

Sas

former_member936723 · ‎2009 Dec 08

Hi,

Please elaborate your point.because i didnot get you completely.

former_member206377 · ‎2009 Dec 08

Hi Ankita,

In GUI_DOWNLOAD, there is a parameter called 'write_lf_after_last_line' . Try setting that to space.


write_lf_after_last_line  = ' '

If the above also does not work you can go for the work around mentioned in my previous reply.

I hope its clear. Else, let me know .

former_member936723 · ‎2009 Dec 08

Hi Vasuki,

I tried using WRITE_LF_AFTER_LAST_LINE = ' '. But not working.

former_member206377 · ‎2009 Dec 09

Hi Ankita,

You can try the work around suggested in my earlier post

1) Remove all line feed /carriage returns in the file and

remove new unwanted spacing . Use the FM parameters as follows :


CALL FUNCTION 'GUI_DOWNLOAD'
EXPORTING
filename = g_file
filetype = 'ASC'
trunc_trailing_blanks = 'X' "PREVENT EXTRA SPACES
write_lf = ' ' "PREVENT LINE FEED

2. Then set up your own carriage returns via hexadecimal symbols like below:


DATA: BEGIN OF xt,
xx(1) TYPE x,
END OF xt.

INITIALIZATION.

xt-xx = '0D'. "carriage return '0D', line feed '0A'

3. Finallyyou need to insert the carriage return before saving it to the data table to be output to file.

CONCATENATE w_dtl xt INTO w_dat-data.

This should be done to every record *except the last one * .

This will solve your issue.

former_member936723 · ‎2009 Dec 09

Hi Vasuki,

I tried your code but it is giving me dump as well as it is not taking hexadecimals it is asking for character or numeric type.

Former Member · ‎2009 Dec 09

Last call for you...................

Paste your code in blocks (2 or 3 posts) using codes

So that any one can copy code into their posts and guide you better .........All trail and error are completed.

Best of luck

Sas

former_member936723 · ‎2009 Dec 09

Code part 1.

**Data Declaration:-**

TABLES: PERNR,

PCL1,

PCL2,

PA0001,

PA0009,

T549Q, T511.

INFOTYPES: 0000,0009,0001,0008,0003.

*DATA BEGIN OF PHIFI OCCURS 1.

INCLUDE STRUCTURE PERNR.

*DATA END OF PHIFI.

DATA BEGIN OF EVP OCCURS 1.

INCLUDE STRUCTURE PEVPT.

DATA END OF EVP.

DATA : HIRE LIKE SY-DATUM,

FIRE LIKE SY-DATUM.

DATA : BEGIN OF ITAB1 OCCURS 0,

SNO TYPE N,

ENO LIKE PERNR-PERNR,

NAM LIKE P0001-ENAME,

BAC LIKE P0009-BANKN,

DEP LIKE P0001-KOSTL,

BTFR LIKE P0008-BET01 VALUE 0,

BKEY LIKE P0009-BANKL,

PDT LIKE SY-DATUM,

BETRG LIKE P0009-BETRG,"CHANGES BY ANKITA.

TAXID(10),"CHANGES BY ANKITA.

END OF ITAB1.

DATA : BEGIN OF ITCC OCCURS 0,

SNO TYPE N,

DEP LIKE P0001-KOSTL,

BTFR LIKE P0008-BET01 VALUE 0,

END OF ITCC.

DATA : ITCOL LIKE ITCC OCCURS 0 WITH HEADER LINE.

DATA: BERTG_TOT(16) TYPE N.

DATA : BEGIN OF ITTF OCCURS 0,

ROW(37),

END OF ITTF.

DATA : BEGIN OF IT_FAIL OCCURS 0,

EN LIKE PERNR-PERNR,

BA LIKE P0009-BANKN,

END OF IT_FAIL.

DATA : LIN TYPE I VALUE 0,

FILE_LEN TYPE I VALUE 160,

FILEPATH TYPE STRING,

FR_DT LIKE SY-DATUM,

TO_DT LIKE SY-DATUM,

V_BAC LIKE P0009-BANKN,

SN TYPE N VALUE 0,

STR(37) TYPE C,

LEN TYPE I,

P11(11) TYPE C,

P3(3) TYPE C,

P13(13) TYPE N,

P6(6) TYPE C,

TO_P(6),

FR_P(6),

YEAR(4),

MONTH(2),

DAY(2),

LN TYPE C.

DATA:BEGIN OF IT_BANK OCCURS 0,

EMPID(10),

BANKN(14) TYPE N,

BANKL(07) TYPE N,

BETRG(10) TYPE N,

TAXID(10),

END OF IT_BANK.

DATA: F_NAME TYPE STRING,

ORG_NO(07) TYPE N,

HEADER(3),

DATACODE(6),

DEPT_CODE(5),

CUST_ID(18),

IRN(16),

FILLER(74),

TRANS_DAY TYPE SY-DATUM,

TRANS_DAY1(4) TYPE N,

TIME TYPE SY-UZEIT,

STR1 TYPE STRING,

STR3 TYPE STRING,

STR2 TYPE STRING,

TYPE(1) TYPE C VALUE 'N',

SEQNO(06) TYPE N,

SEQ(08) TYPE N,

RETURN_CODE(02) VALUE '00',

PRES_CODE(01) VALUE 'B',

STR7 TYPE STRING,

COMP_CODE(06),

PRE_DAT(08) TYPE N VALUE '00000000',

PRE_SEQ(06) TYPE N VALUE '000000',

PRE_CODE(01),

STR4 TYPE STRING,

STR5 TYPE STRING,

STR6 TYPE STRING,

FOOTER(03) VALUE 'EOF'.

DATA:BEGIN OF IT_OUTPUT OCCURS 0,

OUT_ROW(160) TYPE C,

END OF IT_OUTPUT. " eoc BY ANKITA

DATA:BEGIN OF IT_OUTPUT_new OCCURS 0,

OUT_ROW(160) TYPE C,

END OF IT_OUTPUT_new.

PARAMETERS: PRD LIKE PC260-FPPER OBLIGATORY DEFAULT '200804'.

SELECTION-SCREEN BEGIN OF BLOCK B1 WITH FRAME TITLE TEXT-001.

SELECTION-SCREEN BEGIN OF LINE.

SELECTION-SCREEN COMMENT 1(12) TEXT-002 FOR FIELD R1.

PARAMETERS: R1 RADIOBUTTON GROUP RG1 DEFAULT 'X' USER-COMMAND RB.

SELECTION-SCREEN COMMENT 25(19) TEXT-003 FOR FIELD R2.

PARAMETERS: R2 RADIOBUTTON GROUP RG1.

SELECTION-SCREEN COMMENT 55(17) TEXT-004 FOR FIELD R3.

PARAMETERS: R3 RADIOBUTTON GROUP RG1.

SELECTION-SCREEN COMMENT 79(22) TEXT-005 FOR FIELD R4.

PARAMETERS: R4 RADIOBUTTON GROUP RG1.

SELECTION-SCREEN END OF LINE.

SELECTION-SCREEN END OF BLOCK B1.

PARAMETERS: PREPBY(30) TYPE C.

PARAMETERS: APROBY(30) TYPE C.

PARAMETERS: BTC(3) TYPE C OBLIGATORY DEFAULT '014'.

PARAMETERS: FLN LIKE RLGRAP-FILENAME DEFAULT 'C:\BankTransfer'.

*SELECTION-SCREEN COMMENT /5(60) TEXT-006 FOR FIELD PY_DT.

PARAMETERS: PY_DT LIKE PA0009-BEGDA OBLIGATORY.

PARAMETERS: ORG_AC(14) TYPE N OBLIGATORY,

ORG_ID(10) TYPE C OBLIGATORY,

PRS_BNK(07) TYPE N OBLIGATORY DEFAULT '0810016',

DEPT_CD(5) TYPE C OBLIGATORY DEFAULT '00000',

REF_NO(10) TYPE C OBLIGATORY,

TRANS_TY(02) TYPE C OBLIGATORY,

TRANS_ID(03) TYPE C OBLIGATORY,

TRANS_RK(44) TYPE C OBLIGATORY.

former_member936723 · ‎2009 Dec 09

part 2

INCLUDE RPPPXD00.

DATA : BEGIN OF COMMON PART A.

INCLUDE RPPPXD10.

DATA : END OF COMMON PART.

INCLUDE PC2RXTW0.

INCLUDE RPC2RX00.

DATA : BEGIN OF COMMON PART B.

INCLUDE RPC2CD00.

DATA : END OF COMMON PART.

INCLUDE RPPPXM00.

INCLUDE RPCMGR00.

*******************************************************************

AT SELECTION-SCREEN OUTPUT.

CONCATENATE SY-DATUM2(6) SY-UZEIT0(4) INTO REF_NO.

LOOP AT SCREEN.

IF R1 = 'X'.

IF SCREEN-NAME = 'FLN' OR SCREEN-NAME = '%_FLN_%_APP_%-TEXT' OR

SCREEN-NAME = 'BTC' OR SCREEN-NAME = '%_BTC_%_APP_%-TEXT' OR

SCREEN-NAME = 'PY_DT' OR SCREEN-NAME = '%_PY_DT_%_APP_%-TEXT'"SOC BY ANKITA"

OR SCREEN-NAME = 'ORG_ID' OR SCREEN-NAME = '%_ORG_ID_%_APP_%-TEXT'

OR SCREEN-NAME = 'ORG_AC' OR SCREEN-NAME = '%_ORG_AC_%_APP_%-TEXT'

OR SCREEN-NAME = 'DEPT_CD' OR SCREEN-NAME = '%_DEPT_CD_%_APP_%-TEXT'

OR SCREEN-NAME = 'REF_NO' OR SCREEN-NAME = '%_REF_NO_%_APP_%-TEXT'

OR SCREEN-NAME = 'PRS_BNK' OR SCREEN-NAME = '%_PRS_BNK_%_APP_%-TEXT'

OR SCREEN-NAME = 'TRANS_TY' OR SCREEN-NAME = '%_TRANS_TY_%_APP_%-TEXT'

OR SCREEN-NAME = 'TRANS_ID' OR SCREEN-NAME = '%_TRANS_ID_%_APP_%-TEXT'

OR SCREEN-NAME = 'TRANS_RK' OR SCREEN-NAME = '%_TRANS_RK_%_APP_%-TEXT'."EOC BY ANKITA

SCREEN-ACTIVE = 0.

ENDIF.

IF R2 = 'X'.

IF SCREEN-NAME = 'FLN' OR SCREEN-NAME = '%_FLN_%_APP_%-TEXT' OR

SCREEN-NAME = 'BTC' OR SCREEN-NAME = '%_BTC_%_APP_%-TEXT' OR

SCREEN-NAME = 'PREPBY' OR SCREEN-NAME = '%_PREPBY_%_APP_%-TEXT'

OR SCREEN-NAME = 'APROBY' OR SCREEN-NAME = '%_APROBY_%_APP_%-TEXT'

OR SCREEN-NAME = 'PY_DT' OR SCREEN-NAME = '%_PY_DT_%_APP_%-TEXT' "SOC BY ANKITA