Regarding Insert command

[Former Member]

Dear guys,

I have internaltable with 10 fields with different data types. and i have addontable with 8 fields(with differnt data type)

Now i want to insert records from internal table to addontable.which will be the best way.

I have done as below..pls confirm this is best way or not.

<b>Created internal table xtab same as addontable 8 fields.</b>

loop at mytab into ltab.

move-corresponding ltab into xtab.

append xtab.

endloop.

<b>now insert internal table valus to addontable.</b>

loop at xtab into ytab.

insert table zlottab values ytab.

endloop.

and

Commit work.

is there any alternative way or any wrong in my code..

ambichan.

[Former Member]

Hello Ambi,

Can you please close you all old threads and reward points accordingly.

regards

....................

Message was edited by: Surpreet Singh Bal

[Former Member]

loop at mytab into ltab.

move-corresponding ltab into xtab.

*check the data are transferring correctly..else move field by field..

append xtab.

endloop.

insert table zlottab from table xtab.

commit work.

regds

gv

Message was edited by: Venkat

[Former Member]

one thing you can take care while inserting is that whether data already exist and still you want to overwrite it then use update. else insert it.

for this you can use 'popup_to_confirm' FM.

regards

[Former Member]

yeah, I agree with venkat

'INSERT dbtab FROM TABLE itab'

this is better in performance, as its select statements runned by DB is less than insert every entry one by one.

Thanks

[Former Member]

hey guys,

why i could not see points ooption button displaying at left side of post?

looks strange..

is something prob with portal?..

ambichan

[Former Member]

yes i am also facing same problem

regards

[Former Member]

Instead of this loop at, if the table mytab and xtab are of the same structrue,

loop at mytab into ltab.

move-corresponding ltab into xtab.

append xtab.

endloop.

Can do as below mytab[] = xtab[].

INSERT  zlottab FROM TABLE xtab

.

This two line code is enough if all r of teh same structure.

Or

mytab[] = xtab[].
LOOP AT xtab into ytab.
 INSERT INTO zlottab VALUES ytab.
CLEAR ytab.
ENDLOOP.

Hope this helps.

Kindly reward points and close the thread.