Pass a variable value between methods in BADI

[ishwarya_doss]

Hi Experts,

I've implemented a BADI which has 2 methods. Inside the loop for every record, I need the parameter of method1 in order to set the logic in method2.

What is the best possible way to achieve that?

1. Tried creating Instance attribute to implementation class and populated it in method 1. But it's getting cleared when it comes out of method1.

2. Tried Static Attribute and it's not clearing the variable for every record in the loop.

3. Import/Export, Set/Get - What are the possible consequences of using memory ID. For example, if 2 users use the same transaction at the same time?

Kindly share your suggestions.

[ishwarya_doss]

@matthew.billingham

[FredericGirod]

You need to use the Design Patern SingleTon

Here an example :

https://answers.sap.com/questions/12988109/how-do-we-use-singleton-in-oo-abap-can-someone-ple.html

[Sandra_Rossi]

BAdI use the "instance pattern", one instance per implementation/filter (maybe I simplify a little bit...), why using "singleton"? (to transfer values between BAdI implementations?)

[FredericGirod]

Yes! you are right! if it is the same Class for the badi, you don't need SingleTon, the badi should already be a singleton ...

[Sandra_Rossi]

I think it would help us if you explain the real case. I don't understand what mean 1, 2 and 3...

[ishwarya_doss]

I need to set the status of purchase req based on a field.

One method is to modify PR before inbound - This has the field value based on which the status should be set.

Another method modify PR during inbound - This has the EBAN details where i need to set the status value based on the value of a variable i get from above method.

For doing this, I've tried creating an instance & static attributes in the implementing class. Its not working. Need your suggestions in achieving this efficiently.

[matt]

"Not working" isn't a recognised error description!

When you tried keeping the result from the first method in an instance attribute, exactly what did you do? What was your code? And when you debugged, what happened to the value in the attribute?

Instance attribute would be the approach I'd use.

[ishwarya_doss]

Instance attribute - Z_DEPLOY Instance Attribute Public

First method -

z_deploy = is_ibp_order_output-deployment.

Second method

IF z_deploy = 'X'.
      cs_eban-statu = 'D'.
    ENDIF.

Z_deploy was set to X in first method but got cleared when it came out of the method.

[FredericGirod]

Are you sure you are in the same instance of the badi ?

[ishwarya_doss]

So, the standard program has a global object . But multiple get badi and call badi statements which means its not in the same instance and hence the variable is getting cleared, Am i right? So , will export import be a good solution?

[Sandra_Rossi]

Is it BAdI ME_PROCESS_PO_CUST?

What are the 2 methods you use?

Or is it a secret?

[ishwarya_doss]

Sure. To update purchase requisition data sent back from IBP to an SAP ERP system using the BAdI /IBP/ECC_MODIFY_PREQ. -modify preq and modify preq before in methods

Using this option as SAP note 2803585 cannot be implemented for the version we use.

Thanks!

[FredericGirod]

In debug you check the instance of the Badi is not the same ?

Because my_badi->modify_preq and my_badi->modify_preq_before should used the same instance

So

1. If it is the same instance, you don't need anything, just used a global (private) variable
2. if it is not the same instance, but the same LUW: you could use Design Pattern SingleTon
3. If it is not the same instance, not the same LUW, but the same transaction: you could used SHMA
4. If it is not the same instance, same LUW, same transaction: there is no simple and strong solution

[Sandra_Rossi]

Thanks.

I don't have SCM but I guess that the method MODIFY_PREQ runs in the "main session" and MODIFY_PREQ_BEFORE_SAVE runs in the update task (it's another User Session), so they cannot communicate except by passing parameters via CALL FUNCTION ... IN UPDATE TASK, because all these calls are executed in the same update task (same User Session/same memory).

You may create your own Z update function module, do an Implicit Enhancement of the standard to run before the first update function module is called, from which you call your Z update function module and pass the parameter(s) you want. In the Z function group, you may define a global variable (or, if you prefer, create a Z class pool, an instance attribute and work with it through a singleton), that you use to store the parameter, and read it later from the method MODIFY_PREQ_BEFORE_SAVE.

[ishwarya_doss]

Thanks everyone for your suggestions!