plz increase performance of this report

[Former Member]

hi all

i want to know how can i improve the performance of my report.

the code is given below and it takes so much time on production even for single record

plz help

HERE COMES THE CODE

&----

---

*& Report ZGRSTATUS

*&

&----

---

*&

*&

&----

---

REPORT ZGRSTATUS.

TYPE-POOLS slis.

TABLES: mseg, qamb, mkpf, rseg.

DATA : BEGIN OF itab OCCURS 0,

mblnr LIKE mseg-mblnr,

zeile LIKE mseg-zeile,

uom LIKE mseg-erfme,

matnr LIKE mseg-matnr,

recqty LIKE mseg-erfmg,

qcins LIKE mseg-insmk, "INSPECTION SIGN

ebeln LIKE mseg-ebeln,

ebelp LIKE mseg-ebelp,

lifnr LIKE mseg-lifnr,

budat LIKE mkpf-budat,

txz01 LIKE ekpo-txz01,

name1 LIKE lfa1-name1,

accqty LIKE mseg-erfmg,

rejqty LIKE mseg-erfmg,

belnr LIKE rseg-belnr,

dqty LIKE mseg-menge,

cqty LIKE mseg-menge,

qcdat like mkpf-budat,

miro_budat like rbkp-budat,

accuom like mseg-erfme,

rejuom like mseg-erfme,

qcstat like mseg-insmk,

acstat(1) type c,

crnote(1) type c,

END OF itab.

DATA : BEGIN OF itab1 OCCURS 0,

mblnr LIKE mseg-mblnr,

zeile LIKE mseg-zeile,

mjahr LIKE mseg-mjahr,

prueflos like qamb-prueflos,

END OF itab1.

DATA: BEGIN OF imiro OCCURS 0,

belnr LIKE rseg-belnr,

lfbnr LIKE rseg-lfbnr, "DOCMENT NO SAME AS MBLRN

shkzg LIKE rseg-shkzg, "DEBIT CREDIT SIGN

menge LIKE rseg-menge,

ebeln LIKE rseg-ebeln,

ebelp LIKE rseg-ebelp,

budat LIKE rbkp-budat,

END OF imiro.

data: begin of iins occurs 0, "NEW INTERNAL TABLE DECLARED for inspection lot numbers

mblnr like mseg-mblnr,

zeile like mseg-zeile,

prueflos like qamb-prueflos,

mjahr like qamb-mjahr,

end of iins.

****************************CODE FOR SELECTION SCREEN****************************

selection-screen begin of block par1 WITH FRAME TITLE TEXT-001.

PARAMETERS : plant LIKE mseg-werks OBLIGATORY DEFAULT 'MFPL'.

PARAMETERS: year LIKE mseg-mjahr OBLIGATORY DEFAULT '2007'.

SELECT-OPTIONS : grno FOR mseg-mblnr,

grdate FOR mkpf-budat,

vendor FOR mseg-lifnr,

item for mseg-matnr.

SELECTION-SCREEN END OF BLOCK par1.

***************************END OF CODE FOR SELECTION SCREEN**********************

*************************FETCHING OF GR INFORMATION FROM MSEG AND MKPF*************************

SELECT a_{mblnr zeile a}erfme a_{matnr a}erfmg a_{insmk a}ebeln a_{ebelp a}lifnr b_{budat c}txz01 d~name1

FROM mseg AS a

INNER JOIN mkpf AS b ON a_{mblnr = b}mblnr AND a_{mjahr = b}mjahr

INNER JOIN ekpo AS c ON a_{ebeln = c}ebeln AND a_{ebelp = c}ebelp

INNER JOIN lfa1 as d ON d_{lifnr = a}lifnr

INTO TABLE itab

WHERE a_{werks = plant AND a}mblnr IN grno AND bwart = '101' AND a~mjahr = year

AND b_{tcode2 = 'MIGO_GR' AND b}budat IN grdate AND a_{lifnr IN vendor and a}matnr IN item.

*************************END OF RETERIEVEL***************************************

if sy-subrc <> 0.

Message 'NO RECORD FOUND' type 'E'.

endif.

*******************************SELECTING THE INSPECTED DOC NUMBERS AND CORROSPONDING INSPECTION LOT********************************

select mblnr zeile mjahr prueflos

from qamb into table itab1 for all entries in itab where mblnr = itab-mblnr and zeile = itab-zeile.

**********************************END OF SELECTING THE INSPECTED DOC. NUMBERS & INSPECTION LOTS************************************

**************************SELECTING THE DOC NO FOR ACCEPTED AND REJECTED QTY ACCORDING TO INSPECTION LOT***************************

select mblnr zeile prueflos mjahr into table iins from qamb

for all entries in itab1 where prueflos = itab1-prueflos and mblnr <> itab1-mblnr.

**************************END OF SELECTING ACCEPTED AND REJECTED QTY DOCUMENTS****************************************************

**********************************SELECTING THE DEBIT AND CREDIT QTY FOR THE MIRO TCODE*******************************************

SELECT a_{belnr lfbnr shkzg menge ebeln ebelp b}budat INTO table imiro

FROM rseg as a

inner join rbkp as b on a_{belnr = b}belnr

for all entries in itab where a~lfbnr = itab-mblnr.

************************************************************************************************************************************

DATA : v_qcidoc LIKE qamb-prueflos,

v_qcdoc LIKE mseg-mblnr,

v_qcdoc1 LIKE mseg-zeile,

v_qty LIKE mseg-menge,

v_bwart LIKE mseg-bwart,

v_name1 LIKE lfa1-name1,

v_budat like mkpf-budat,

v_newrejqty like mseg-menge,

v_newaccqty like mseg-menge,

CMPACCQTY LIKE MSEG-MENGE,

CMPREJQTY LIKE MSEG-MENGE,

aa TYPE c.

data: begin of iartab occurs 0,

mblnr like mseg-mblnr,

bwart like mseg-bwart,

qty like mseg-menge,

erfme like mseg-erfme,

zeile like mseg-zeile,

budat like mkpf-budat,

end of iartab.

clear iartab.

refresh iartab.

****************************************table for accept and reject qty************************************

SELECT a~mblnr bwart erfmg erfme zeile budat into table iartab

FROM mseg as a

inner join mkpf as b on a_{mblnr = b}mblnr

for all entries in iins

WHERE a_{mblnr = iins-mblnr AND a}zeile = iins-zeile AND xauto <> 'X' AND a~mjahr = iins-mjahr.

******************************************END OF ACCEPT AND REJECTED QTY.***********************************

LOOP AT itab.

clear: itab-accuom, itab-rejuom.

• SELECT SINGLE name1 FROM lfa1 INTO itab-name1 WHERE lifnr = itab-lifnr.

• **********************GETTING THE ACCEPTED AND REJECTED QTY FROM MSEG FOR ALL RECORDS OF ITAB*********************

IF itab-qcins = 'X'.

clear v_qcidoc.

clear: v_bwart, v_qty, v_budat.

read table itab1 with key mblnr = itab-mblnr zeile = itab-zeile.

if sy-subrc = 0.

v_qcidoc = itab1-prueflos.

endif.

• LOOP AT itab1 where prueflos = v_qcidoc and mblnr <> itab-mblnr .

LOOP AT iins where prueflos = v_qcidoc. " and mblnr <> itab-mblnr .

v_qty = 0.

• SELECT single bwart erfmg budat

• INTO (v_bwart, v_qty, v_budat)

• FROM mseg as a

• inner join mkpf as b on a_{mblnr = b}mblnr

• WHERE a_{mblnr = itab1-mblnr AND a}zeile = itab1-zeile AND xauto <> 'X' AND a~mjahr = itab1-mjahr.

• WHERE a_{mblnr = iins-mblnr AND a}zeile = iins-zeile AND xauto <> 'X' AND a~mjahr = iins-mjahr.

read table iartab with key mblnr = iins-mblnr zeile = iins-zeile.

if sy-subrc = 0.

v_bwart = iartab-bwart.

v_qty = iartab-qty.

v_budat = iartab-budat.

endif.

IF v_bwart = '321'.

v_newaccqty = v_newaccqty + v_qty.

itab-accqty = v_newaccqty.

itab-qcdat = v_budat.

itab-accuom = iartab-erfme.

ELSEIF v_bwart = '122'.

itab-qcdat = v_budat.

v_newrejqty = v_newrejqty + v_qty.

itab-rejqty = v_newrejqty.

itab-rejuom = iartab-erfme.

ENDIF.

ENDLOOP. "*********END OF LOOP FOR ITAB1**************

clear: v_newaccqty, v_newrejqty.

ENDIF. "**********END OF MAIN ENDIF***********************

• *****************END OF CODE FOR ACCEPTED AND REJECTED QTY************************************

• ****************************GETTING DEBIT AND CREDIT QTY******************************************

LOOP AT imiro WHERE lfbnr = itab-mblnr AND ebeln = itab-ebeln AND ebelp = itab-ebelp.

ITAB-MIRO_BUDAT = IMIRO-BUDAT.

itab-belnr = imiro-belnr.

IF imiro-shkzg = 'S'.

itab-dqty = imiro-menge.

ELSEIF imiro-shkzg = 'H'.

itab-cqty = imiro-menge.

ENDIF.

ENDLOOP.

• *****************************END OF CODE FOR DEBIT AND CREDIT QTY*******************************

data v_sumqty like mseg-menge.

CLEAR V_SUMQTY.

if itab-qcins = 'X'.

clear: cmpaccqty, cmprejqty.

cmpaccqty = itab-accqty.

cmprejqty = itab-rejqty.

IF ITAB-UOM <> ITAB-ACCUOM AND ITAB-ACCUOM <> SPACE.

CALL FUNCTION 'ZCONVERT_UOM_QTY'

EXPORTING

P_FR_UOM = ITAB-UOM

P_TO_UOM = ITAB-ACCUOM

P_QTY = ITAB-ACCQTY

IMPORTING

P_RETVAL = CMPACCQTY.

ELSEIF ITAB-UOM <> ITAB-REJUOM AND ITAB-REJUOM <> SPACE.

CALL FUNCTION 'ZCONVERT_UOM_QTY'

EXPORTING

P_FR_UOM = ITAB-UOM

P_TO_UOM = ITAB-REJUOM

P_QTY = ITAB-REJQTY

IMPORTING

P_RETVAL = CMPREJQTY.

ENDIF.

v_sumqty = CMPACCQTY + CMPREJQTY.

if ( v_sumqty = itab-recqty ).

itab-qcstat = 'C'.

modify itab.

ELSE.

ITAB-QCSTAT = 'P'.

endif.

ELSE.

ITAB-QCSTAT = 'C'.

endif.

IF ITAB-QCSTAT = 'C'.

IF ITAB-DQTY = ITAB-RECQTY.

ITAB-ACSTAT = 'C'.

ELSE.

ITAB-ACSTAT = 'P'.

ENDIF.

ELSEIF ITAB-QCSTAT = 'P'.

IF ITAB-RECQTY = ITAB-DQTY.

ITAB-ACSTAT = 'O'.

ENDIF.

ENDIF.

IF ITAB-REJQTY > 0.

IF ITAB-ACSTAT = 'C' AND ITAB-REJQTY > ITAB-CQTY.

ITAB-CRNOTE = 'P'.

ELSEIF ITAB-ACSTAT = 'C' AND ITAB-REJQTY < ITAB-CQTY.

ITAB-CRNOTE = 'W'.

ELSEIF ITAB-ACSTAT = 'C' AND ITAB-REJQTY = ITAB-CQTY.

ITAB-CRNOTE = 'C'.

ENDIF.

ELSE.

ITAB-CRNOTE = 'N'.

ENDIF.

MODIFY itab.

ENDLOOP. "*********************************************"END OF MAINT LOOP FOR ITAB.***********************

DATA: it_fieldcat TYPE slis_t_fieldcat_alv,

wa_fieldcat TYPE slis_fieldcat_alv,

wa_layout TYPE slis_layout_alv.

PERFORM f_layout.

PERFORM f_fieldcat.

PERFORM display.

&----

---

*& Form F_LAYOUT

&----

---

• text

----

---

FORM f_layout.

wa_layout-colwidth_optimize = 'X'.

wa_layout-no_subchoice = 'X'.

wa_layout-zebra = 'X'.

ENDFORM. "F_LAYOUT

&----

---

*& Form F_FIELDCAT

&----

---

• text

----

---

FORM f_fieldcat.

DATA wa_col TYPE i VALUE 1.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-seltext_l = 'GR. NO'.

wa_fieldcat-fieldname = 'MBLNR'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-seltext_l = 'GR DATE'.

wa_fieldcat-fieldname = 'BUDAT'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-seltext_l = 'PO NO'.

wa_fieldcat-fieldname = 'EBELN'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-no_zero = 'X'.

wa_fieldcat-seltext_l = 'PARTY ID'.

wa_fieldcat-fieldname = 'LIFNR'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-seltext_l = 'PARTY NAME'.

wa_fieldcat-fieldname = 'NAME1'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-no_zero = 'X'.

wa_fieldcat-outputlen = '18'.

wa_fieldcat-seltext_l = 'ITEM ID'.

wa_fieldcat-fieldname = 'MATNR'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-seltext_l = 'DESCRIPTION'.

wa_fieldcat-fieldname = 'TXZ01'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-seltext_l = 'UOM'.

wa_fieldcat-fieldname = 'UOM'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-seltext_l = 'INS REQ'.

wa_fieldcat-fieldname = 'QCINS'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-no_zero = 'X'.

wa_fieldcat-seltext_l = 'GR QTY'.

wa_fieldcat-fieldname = 'RECQTY'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-seltext_l = 'QC DATE'.

wa_fieldcat-fieldname = 'QCDAT'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-no_zero = 'X'.

wa_fieldcat-seltext_l = 'ACC QTY'.

wa_fieldcat-fieldname = 'ACCQTY'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-no_zero = 'X'.

wa_fieldcat-seltext_l = 'ACC UOM'.

wa_fieldcat-fieldname = 'ACCUOM'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-no_zero = 'X'.

wa_fieldcat-seltext_l = 'REJ QTY'.

wa_fieldcat-fieldname = 'REJQTY'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-no_zero = 'X'.

wa_fieldcat-seltext_l = 'REJ UOM'.

wa_fieldcat-fieldname = 'REJUOM'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-seltext_l = 'MIRO NO'.

wa_fieldcat-fieldname = 'BELNR'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-seltext_l = 'MIRO DATE'.

wa_fieldcat-fieldname = 'MIRO_BUDAT'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-no_zero = 'X'.

wa_fieldcat-seltext_l = 'DB.QTY'.

wa_fieldcat-fieldname = 'DQTY'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-no_zero = 'X'.

wa_fieldcat-seltext_l = 'CR.QTY'.

wa_fieldcat-fieldname = 'CQTY'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat TO it_fieldcat.

CLEAR wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-seltext_l = 'QC STATUS'.

wa_fieldcat-fieldname = 'QCSTAT'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat to it_fieldcat.

clear wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-seltext_l = 'A/C STATUS'.

wa_fieldcat-fieldname = 'ACSTAT'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat to it_fieldcat.

clear wa_fieldcat.

wa_fieldcat-col_pos = wa_col + 1.

wa_fieldcat-seltext_l = 'CR NOTE STATUS'.

wa_fieldcat-fieldname = 'CRNOTE'.

wa_fieldcat-tabname = itab.

APPEND wa_fieldcat to it_fieldcat.

clear wa_fieldcat.

ENDFORM. "F_FIELDCAT

&----

---

*& Form DISPLAY

&----

---

• text

----

---

FORM display.

CALL FUNCTION 'REUSE_ALV_GRID_DISPLAY'

EXPORTING

i_callback_program = sy-repid

is_layout = wa_layout

I_CALLBACK_USER_COMMAND = 'HANDLE_USER_COMMAND'

it_fieldcat = it_fieldcat

TABLES

t_outtab = itab.

ENDFORM. "DISPLAY

FORM HANDLE_USER_COMMAND USING R_UCOMM LIKE SY-UCOMM

RS_SELFIELD TYPE SLIS_SELFIELD.

CASE R_UCOMM.

WHEN '&IC1'.

clear itab-ebeln.

IF RS_SELFIELD-FIELDNAME = 'EBELN'.

READ TABLE ITAB INDEX RS_SELFIELD-TABINDEX.

SET PARAMETER ID 'BES' FIELD ITAB-EBELN.

call transaction 'ME23N' AND SKIP FIRST SCREEN.

CLEAR RS_SELFIELD.

ELSEIF RS_SELFIELD-FIELDNAME = 'MBLNR'.

READ TABLE ITAB INDEX RS_SELFIELD-TABINDEX.

SET PARAMETER ID 'MBN' FIELD ITAB-MBLNR.

SET PARAMETER ID 'MJA' FIELD year.

call transaction 'MIGO' AND SKIP FIRST SCREEN.

CLEAR RS_SELFIELD.

ENDIF.

ENDCASE.

ENDFORM. "HANDLE_USER_COMMAND

[Former Member]

any answers wil be apriciated

[Former Member]

Ways of Performance Tuning

1. Selection Criteria

2. Select Statements

• Select Queries

• SQL Interface

• Aggregate Functions

• For all Entries

Select Over more than one internal table

Selection Criteria

1. Restrict the data to the selection criteria itself, rather than filtering it out using the ABAP code using CHECK statement.

2. Select with selection list.

SELECT * FROM SBOOK INTO SBOOK_WA.

CHECK: SBOOK_WA-CARRID = 'LH' AND

SBOOK_WA-CONNID = '0400'.

ENDSELECT.

The above code can be much more optimized by the code written below which avoids CHECK, selects with selection list

SELECT CARRID CONNID FLDATE BOOKID FROM SBOOK INTO TABLE T_SBOOK

WHERE SBOOK_WA-CARRID = 'LH' AND

SBOOK_WA-CONNID = '0400'.

Select Statements Select Queries

1. Avoid nested selects

SELECT * FROM EKKO INTO EKKO_WA.

SELECT * FROM EKAN INTO EKAN_WA

WHERE EBELN = EKKO_WA-EBELN.

ENDSELECT.

ENDSELECT.

The above code can be much more optimized by the code written below.

SELECT P_{F1 P}F2 F_{F3 F}F4 INTO TABLE ITAB

FROM EKKO AS P INNER JOIN EKAN AS F

ON P_{EBELN = F}EBELN.

Note: A simple SELECT loop is a single database access whose result is passed to the ABAP program line by line. Nested SELECT loops mean that the number of accesses in the inner loop is multiplied by the number of accesses in the outer loop. One should therefore use nested SELECT loops only if the selection in the outer loop contains very few lines or the outer loop is a SELECT SINGLE statement.

2. Select all the records in a single shot using into table clause of select statement rather than to use Append statements.

SELECT * FROM SBOOK INTO SBOOK_WA.

CHECK: SBOOK_WA-CARRID = 'LH' AND

SBOOK_WA-CONNID = '0400'.

ENDSELECT.

The above code can be much more optimized by the code written below which avoids CHECK, selects with selection list and puts the data in one shot using into table

SELECT CARRID CONNID FLDATE BOOKID FROM SBOOK INTO TABLE T_SBOOK

WHERE SBOOK_WA-CARRID = 'LH' AND

SBOOK_WA-CONNID = '0400'.

3. When a base table has multiple indices, the where clause should be in the order of the index, either a primary or a secondary index.

To choose an index, the optimizer checks the field names specified in the where clause and then uses an index that has the same order of the fields. In certain scenarios, it is advisable to check whether a new index can speed up the performance of a program. This will come handy in programs that access data from the finance tables.

4. For testing existence, use Select.. Up to 1 rows statement instead of a Select-Endselect-loop with an Exit.

SELECT * FROM SBOOK INTO SBOOK_WA

UP TO 1 ROWS

WHERE CARRID = 'LH'.

ENDSELECT.

The above code is more optimized as compared to the code mentioned below for testing existence of a record.

SELECT * FROM SBOOK INTO SBOOK_WA

WHERE CARRID = 'LH'.

EXIT.

ENDSELECT.

5. Use Select Single if all primary key fields are supplied in the Where condition .

If all primary key fields are supplied in the Where conditions you can even use Select Single.

Select Single requires one communication with the database system, whereas Select-Endselect needs two.

Select Statements SQL Interface

1. Use column updates instead of single-row updates

to update your database tables.

SELECT * FROM SFLIGHT INTO SFLIGHT_WA.

SFLIGHT_WA-SEATSOCC =

SFLIGHT_WA-SEATSOCC - 1.

UPDATE SFLIGHT FROM SFLIGHT_WA.

ENDSELECT.

The above mentioned code can be more optimized by using the following code

UPDATE SFLIGHT

SET SEATSOCC = SEATSOCC - 1.

2. For all frequently used Select statements, try to use an index.

SELECT * FROM SBOOK CLIENT SPECIFIED INTO SBOOK_WA

WHERE CARRID = 'LH'

AND CONNID = '0400'.

ENDSELECT.

The above mentioned code can be more optimized by using the following code

SELECT * FROM SBOOK CLIENT SPECIFIED INTO SBOOK_WA

WHERE MANDT IN ( SELECT MANDT FROM T000 )

AND CARRID = 'LH'

AND CONNID = '0400'.

ENDSELECT.

3. Using buffered tables improves the performance considerably.

Bypassing the buffer increases the network considerably

SELECT SINGLE * FROM T100 INTO T100_WA

BYPASSING BUFFER

WHERE SPRSL = 'D'

AND ARBGB = '00'

AND MSGNR = '999'.

The above mentioned code can be more optimized by using the following code

SELECT SINGLE * FROM T100 INTO T100_WA

WHERE SPRSL = 'D'

AND ARBGB = '00'

AND MSGNR = '999'.

Select Statements Aggregate Functions

• If you want to find the maximum, minimum, sum and average value or the count of a database column, use a select list with aggregate functions instead of computing the aggregates yourself.

Some of the Aggregate functions allowed in SAP are MAX, MIN, AVG, SUM, COUNT, COUNT( * )

Consider the following extract.

Maxno = 0.

Select * from zflight where airln = ‘LF’ and cntry = ‘IN’.

Check zflight-fligh > maxno.

Maxno = zflight-fligh.

Endselect.

The above mentioned code can be much more optimized by using the following code.

Select max( fligh ) from zflight into maxno where airln = ‘LF’ and cntry = ‘IN’.

Select Statements For All Entries

• The for all entries creates a where clause, where all the entries in the driver table are combined with OR. If the number of entries in the driver table is larger than rsdb/max_blocking_factor, several similar SQL statements are executed to limit the length of the WHERE clause.

The plus

• Large amount of data

• Mixing processing and reading of data

• Fast internal reprocessing of data

• Fast

The Minus

• Difficult to program/understand

• Memory could be critical (use FREE or PACKAGE size)

Points to be must considered FOR ALL ENTRIES

• Check that data is present in the driver table

• Sorting the driver table

• Removing duplicates from the driver table

Consider the following piece of extract

Loop at int_cntry.

Select single * from zfligh into int_fligh

where cntry = int_cntry-cntry.

Append int_fligh.

Endloop.

The above mentioned can be more optimized by using the following code.

Sort int_cntry by cntry.

Delete adjacent duplicates from int_cntry.

If NOT int_cntry[] is INITIAL.

Select * from zfligh appending table int_fligh

For all entries in int_cntry

Where cntry = int_cntry-cntry.

Endif.

Select Statements Select Over more than one Internal table

1. Its better to use a views instead of nested Select statements.

SELECT * FROM DD01L INTO DD01L_WA

WHERE DOMNAME LIKE 'CHAR%'

AND AS4LOCAL = 'A'.

SELECT SINGLE * FROM DD01T INTO DD01T_WA

WHERE DOMNAME = DD01L_WA-DOMNAME

AND AS4LOCAL = 'A'

AND AS4VERS = DD01L_WA-AS4VERS

AND DDLANGUAGE = SY-LANGU.

ENDSELECT.

The above code can be more optimized by extracting all the data from view DD01V_WA

SELECT * FROM DD01V INTO DD01V_WA

WHERE DOMNAME LIKE 'CHAR%'

AND DDLANGUAGE = SY-LANGU.

ENDSELECT

2. To read data from several logically connected tables use a join instead of nested Select statements. Joins are preferred only if all the primary key are available in WHERE clause for the tables that are joined. If the primary keys are not provided in join the Joining of tables itself takes time.

SELECT * FROM EKKO INTO EKKO_WA.

SELECT * FROM EKAN INTO EKAN_WA

WHERE EBELN = EKKO_WA-EBELN.

ENDSELECT.

ENDSELECT.

The above code can be much more optimized by the code written below.

SELECT P_{F1 P}F2 F_{F3 F}F4 INTO TABLE ITAB

FROM EKKO AS P INNER JOIN EKAN AS F

ON P_{EBELN = F}EBELN.

3. Instead of using nested Select loops it is often better to use subqueries.

SELECT * FROM SPFLI

INTO TABLE T_SPFLI

WHERE CITYFROM = 'FRANKFURT'

AND CITYTO = 'NEW YORK'.

SELECT * FROM SFLIGHT AS F

INTO SFLIGHT_WA

FOR ALL ENTRIES IN T_SPFLI

WHERE SEATSOCC < F~SEATSMAX

AND CARRID = T_SPFLI-CARRID

AND CONNID = T_SPFLI-CONNID

AND FLDATE BETWEEN '19990101' AND '19990331'.

ENDSELECT.

The above mentioned code can be even more optimized by using subqueries instead of for all entries.

SELECT * FROM SFLIGHT AS F INTO SFLIGHT_WA

WHERE SEATSOCC < F~SEATSMAX

AND EXISTS ( SELECT * FROM SPFLI

WHERE CARRID = F~CARRID

AND CONNID = F~CONNID

AND CITYFROM = 'FRANKFURT'

AND CITYTO = 'NEW YORK' )

AND FLDATE BETWEEN '19990101' AND '19990331'.

ENDSELECT.

1. Table operations should be done using explicit work areas rather than via header lines.

READ TABLE ITAB INTO WA WITH KEY K = 'X‘ BINARY SEARCH.

IS MUCH FASTER THAN USING

READ TABLE ITAB INTO WA WITH KEY K = 'X'.

If TAB has n entries, linear search runs in O( n ) time, whereas binary search takes only O( log2( n ) ).

2. Always try to use binary search instead of linear search. But don’t forget to sort your internal table before that.

READ TABLE ITAB INTO WA WITH KEY K = 'X'. IS FASTER THAN USING

READ TABLE ITAB INTO WA WITH KEY (NAME) = 'X'.

3. A dynamic key access is slower than a static one, since the key specification must be evaluated at runtime.

4. A binary search using secondary index takes considerably less time.

5. LOOP ... WHERE is faster than LOOP/CHECK because LOOP ... WHERE evaluates the specified condition internally.

LOOP AT ITAB INTO WA WHERE K = 'X'.

" ...

ENDLOOP.

The above code is much faster than using

LOOP AT ITAB INTO WA.

CHECK WA-K = 'X'.

" ...

ENDLOOP.

6. Modifying selected components using “ MODIFY itab …TRANSPORTING f1 f2.. “ accelerates the task of updating a line of an internal table.

WA-DATE = SY-DATUM.

MODIFY ITAB FROM WA INDEX 1 TRANSPORTING DATE.

The above code is more optimized as compared to

WA-DATE = SY-DATUM.

MODIFY ITAB FROM WA INDEX 1.

7. Accessing the table entries directly in a "LOOP ... ASSIGNING ..." accelerates the task of updating a set of lines of an internal table considerably

Modifying selected components only makes the program faster as compared to Modifying all lines completely.

e.g,

LOOP AT ITAB ASSIGNING <WA>.

I = SY-TABIX MOD 2.

IF I = 0.

<WA>-FLAG = 'X'.

ENDIF.

ENDLOOP.

The above code works faster as compared to

LOOP AT ITAB INTO WA.

I = SY-TABIX MOD 2.

IF I = 0.

WA-FLAG = 'X'.

MODIFY ITAB FROM WA.

ENDIF.

ENDLOOP.

8. If collect semantics is required, it is always better to use to COLLECT rather than READ BINARY and then ADD.

LOOP AT ITAB1 INTO WA1.

READ TABLE ITAB2 INTO WA2 WITH KEY K = WA1-K BINARY SEARCH.

IF SY-SUBRC = 0.

ADD: WA1-VAL1 TO WA2-VAL1,

WA1-VAL2 TO WA2-VAL2.

MODIFY ITAB2 FROM WA2 INDEX SY-TABIX TRANSPORTING VAL1 VAL2.

ELSE.

INSERT WA1 INTO ITAB2 INDEX SY-TABIX.

ENDIF.

ENDLOOP.

The above code uses BINARY SEARCH for collect semantics. READ BINARY runs in O( log2(n) ) time. The above piece of code can be more optimized by

LOOP AT ITAB1 INTO WA.

COLLECT WA INTO ITAB2.

ENDLOOP.

SORT ITAB2 BY K.

COLLECT, however, uses a hash algorithm and is therefore independent

of the number of entries (i.e. O(1)) .

9. "APPEND LINES OF itab1 TO itab2" accelerates the task of appending a table to another table considerably as compared to “ LOOP-APPEND-ENDLOOP.”

APPEND LINES OF ITAB1 TO ITAB2.

This is more optimized as compared to

LOOP AT ITAB1 INTO WA.

APPEND WA TO ITAB2.

ENDLOOP.

10. “DELETE ADJACENT DUPLICATES“ accelerates the task of deleting duplicate entries considerably as compared to “ READ-LOOP-DELETE-ENDLOOP”.

DELETE ADJACENT DUPLICATES FROM ITAB COMPARING K.

This is much more optimized as compared to

READ TABLE ITAB INDEX 1 INTO PREV_LINE.

LOOP AT ITAB FROM 2 INTO WA.

IF WA = PREV_LINE.

DELETE ITAB.

ELSE.

PREV_LINE = WA.

ENDIF.

ENDLOOP.

11. "DELETE itab FROM ... TO ..." accelerates the task of deleting a sequence of lines considerably as compared to “ DO -DELETE-ENDDO”.

DELETE ITAB FROM 450 TO 550.

This is much more optimized as compared to

DO 101 TIMES.

DELETE ITAB INDEX 450.

ENDDO.

12. Copying internal tables by using “ITAB2[ ] = ITAB1[ ]” as compared to “LOOP-APPEND-ENDLOOP”.

ITAB2[] = ITAB1[].

This is much more optimized as compared to

REFRESH ITAB2.

LOOP AT ITAB1 INTO WA.

APPEND WA TO ITAB2.

ENDLOOP.

13. Specify the sort key as restrictively as possible to run the program faster.

“SORT ITAB BY K.” makes the program runs faster as compared to “SORT ITAB.”

Internal Tables contd…

Hashed and Sorted tables

1. For single read access hashed tables are more optimized as compared to sorted tables.

2. For partial sequential access sorted tables are more optimized as compared to hashed tables

Hashed And Sorted Tables

Point # 1

Consider the following example where HTAB is a hashed table and STAB is a sorted table

DO 250 TIMES.

N = 4 * SY-INDEX.

READ TABLE HTAB INTO WA WITH TABLE KEY K = N.

IF SY-SUBRC = 0.

" ...

ENDIF.

ENDDO.

This runs faster for single read access as compared to the following same code for sorted table

DO 250 TIMES.

N = 4 * SY-INDEX.

READ TABLE STAB INTO WA WITH TABLE KEY K = N.

IF SY-SUBRC = 0.

" ...

ENDIF.

ENDDO.

Point # 2

Similarly for Partial Sequential access the STAB runs faster as compared to HTAB

LOOP AT STAB INTO WA WHERE K = SUBKEY.

" ...

ENDLOOP.

This runs faster as compared to

LOOP AT HTAB INTO WA WHERE K = SUBKEY.

" ...

ENDLOOP.

[Former Member]

1) Instead of directly taking work area, you create structure, internal table and work area.

2) Avoid joins

3) Don't use select statement in loop

4) Take the data From DB at one shot

[Former Member]

Hi

DON"T USE JOINS <

USE FOR ALL ENTRIES ALL WAYS TO IMPROVE THE PERFORMNCE AND DON"T USE SELECT STAMENT IN THE LOOP

[Former Member]

Hi,

1)Try to avoid joins

2)And remove the select inside the loop and use a read statement

3) And use a binary search for the read staement.

Regards,

siva chalasani.

[Former Member]

Hello,

Dont use select statement in the loop,

and dont use loop in the loop,

and use for all entries ,

[Former Member]

Hi,

You will always encounter this problem when you use a join on the MSEG table.I practically have experienced it.Not only on MSEG but if you are going to use joins it lowers the performance.It just makes the code look simple.Instead always try using simple select statements and move the required data into an internal table and work on those Work areas or internal tables.Everything except for the joins is fine in your code.

[Former Member]

Hi

Try to aovid nested loops

if you cant avoid better to use sorted tables this will be usefull

Regards,

siva chalasani