The text content in the dialog in invisible!

[former_member816488]

Hi All!

I am following the walk through in UI5 website!

currently i am in fragmetns and dialog , fragment callback step.

The dialog opens but the text content of the dialog is not visible!

Could anyone please help me wit this!

i18n

dialogText= {1}
dialogCloseButtonText= close<br>

fragment

<core:FragmentDefinition xmlns="sap.m"
	xmlns:core="sap.ui.core">
	<Dialog id="helloDialog"
			title="Hello {/recipient/text}"
	>
	<content>
	<core:Icon src="sap-icon://hello-World"
	           size="8rem"
	           class="sapUiMediumMarin"/>
	</content>
		<beginButton>
			<Button text="{i18n>dialogCloseButtonText}"
				press=".onCloseDialog" />
		</beginButton>

	</Dialog>
</core:FragmentDefinition><br>

controller.js

onOpenDialog: function() {
//			  Walkthrough Dialog
			
			if(!this.pDialog){
				this.pDialog = Fragment.load({
					name:"zproject.fragment.Dialog",
				});
			}
			this.pDialog.then(function(oDialog){
				oDialog.open();
			});
		},
		onCloseDialog: function(){
			this.byId("helloDialog").close();
		}<br>

[Margot]

just to verify: You are talking about the text in the button (dialogCloseButtonText) - this is not displayed. Is my understanding correct? And in the App view and HelloPanel view all text elements defined in the i18n bundle are displayed?

[former_member816488]

Hi Margot!

Yes! dialogCloseButtonText is not displayed and the event assigned to it also not working.

Also title in dialog also not visible.

About other text properties in i18n : Yes it is working, only content related to fragment file is'nt working.

I am attaching the output.

dialog-error.png

[Margot]

What errors do you get in the console?

[former_member816488]

No errors.

Only These , but i don't think it is related with the dialog!

console.png

[junwu · Accepted solution]

onOpenDialog: function() {
//			  Walkthrough Dialog
			var that=this
			if(!this.pDialog){
				this.pDialog = Fragment.load({
					name:"zproject.fragment.Dialog",
				});
			}
			this.pDialog.then(function(oDialog){
that.getView().addDependent(oDialog);
				oDialog.open();
			});
		},

[former_member816488 · Accepted solution]

Thank you Jun Wu!

Now I am getting the text content.

but the close function isn't working.

Any idea?

Thanks in advance!

[junwu · Accepted solution]

Fragment.load({
					name:"zproject.fragment.Dialog",
controller:this
				});

[former_member816488 · Accepted solution]

Hi Jun Wu!

First of all Thank you so much for the instant replies!

Actually after adding this controller:this the event onCloseDialog getting triggered atleast.

The problem now is i amgetting this error in console!

Uncaught TypeError: Cannot read properties of undefined (reading 'close')

at f.onCloseDialog.

[junwu · Accepted solution]

sap.ui.getCore().byId("helloDialog").close();

[boghyon]

Which version of UI5 Walkthrough are you following? The latest stable version page, the newer API sap.ui.core.mvc.Controller#loadFragment is used instead of the old sap.ui.core.Fragment.load. With the loadFragment API, adding the fragment (dialog) to the view's dependent aggregation is already taken care of as well as assigning the controller as the event listener (plus assigning the owner-component ID via runAsOwner but that's a different topic).

onOpenDialog: function () {
	if (!this.pDialog) {
		this.pDialog = this.loadFragment({
			name: "sap.ui.demo.walkthrough.view.HelloDialog"
		});
	} 
	this.pDialog.then(function(oDialog) {
		oDialog.open();
	});
},

Related Q&A which might be helpful:

• Methods assigned in XML fragment not triggered
• Dialog not displaying propagated model data

[former_member816488]

Hi boghyon.hoffmann!

Than You!