Deployment of MTAR fails when build-parameters: ignore: ["node_modules/"] is set

[gregorw]

Hello SAP BAS Team,

today I faced another issue that is realated to the package-lock.json (for which I've posted: How to avoid changes in package-lock.json when using local and BAS development in parallel?). As I try to keep the MTAR resulting from the build as small as possible I've added:

    build-parameters:
      ignore: ["node_modules/"]

to the mta.yaml configuration of my CAP Node.JS project for the srv and db module. But when I now build this in BAS the deploy fails as the CF build environment seems to have no access to http://nginx-redirector.repo-cache.svc.cluster.local. That causes the db deploy module to fail as the dependency:

"@sap/hdi-deploy": "^4"

was not installed during the build. I would suggest that either the issue : How to avoid changes in package-lock.json when using local and BAS development in parallel? get's solved or the CF Build process also get's access o http://nginx-redirector.repo-cache.svc.cluster.local.

Best Regards
Gregor

[gregorw]

I've filed now also the SAP Support incident 887944 / 2021.

[SebastianEsch]

I would really appreciate if the root cause of the problem would get fixed in BAS - giving the CF Build process access to the BAS NPM cache does not work in CI/CD pipelines. The BAS NPM cache should not change the URLs in package.json.

The package-lock.json is intended to be put into your SCM to have reproducible builds of your applications: https://nodejs.dev/learn/the-package-lock-json-file

At the moment there are only two options when BAS is involved in the development process: either use only BAS for development, build and deployment - or don't commit package-lock.json and track down problems caused by different package-lock.json files and different installed npm module versions for different developers and in different runtime environments.

Kind regards,

Sebastian

[YuvalA]

Hi Gregor, Sebastian,

thanks for bringing this up, we’ll look into it and update.

Thanks, Yuval

[former_member5023]

Hello Gregor Wolf,

I am also facing the same issue while deploying the mtar with build parameters: ignore:["node_mdules/"].

I have a small query regarding ignoring node modules.

For the node.js application can we ignore the node modules?

if yes then how node.js server will run without node modules.

Please let me know if you got the solution.

Regards,

Chamdeep

[gregorw]

Hi Chamdeep.

the node_modules are removed from the MTAR. But during deployment the Cloud Foundry environment installs the node_modules based on the information in package.json and very important package-lock.json. This ensures that you get the exact same versions installed.

CU
Gregor

[SebastianEsch · Accepted solution]

Hi Chamdeep,

check out the answer from Thomas Jung here https://answers.sap.com/questions/13544661/how-to-avoid-changes-in-package-lockjson-when-usin.html

Then the package-lock.json should contain URLs that can be resolved by the CF runtime.

When you exclude the node_modules folder in your MTAR, your dependencies are installed during deployment instead of included in the archive.

Cheers,

Sebastian