COMMIT/ROLLBACK in Custom Action in SAP RAP

[AZHARMCA]

Hello Experts,

I am developing an SAP RAP Based Fiori App.

And just want to know how can I make a COMMIT/ROLLBACK in the custom action where I am not using the 'create', 'update' and 'delete' operations on UI?

Thanks in advance,

[mainak-aich]

Hi, 

Why you need COMMIT/ROLLBACK? Ideally, you should modify the entity and the SAVE-SEQUENCE will start which will save the changes post validation. Your validation should control whether your change is eligible for commit or rollback.

Thanks,

Mainak

[Tracer]

Mainak, If for some reason (validation, further processing, etc) you call a standard function module that triggers a commit work inside, you cannot avoid the commit work sentence. It is very common the need to do something in a custom action that indirectly triggers a commit work. Do you have a solution for that?

[toonvl]

Hi,

The solution that I use for this is to wrap the logic with the commit/rollback in an RFC enabled FM and call that with destination ‘NONE’.

If anyone has a better solution though then please let me know, I’m not a fan of function modules..

Kr,

Toon

[Tracer]

I tested your solution, and it works like a charm, thanks. I see you eye to eye on this, I avoid using FMs whenever possible. 

[rammel_sapdev]

May I know which function module you are using?

[WRoeckelein]

If you don't like FM and are on a modern system, you can use bgPF cf https://help.sap.com/docs/abap-cloud/abap-concepts/background-processing-framework

[toonvl]

thanks for the suggestion @WRoeckelein. I'll give it a try, but based on the documentation, I'm not sure if it supports what we or at least I try to do. In my use cases I need to either execute an EML statement of a different RAP BO (which will trigger a commit) or call FM's or other logic that require a COMMIT statement before we can continue. In these cases I need to make sure that I also know the result before I can continue, and not just have the commit or rollback to happen together with my RAP object's runtime.

For example, in my last use case, I needed to convert planned orders to production orders and then update the production order header . I obviously can't execute the EML statement to update the header of the production before the production order is created as I don't know the production order id, and I will also not execute that part if the production order was not created. But I don't see how I can do the same by using bgPF?

[WRoeckelein]

@toonvl ok, if you need the result, there is IMHO no possibility. But are you sure a EML statement of a different entity will trigger a COMMIT? IMHO this will just part of the current RAP transaction and will be committed/rollbacked according to the current transactions result. But you could IMHO update the PO header in a bgPF task which will be executed depending if a COMMIT/ROLLBACK will happen. The only problem still remaining is the forwarding of the order id, but you could use a database table with mapping of planned order  id to PO order id and create the entry after BAPI call for PO creation so can read it in the the bgPF (and the bgPF has the planned order id as a parameter). COXT_BAPI_ORDER_CREATE has iv_commit parameter.

[Sijin_Chandran]

Hello, 

Since the RAP Custom Action related logic is called as part of Behavior Handler Sequence and not part of Saver Sequence, calling a Commit inside the RAP Action code is not going to work.

I had a similar situation where I had to separate a Table update activity in a Separate LUW(not the current RAP LUW) and the solution I used was CL_ABAP_PARALLEL.

Check the below threads it might help:

https://community.sap.com/t5/technology-q-a/how-to-call-a-local-rest-api-a-custom-rap-api-inside-ano...

https://community.sap.com/t5/application-development-and-automation-blog-posts/using-class-cl-abap-p...

Thanks,

Sijin

[toonvl]

@WRoeckelein I'm not sure if this is the case for all EML statements, but I tried without wrapping them into an RFC-enabled FM and I did get the am sure that it did trigger a COMMIT in this case, I first tried without and I did get a BEHAVIOR_ILLEGAL_STATEMENT runtime error. I will keep bgPF in mind when I encounter an applicable situation though.

[toonvl]

Hi Sijin,

I tried it and it worked! I just added a simple local class with the IF_ABAP_PARALLEL interface, based on the sample code in the documentation of cl_abap_parallel, made some changes to align input and output signatures, copied the logic from my FM with some minor changes to align input and output. Then I used also some more logic from the same example of the documentation to call it and it works like a charm!
Thanks for the suggestion!

Kr,
Toon

[WRoeckelein]

Ok. great!

Please also see Improvement Request: Please make bgPF also accept local classes like CL_ABAP_PARALLEL does 

[toonvl]

I have added my vote 😀 

[debde]

https://help.sap.com/docs/abap-cloud/abap-rap/rap-transactional-model-and-sap-luw

[nicmon]

Hi @toonvl , hope you are doing fine! I'm facing a similar situation where I need to create a sales order inside an action and then keep doing other processes but having already the new slaes order number available. Were you able to make it work? I'm trying to use I_SalesOrderTP BO but I'm not able to call COMMIT ENTITIES or CONVERT KEY sentences because of dumps. My system is a public cloud one so my hands are tied in a lof of ways. Thanks!