Flush method is sap mdg fpm

[karthik_subramanian]

Hi Experts,

We have used the custom uibb in MDG-C where i have a doubt as below.

When we create the Change request for Change Process, is the below code is really required as there will not be any change when the user click on the "Create Change Request" button. Kindly confirm me the same.

Consider performance, felt like to keep additional logic to skip below code when user click create CR button. Thanks

    CALL METHOD super->if_fpm_guibb_list~flush
      EXPORTING
        it_change_log   = it_change_log
        it_data         = it_data
        iv_old_lead_sel = iv_old_lead_sel
        iv_new_lead_sel = iv_new_lead_sel.

Regards,

KArthik S

[Ingmar_Schmidt]

Hi Karthik,

I guess you have inherited feeder classes. If this is the case and the superclass contains some logic in the flush method, I would consider keeping the code.

If the code in the superclass does not have any effect (for example, it checks for a certain event which you are not using) then you could get rid of it. However, in that case it should not have any effect on the runtime as well.

Cheers

Ingmar

[karthik_sub]

Hi, Thanks for the reply. When the user click on Create CR , screen loads...at that moment i feel there will not be any importing values pass to this flush method ...It will simply look for any changes in it_change_log then behave accordingly...

[Ingmar_Schmidt]

It is kind of the job of the flush method, to distribute changes in the UI data to the feeder classes. To have these updates in the model is usually quite important. I don't think this is the reason for a long runtime, maybe you can do some performance trace on user actions.

[karthik_sub]

Hi, Thanks for the clarification and for get_data method it calls around 6 times and can you suggest on any additional check to be added so that the get_data runs only once. Thanks.

[Ingmar_Schmidt]

Well, if it calls the get_data multiple times it usually should be related to a specific event. You can check for the event and only interact with the ones you need. If that is not possible, you could check if the current call is raised by you own UI with parameter iv_raised_by_own_ui. If you want to get rid of some of the calls, a deep analysis and understanding of the application would be required.

[karthik_sub]

Hi, Thanks for suggestion on this topic. so where ever if there are multiple calls hope i can adapt config condition and play around...am i right?

[Ingmar_Schmidt]

I am not sure I got your last question, but yes, if you can change things it is a good way to "play around" 😉

[karthik_subramanian]

Hi, Sure. Thanks for suggestions.

[karthik_sub]

Hi Schmidt, I have one more doubt as below...when we create the CR, observed that even the standard class/method CL_BS_BP_GUIBB_ADDRESSES=>IF_FPM_GUIBB_LIST~GET_DATA been multiple times, i can even restrict based on the event id...am i right? using some enhancement technique...Kindly correct me the same. Thanks.

[Ingmar_Schmidt]

Hi, the class seems to be part of a larger inheritance hierarchy (has super- and subclasses). Of course you can play around with it or inherit to restrict calls to it, but calls to this method (*GET_DATA) are usually vital to the application and the applications behaviour will be changed.

[karthik_subramanian]

Hi...Thanks for the suggestion.