System initialization with errors and warnings when German language is not enabled

[agrabovskis]

When German language is disabled (`lang.packs=en`), then system initialization `ant initialize` reports impex import errors (see below). Should German language be considered as mandatory, or is there a possibility for impex somehow to honour the supported languages and ignore columns with redundant languages?

The https://answers.sap.com/questions/12767308/remove-ootb-languages-in-hybris-66.html answer is not quite right, as would still require enabling the German language in `lang.packs` configuration.

Errors (just with `platform` extension enabled with v2005):

     [java] INFO  [main] [CronJobManager] importing resource /cronjob/DefaultCronJobFinishNotificationTemplate.csv
     [java] INFO  [main] (00000001-ImpEx-Import) [ImpExImportJob] Starting ImpEx cronjob "ImpEx-Import"
     [java] INFO  [main] (00000001-ImpEx-Import) [ImpExImportReader] no result provided for value line ValueLine[,line 7 at main script,null,HeaderDescriptor[line 6 at main script, remove, Media, {}, [code, mime, realfilename, @media] ],{1=ValueEntry('DefaultCronJobFinishNotificationTemplate_de'=DefaultCronJobFinishNotificationTemplate_de,unresolved=false,ignore=false), 2=ValueEntry('text/plain'=null,unresolved=null,ignore=false), 3=ValueEntry('DefaultCronJobFinishNotificationTemplate_de.vm'=null,unresolved=null,ignore=false), 4=ValueEntry('jar:/cronjob/DefaultCronJobFinishNotificationTemplate_de.vm'=null,unresolved=null,ignore=false), 5=ValueEntry(''=null,unresolved=null,ignore=false)}]
     [java] INFO  [main] (00000001-ImpEx-Import) [ImpExImportReader] no result provided for value line ValueLine[,line 8 at main script,null,HeaderDescriptor[line 6 at main script, remove, Media, {}, [code, mime, realfilename, @media] ],{1=ValueEntry('DefaultCronJobFinishNotificationTemplate_en'=DefaultCronJobFinishNotificationTemplate_en,unresolved=false,ignore=false), 2=ValueEntry('text/plain'=null,unresolved=null,ignore=false), 3=ValueEntry('DefaultCronJobFinishNotificationTemplate_en.vm'=null,unresolved=null,ignore=false), 4=ValueEntry('jar:/cronjob/DefaultCronJobFinishNotificationTemplate_en.vm'=null,unresolved=null,ignore=false), 5=ValueEntry(''=null,unresolved=null,ignore=false)}]
     [java] ERROR [main] (00000001-ImpEx-Import) [Importer] Exception 'cannot find language for value 'de'' in handling exception: cannot find language for value 'de'
     [java] WARN  [main] (00000001-ImpEx-Import) [Importer] Import aborted after 0d 00h:00m:00s:114ms
     [java] ERROR [main] (00000001-ImpEx-Import) [ImpExImportJob] cannot find language for value 'de'
     [java] de.hybris.platform.impex.jalo.ImpExException: cannot find language for value 'de'
     [java] 	at de.hybris.platform.impex.jalo.Importer.importNextInternal(Importer.java:792) ~[impexserver.jar:?]
     [java] 	at de.hybris.platform.impex.jalo.Importer.importNext(Importer.java:767) ~[impexserver.jar:?]
     [java] 	at de.hybris.platform.impex.jalo.cronjob.ImpExImportJob.doImport(ImpExImportJob.java:280) [impexserver.jar:?]
     [java] 	at de.hybris.platform.impex.jalo.cronjob.ImpExImportJob.performJob(ImpExImportJob.java:241) [impexserver.jar:?]
     [java] 	at de.hybris.platform.impex.jalo.cronjob.ImpExImportJob.performCronJob(ImpExImportJob.java:111) [impexserver.jar:?]
     [java] 	at de.hybris.platform.cronjob.jalo.Job.execute(Job.java:1372) [processingserver.jar:?]
     [java] 	at de.hybris.platform.cronjob.jalo.Job.performImpl(Job.java:796) [processingserver.jar:?]
     [java] 	at de.hybris.platform.cronjob.jalo.Job.performImpl(Job.java:711) [processingserver.jar:?]

Dumped impex lines

     [java] INFO  [main] [CatalogManager] Importing resource /catalog/essentialdatacatalog.csv
     [java] INFO  [main] (00000004-ImpEx-Import) [ImpExImportJob] Starting ImpEx cronjob "ImpEx-Import"
     [java] INFO  [main] (00000004-ImpEx-Import) [Importer] Finished 1 pass in 0d 00h:00m:00s:128ms - processed: 3, dumped: 3 (last pass: 0)
     [java] INFO  [main] (00000004-ImpEx-Import) [Importer] Starting pass 2
     [java] WARN  [main] (00000004-ImpEx-Import) [ImpExImportReader] dumped unresolved line ValueLine[,line 3 at main script,Catalog,HeaderDescriptor[line 2 at main script, insert_update, Catalog, {}, [id, name, name, defaultCatalog] ],{1=ValueEntry('<ignore>Default'=null,unresolved=null,ignore=true), 2=ValueEntry('Default-Katalog'=null,unresolved=true,reason:cannot resolve value 'Default-Katalog' for attribute 'name' because: cannot find language for value 'de',ignore=false), 3=ValueEntry('<ignore>default catalog'=null,unresolved=null,ignore=true), 4=ValueEntry('<ignore>true'=null,unresolved=null,ignore=true)}]
     [java] WARN  [main] (00000004-ImpEx-Import) [ImpExImportReader] dumped unresolved line ValueLine[,line 6 at main script,CatalogVersion,HeaderDescriptor[line 5 at main script, insert_update, CatalogVersion, {}, [catalog, version, languages, active] ],{1=ValueEntry('<ignore>Default'=null,unresolved=null,ignore=true), 2=ValueEntry('<ignore>Online'=null,unresolved=null,ignore=true), 3=ValueEntry('de,en'=null,unresolved=true,reason:cannot resolve value 'de,en' for attribute 'languages',ignore=false), 4=ValueEntry('<ignore>false'=null,unresolved=null,ignore=true)}]
     [java] WARN  [main] (00000004-ImpEx-Import) [ImpExImportReader] dumped unresolved line ValueLine[,line 7 at main script,CatalogVersion,HeaderDescriptor[line 5 at main script, insert_update, CatalogVersion, {}, [catalog, version, languages, active] ],{1=ValueEntry('<ignore>Default'=null,unresolved=null,ignore=true), 2=ValueEntry('<ignore>Staged'=null,unresolved=null,ignore=true), 3=ValueEntry('de,en'=null,unresolved=true,reason:cannot resolve value 'de,en' for attribute 'languages',ignore=false), 4=ValueEntry('<ignore>true'=null,unresolved=null,ignore=true)}]
     [java] INFO  [main] (00000004-ImpEx-Import) [Importer] Finished 2 pass in 0d 00h:00m:00s:011ms - processed: 3, dumped: 3 (last pass: 3)
     [java] WARN  [main] (00000004-ImpEx-Import) [Importer] Import aborted after 0d 00h:00m:00s:165ms
     [java] ERROR [main] (00000004-ImpEx-Import) [ImpExImportJob] Can not resolve any more lines ... Aborting further passes (at pass 2). Finally could not import 3 lines!
     [java] ERROR [main] [ImpExManager] Import has caused an error, see logs of cronjob with code=00000004-ImpEx-Import for further details

[StefanKruk · Accepted solution]

lang.packs should contain all Languages that are necessary for the System. During initialize or Update the Languages will then automatically created.

SAP Commerce has most of its content written in "en" and "de" therefore it could be that some essentialdata or projectdata will throw issues if one language is not available.

[agrabovskis · Accepted solution]

The answer is correct. However, such setup is dictated by system, not project, hence it would be a good improvement for ImpEx to honour the `lang.packs` configuration. Cannot be done as customisation, because most of the ImpEx logic is not extendable or would require some runtime or build time class adjustments (e.g. AOP).