You should extend DefaultCommerceCartCalculationStrategy and synchronize on the cartModel. This applies to calculateCart() and recalculateCart().
@Override
public boolean calculateCart(final CommerceCartParameter parameter) {
final CartModel cartModel = parameter.getCart();
validateParameterNotNull(cartModel, "Cart model cannot be null");
synchronized (modelService.getSource(cartModel)) {
// maybe try / catch needed
super.calculateCart(parameter);
}
}
Overriding the alias makes your class being used as commerceCartCalculationStrategy
<alias alias="commerceCartCalculationStrategy" name="synchronizedCommerceCartCalculationStrategy"/>
<bean id="synchronizedCommerceCartCalculationStrategy"
class="com.osudio.hybris.facades.order.impl.SynchronizedCommerceCartCalculationStrategy"
parent="defaultCommerceCartCalculationStrategy"/>
Update:
One addition to this. If you run multiple nodes in a cluster without sticky sessions, this solution is insufficient. In that case synchronized needs to be replaced by a database lock on the cart.
modelService.lock(cartModel.getPk());
It is important that this happens within a transaction (@Transactional) or
Transaction.current().begin();
try {
modelService.lock(cartModel.getPk());
// do calculation stuff
Transaction.current().commit();
} catch() {
Transaction.current().rollback();
}
You must be a registered user to add a comment. If you've already registered, sign in. Otherwise, register and sign in.