Question Re: CAP NodeJS: @mandatory does not work for Function Imports / Actions in Technology Q&A

CAP NodeJS: @mandatory does not work for Function Imports / Actions

former_member207903 — Wed, 25 Nov 2020 17:39:58 GMT

Hello colleagues!

We are running a project on top NodeJS using CAP. We noticed a few weeks ago that the annotation @mandatory in the .cds file does not work for Function Modules.

I tested with the following annotations:

- @mandatory: https://cap.cloud.sap/docs/guides/generic#mandatory
- @FieldControl.Mandatory: https://cap.cloud.sap/docs/guides/generic#mandatory
- @Common.FieldControl.Mandatory:

None of them worked, so I'm not sure if they are supposed only to work with OData v2 or v4 API calls.

Here's a action in CDS as example:

action addGoal(
description : String(200) @mandatory,
targetCompletionDate : Timestamp @mandatory,
isPrivate : Boolean @mandatory );

In the example, we can add not null after the word Timestamp, and it becomes required. But for Strings as in description, adding not null wouldn't be enough to detect a blank string.

Do you know how to enable these annotations to work or if it's a known bug for CAP?

Thanks!

Re: CAP NodeJS: @mandatory does not work for Function Imports / Actions

former_member207903 — Wed, 25 Nov 2020 19:09:52 GMT

[Update]

I also tried using Annotations with the type, but this also didn't work for my case.

Example below

define type AdditionGoal {
  description          : String(200);
  targetCompletionDate : Timestamp;
  isPrivate            : Boolean;
}// Input validation
annotate AdditionGoal with {
  description             @mandatory;
  targetCompletionDate    @mandatory;
  isPrivate               @mandatory;
}
action addGoal(
    goal : AdditionGoal
  );

I passed to the backend an entity goal with the description property empty and CAP allowed it.

Re: CAP NodeJS: @mandatory does not work for Function Imports / Actions

Former Member — Thu, 26 Nov 2020 16:14:05 GMT

Hi Igor, have you tried?

annotate AdditionGoal with {
  description @Common.FieldControl: #Mandatory
}

Re: CAP NodeJS: @mandatory does not work for Function Imports / Actions

Former Member — Thu, 26 Nov 2020 16:20:40 GMT

In fact, i use something like

annotate DhcpAdminSvc.NetworkHosts with {
  device @( 
    Common: {
      Label:'{i18n>Device Name}',
      Text: device.name,
      TextArrangement : #TextOnly,
      FieldControl: #Mandatory
    },
    ValueList.entity: 'Devices'
  );
}

I hope it helps you.

Re: CAP NodeJS: @mandatory does not work for Function Imports / Actions

former_member207903 — Thu, 26 Nov 2020 17:08:59 GMT

Hi Rafa, thanks for the reply!

Something that we did in our side is the following, we created an Argument validator which checks if we have any property with mandatory and it's value. We call this under before("*") event for each Service that we expose. The only thing tha, in case you want to reproduce this in your side, it's that we are not validating trimmed strings (e.g.: " ").

class ArgumentValidator {


  /**
   * Validates arguments with @mandatory annotation for actions and functions on .cds files
   */
  static validateArguments(data, event, serviceName) {
    services[serviceName] = services[serviceName] || cds.connect.to(serviceName);
    const eventDefinitions = services[serviceName].model.definitions[event];


    // Skip validation for events with no definitions (e.g. "READ")
    if (!eventDefinitions) {
      return;
    }


    for (const parameterName in eventDefinitions.params) {
      validateArgument(data[parameterName], eventDefinitions.params[parameterName], parameterName);
    }
  }


}


function validateArgument(providedArgument, parameterDefinition, parameterName) {
  if (parameterDefinition["@mandatory"]) {
    const isValid = providedArgument !== null && providedArgument !== undefined && providedArgument !== "";
    ErrorHandler.validate(isValid, ServiceError.ARGUMENT_MISSING, parameterName);
  }
}


module.exports = ArgumentValidator;

Re: CAP NodeJS: @mandatory does not work for Function Imports / Actions

vitaly_kozyura — Tue, 22 Dec 2020 11:00:40 GMT

Hi,

With the next CAP release the @mandatory check will be also applied for actions and functions having typed parameters. Also the String parameters annotated with @mandatory will be checked for being empty strings. You can follow CAP releases at https://cap.cloud.sap/docs/releases/.

Best regards,

Vitaly