topic Re: ABAP Code Review in Application Development and Automation Discussions

ABAP Code Review

Former Member — Mon, 09 Jun 2008 09:56:01 GMT

Hello Experts--

I have query where I will require your expert comments. I would like to check the quality of ABAP code with reference to

(a) Program logic

(b) Performance issues

(d) Buffer being used

(e) Index etc etc

Is there any tool in SAP or any third party tool which can help to check the quality of code.

Thanks in advance for your reply.

Regards

--Anshuman

Re: ABAP Code Review

Former Member — Mon, 09 Jun 2008 10:06:19 GMT

Hi,

Logic,

ask ur TL to go thru. Theres no tool that can verify your logic.

For performance, u can run your code through,

[SE30|https://www.sdn.sap.com/irj/sdn/weblogs?blog=/pub/wlg/7769] [original link is broken] [original link is broken] [original link is broken]; and [ST05|https://www.sdn.sap.com/irj/sdn/weblogs?blog=/pub/wlg/7205] [original link is broken] [original link is broken] [original link is broken];.

SLIN can be used to check the extended syntax checks.

ST05 will give the time taken by Selects, Index used and the cost to ratio of each select. Using this u can identify which one to fine tune.

regards,

madhu

Re: ABAP Code Review

Former Member — Mon, 09 Jun 2008 11:10:25 GMT

Hi,

U can check your code by going to:

Program->Check->Extendeed Program Check

Hope it helps you.

Regards,

mukul

Re: ABAP Code Review

Former Member — Mon, 09 Jun 2008 11:12:21 GMT

Hi,

Do an extended program check

code inspector check

run trace analysis on ST05

Shruthi

Re: ABAP Code Review

Former Member — Mon, 09 Jun 2008 11:55:25 GMT

Dear Anshuman,

Look at the transaction code SCI- Code Inspector and SLIN- Extended program Check - These both together will definitely help you in to a large exten check in your code review and which can help to check you ABAP Code Quality.

There also can be some obsolete statements which need to be take care of and also some SQL queries which are not longer supported in OOPs context.

So hope this will help you to a lot extent in determining the Quality Code.

There are additional Transactions like SE30, ST05 which may help you to know about the performance or time consumption of your programs as such.

Hope this too helps you.

Encourage others to answer you queries by suitably rewarding them

Thanks

Venugopal

Re: ABAP Code Review

Former Member — Mon, 09 Jun 2008 12:16:21 GMT

no there is no such tool which you are looking for.

You can so some automated tests on the coding, by using SLIN, Code Inspector, etc. But the results are restricted, many properties can noot be tested at the code but only by execution.

For performance ( joins, buffers, index etc. relate to performance) you must define test cases (program executed with certain parameters in a real system with enough data). You must execute the program

+ measure runtime and oher KPIs

+ and check the traces SE30 and ST05 for bugs with join, buffer or indexes.

Details about the traces are expalined in the blogs which I have written: Links were given above.

Siegfried

Re: ABAP Code Review

Former Member — Mon, 16 Jun 2008 14:18:44 GMT

Hi ,

There is a utility " IBM Syntax Checker " which checks performance of the report as far as joins are concerened.

you can also use code inspector to solve all issues related to indexes,buffering etc.