topic Re: Code Inspector with 'SELECT * FROM' in Application Development and Automation Discussions

Code Inspector with 'SELECT * FROM'

Former Member — Wed, 21 May 2008 13:33:05 GMT

Hello all,

I want to tell my code inspector, that it shall find

Select * from.

I put it in the ABAP STATEMENT PATTERNS but now the code inspector finds all selects for it interpretates * as wildcard.

What can I do ?

Please help

Simone

Re: Code Inspector with 'SELECT * FROM'

Former Member — Wed, 21 May 2008 13:36:43 GMT

If your intention is to only find those statements in the code you can also use report RPR_ABAP_SOURCE_SCAN and give "Select * from" as a search string and the package or program name.

Re: Code Inspector with 'SELECT * FROM'

Former Member — Wed, 21 May 2008 14:21:49 GMT

Try using single colon before and after to suppress the astrict.

Reward if helpful

Rama C

Re: Code Inspector with 'SELECT * FROM'

ThomasZloch — Thu, 22 May 2008 15:00:15 GMT

déjà vu...

Re: Code Inspector with 'SELECT * FROM'

Former Member — Fri, 23 May 2008 06:35:17 GMT

as you ask this question in the performance forum, I would also like to know why you want to see all 'select *'.

If you want to solve any performance problems then I should say, that it will not help.

Select ' are no real performance issue. Field lists are nice to have, but difference is only considerable, if you reduce the width of the table dramatically, i.e.

it is enough if you check the very width tables.

And please to not introduce new select statements which deviate from others just in the definition of the field list.

The real performance issues are the indexes, or better the selects which have no proper index support.

Siegfried

Re: Code Inspector with 'SELECT * FROM'

Former Member — Fri, 30 May 2008 06:42:40 GMT

Hello,

thanks for all your help.

´For Code Review I develop tools to automate the formal code review. Thanks to your ideas I use a combination of the report and the code inspector. For some cases I created a little report which deals with regular expressions. So now I can do the formal code review in short time and concentrate on better structures and all that other stuff.

Ciaoi

Simone