topic Re: Confusion in loop inside loop in Application Development and Automation Discussions

Confusion in loop inside loop

Former Member — Tue, 06 May 2008 03:24:17 GMT

Hi Experts,

i have some confution in below code:

here am trying to calculate Actual Billing and Planned Revenue. but here for each value am looping it_final table inside the main loop.

but the prob is if i loop it_final for one value it is giving value, but if i try to loop 2 times for 2 values, it is not giving first value also.

i.e if i comment loop for Planned Revenue then Actual Billing is displaying, if i try for 2 values, then its giving zeros for 2 values.

so could anyone check is there any mistake i did.

CLEAR: it_prps, it_final, wa_final, wa_it_prps.

LOOP AT it_prps.

CASE month.

WHEN '08'.

ACTUAL BILLING

LOOP AT it_final INTO wa_final

WHERE posid = it_prps-posid

AND wrttp = c_04

AND beltp = c_02

AND versn = c_0

AND ( vorga = c_coin OR vorga = c_rku2 ).

CLEAR act_billing.

IF sy-subrc IS INITIAL.

MOVE wa_final-wlp08 TO t_act_billing.

act_billing = act_billing + t_act_billing.

ENDIF.

CLEAR: it_prps, it_final.

ENDLOOP.

*************PLANNED REVENUE

LOOP AT it_final INTO wa_final

WHERE posid = it_prps-posid

AND wrttp = c_01

AND beltp = c_02

AND versn = c_0

AND ( vorga = c_sdor OR vorga = c_rkp5 ).

CLEAR plan_rev.

IF sy-subrc IS INITIAL.

MOVE wa_final-wlp08 TO t_plan_rev.

plan_rev = plan_rev + t_plan_rev.

ENDIF.

CLEAR: it_prps, it_final.

ENDLOOP.

ENDCASE.

ENDLOOP.

WRITE:/10 'Actual Billing is',act_billing.

WRITE:/20 'Actual Cost is........', actu_cost.

Thanks in advace,

sudharsan.

Re: Confusion in loop inside loop

peter_ruiz2 — Tue, 06 May 2008 03:36:06 GMT

hi,

CLEAR act_billing.

IF sy-subrc IS INITIAL.

MOVE wa_final-wlp08 TO t_act_billing.

act_billing = act_billing + t_act_billing.

ENDIF.

CLEAR: it_prps, it_final.

ENDLOOP.

your problem comes from here

CLEAR: it_prps, it_final

you are clearing the header line of it_prps wherein it is used as a condition for the 2nd loop.

regards,

Peter

Re: Confusion in loop inside loop

Former Member — Tue, 06 May 2008 03:53:25 GMT

Hi,

as peter said dont clear the internal table clear the work area only.

Regards

Sandipan

Re: Confusion in loop inside loop

Former Member — Tue, 06 May 2008 04:10:43 GMT

No Friends, if i clear work area also it is not giving values, if i try for 2 values.

please check is there any other reason?

Thanks in Advance,

sudharsan.

Re: Confusion in loop inside loop

Former Member — Tue, 06 May 2008 04:12:33 GMT

Hi SUDHARSAN RAO

U r clearing the headers and tables. So u cannot use the values on the nested loops as u have cleared the values. There wont be anything in the workare ur using in where clause.

Please see the below comments that I kept.

LOOP AT it_prps.

ACTUAL BILLING

LOOP AT it_final INTO wa_final

WHERE posid = it_prps-posid

AND wrttp = c_04

AND beltp = c_02

AND versn = c_0

AND ( vorga = c_coin OR vorga = c_rku2 ).

CLEAR act_billing.

IF sy-subrc IS INITIAL.

MOVE wa_final-wlp08 TO t_act_billing.

act_billing = act_billing + t_act_billing.

ENDIF.

*******************************************

CLEAR: it_prps, it_final.

Here IT_FINAL is cleared by u... should not be cleared

********************************************

ENDLOOP.

*************PLANNED REVENUE

LOOP AT it_final INTO wa_final

WHERE posid = it_prps-posid

AND wrttp = c_01

AND beltp = c_02

AND versn = c_0

AND ( vorga = c_sdor OR vorga = c_rkp5 ).

CLEAR plan_rev.

IF sy-subrc IS INITIAL.

MOVE wa_final-wlp08 TO t_plan_rev.

plan_rev = plan_rev + t_plan_rev.

ENDIF.

Again ur clearing both tables.

CLEAR: it_prps, it_final.

********************************

ENDLOOP.

ENDCASE.

ENDLOOP.

WRITE:/10 'Actual Billing is',act_billing.

WRITE:/20 'Actual Cost is........', actu_cost.

Re: Confusion in loop inside loop

peter_ruiz2 — Tue, 06 May 2008 05:17:13 GMT

hi sudharsan,

replace this code

CLEAR: it_prps, it_final.

with this


  append wa_final to it_final.
  clear wa_final.

you are not appending the data to the internal table that is why only one record is being displayed.

regards,

Peter

Re: Confusion in loop inside loop

Former Member — Tue, 06 May 2008 07:03:51 GMT

Hi Peter,

how to append wa_final TO it_final.

actually we are getting values from it_final into wa_final while looping.

btu i tried like u also, eventhrough not working.

Rgds,

sudharsan.

Re: Confusion in loop inside loop

Former Member — Tue, 06 May 2008 07:15:18 GMT

Hi,

I see that you are clearing the variable ACT_BILLING inside the loop (LOOP at IT_FINAL).

That is the variable which holds the total and you are clearing inside the loop. that is the reason when there are multiple records it is not working fine.

Remove that clear statement. similar case for PLAN_REV.

These variables can be cleared before the loop actually begins.

Thanks and Regards,

Lakshmi.

Re: Confusion in loop inside loop

peter_ruiz2 — Tue, 06 May 2008 07:30:59 GMT

i agree with Santhanalakshmi.

remove this lines.

CLEAR act_billing.

CLEAR plan_rev.

another reason for this is that your are displaying actu_cost here

WRITE:/20 'Actual Cost is........', actu_cost.

wherein you are using plan_rev.