topic Re: TIMELIMIT EXCEEDED in Application Development and Automation Discussions

TIMELIMIT EXCEEDED

Former Member — Thu, 10 Apr 2008 13:56:43 GMT

Hello.

My program reads a whole lot of data..

Now after a while I get this error: 'Time Limit Exceeded'.

What are possible things to do cause I can't run it in background because after the reading I want to output a summary of wat data is readed..

Thx

Re: TIMELIMIT EXCEEDED

Former Member — Thu, 10 Apr 2008 14:00:15 GMT

execute it in background and get that output summary from spool... or you can download that output to some file on application server.

G@urav.

Re: TIMELIMIT EXCEEDED

Former Member — Thu, 10 Apr 2008 14:04:27 GMT

maybe split your program into 2 separate programs:

first program will be read a lot of data and save this

data into z-table (in background)

and second program will be read this z-table and display

result?

best regards,darek

Re: TIMELIMIT EXCEEDED

Former Member — Thu, 10 Apr 2008 14:06:31 GMT

Hi Bert,

I presume the program needs fine tuning, may be that cud solve the issue.

Share the program, may be we could help you out

Regards,

Raja

Re: TIMELIMIT EXCEEDED

Former Member — Thu, 10 Apr 2008 14:24:19 GMT

Yes but when I split the program. And run one part in background.

How do I continue after the first part is finished?

Re: TIMELIMIT EXCEEDED

Former Member — Thu, 10 Apr 2008 14:29:54 GMT

Here s part of the program:


FIELD-SYMBOLS: <it> TYPE STANDARD TABLE,
                 <temp>,
                 <wa> TYPE ANY.

* create a dynamic table of the infotype
  DATA: infty_tab_pointer TYPE REF TO data.
  CREATE DATA infty_tab_pointer TYPE TABLE OF (tabname).
  ASSIGN infty_tab_pointer->* TO <it>.

    LOOP AT i_objects.
*     get data form internal table tabname into <it>
      SELECT * FROM (tabname) INTO CORRESPONDING FIELDS OF TABLE <it>
WHERE objid EQ i_objects-objid.

*      loop at every record of the selection
      LOOP AT <it> ASSIGNING <temp> .

*        loop at every datafield of the record
        LOOP AT datafields WHERE infotype = tabname.
          ASSIGN COMPONENT datafields-field_name OF STRUCTURE
<temp> TO <wa>.

          MOVE <wa> TO output_tab_pd-data+datafields-field_start.
        ENDLOOP.

        output_tab_pd-infotype = tabname.
        APPEND output_tab_pd.
      ENDLOOP.
    ENDLOOP.

Now look: This part of code is called for every selected table:

It loops through all objects and selects all data from that object from the table.

It loops through all selected records of the table and splits them with datafields. (datafields contains the structure of every table with the startposition so I can split it later on again).

Now everything goes write.

But when theres to much data selected (when this loop ' LOOP AT <it> ASSIGNING <temp> ' is executed more than 50.000 times ) it stops and gives the error (after 1200 secs. it says..)

Re: TIMELIMIT EXCEEDED

Former Member — Fri, 11 Apr 2008 07:30:45 GMT

simple scenario is:

user check manually in sm37 if the first report finished

or user receive e-mail about finshed job

(first report writing result to z-table)

after that user execute second report which reads

z-table and display result

best regards, darek

Re: TIMELIMIT EXCEEDED

Former Member — Fri, 11 Apr 2008 08:04:25 GMT

Yes but my boss isn't gonna like that.

there must be as little user-interaction as possible..

Re: TIMELIMIT EXCEEDED

Former Member — Fri, 11 Apr 2008 08:08:36 GMT

Try to increase the time limit to ... say 1800 seconds...

Re: TIMELIMIT EXCEEDED

Former Member — Fri, 11 Apr 2008 08:17:53 GMT

hi,

Reason is , with in a loop you are extracting the data from database table.

Do one thing remove the select statement from loop and use for all entries...

IF NOT i_objects[] IS INITIAL.

SELECT * FROM (tabname)

INTO CORRESPONDING FIELDS OF TABLE <it>

FOR ALL ENTRIES IN i_objects

WHERE objid EQ i_objects-objid.

ENDIF.

If you have multiple records for each objid you loop with in loop else use read statement.

1. IF you have multiple records

LOOP AT i_objects.

loop at every record of the selection

LOOP AT <it> ASSIGNING <temp> WHERE objid EQ i_objects-objid .

loop at every datafield of the record

LOOP AT datafields WHERE infotype = tabname.

ASSIGN COMPONENT datafields-field_name OF STRUCTURE

<temp> TO <wa>.

MOVE <wa> TO output_tab_pd-data+datafields-field_start.

ENDLOOP.

output_tab_pd-infotype = tabname.

APPEND output_tab_pd.

ENDLOOP.

Re: TIMELIMIT EXCEEDED

Former Member — Fri, 11 Apr 2008 08:38:45 GMT

hi,

U can use progress indicator to avoid "Time Limit Exceeded "

After applying loop

use

CALL FUNCTION 'PROGRESS_INDICATOR'

EXPORTING

I_TEXT = 'Processing........ '.

second option is .

u can use binary search or other sorting methods to reduce time.

Re: TIMELIMIT EXCEEDED

Former Member — Fri, 11 Apr 2008 09:15:46 GMT

It seems to give an error.. Any idea why?

Re: TIMELIMIT EXCEEDED

Former Member — Fri, 11 Apr 2008 09:22:31 GMT

Where would I have to put the progress indicator?

Re: TIMELIMIT EXCEEDED

Former Member — Fri, 11 Apr 2008 12:06:52 GMT

Lol I've just tried it with the progress indicator.

After 50 minutes I get the following error:

Memory low. Leave the transaction before taking a break!

I checked the tables in debug, and its around 1.5 million records now..

any ideas how to speed things up a bit..?

Re: TIMELIMIT EXCEEDED

Former Member — Fri, 11 Apr 2008 12:49:21 GMT

When I try to include FOR ALL ENTRIES IN It always loops trough every personell number even when I only have 1 number in the table..

Any idea what this could be?

Re: TIMELIMIT EXCEEDED

che_eky — Fri, 11 Apr 2008 13:01:18 GMT

For sure use the FOR ALL ENTRIES suggestion as that will improve performance BUT check table i_objects is not empty first. Also make sure table DATAFIELDS is a sorted table to help speed up the loop search.

Re: TIMELIMIT EXCEEDED

Former Member — Fri, 11 Apr 2008 13:03:44 GMT

Hello.. Problem is that the table isn't empty :s

No mather wat the contents is, it always takes all records.

And can you explain a sorted table a bit more..?

Thx

Re: TIMELIMIT EXCEEDED

former_member194669 — Fri, 11 Apr 2008 13:12:58 GMT

Try this way


FIELD-SYMBOLS: <it> TYPE STANDARD TABLE,
                 <temp>,
                 <wa> TYPE ANY.
 
  DATA: infty_tab_pointer TYPE REF TO data.
  CREATE DATA infty_tab_pointer TYPE TABLE OF (tabname).
  ASSIGN infty_tab_pointer->* TO <it>.
    if not i_objects[] is initial.
      SELECT * FROM (tabname) INTO CORRESPONDING FIELDS OF TABLE <it>
         for all entries in i_objects
         WHERE objid EQ i_objects-objid.        
    endif.

    LOOP AT i_objects.
      LOOP AT <it> ASSIGNING <temp> where objid EQ i_objects-objid.
        LOOP AT datafields WHERE infotype = tabname.
          ASSIGN COMPONENT datafields-field_name OF 
                    STRUCTURE <temp> TO <wa>.
           MOVE <wa> TO output_tab_pd-data+datafields-field_start.
        ENDLOOP.
         output_tab_pd-infotype = tabname.
        APPEND output_tab_pd.
      ENDLOOP.
    ENDLOOP.

a®

Re: TIMELIMIT EXCEEDED

Former Member — Fri, 11 Apr 2008 13:17:12 GMT

Same problem.. I always get a selection without where cause..

Re: TIMELIMIT EXCEEDED

che_eky — Fri, 11 Apr 2008 13:18:20 GMT

Sure.

For the following loop over datafields:

LOOP AT datafields WHERE infotype = tabname.

it makes sense to declare datafields as a sorted table with non-unique key infotype. Doing this will speed up the above loop statement as a full table scan is not needed. Make sure datafields is sorted by field infotype and it is the first column in the table.

As for the FOR ALL ENTRIES are you using the correct construct, like this:

if i_objects[] is not initial.

SELECT *

FROM (tabname)

INTO CORRESPONDING FIELDS OF TABLE <it>

FOR ALL ENTRIES IN i_objects

WHERE objid EQ i_objects-objid.

endif.

Hope it helps some.