topic Re: wrong select statement in Application Development and Automation Discussions

wrong select statement

Former Member — Thu, 20 Mar 2008 07:59:33 GMT

Hello,

the following code is a part of a function module. My problem is that the field language is still empty, although there is an according value.

What is wrong with this code? Please hlep me!

Regards

Philipp

DATA: language TYPE sylangu,

cv_language TYPE sylangu,

ls_orderadm_h TYPE crmt_orderadm_h_wrkt.

tables: STXH, CRMD_ORDERADM_H.

SELECT a~tdspras INTO language

FROM STXH as a

INNER JOIN CRMD_ORDERADM_H as b

ON a_{tdname = b}guid

WHERE b~object_id EQ ls_orderadm_h-object_id.

ENDSELECT.

IF language IS NOT INITIAL.

cv_language = language.

ELSE.

cv_language = sy-langu.

ENDIF.

Re: wrong select statement

Former Member — Thu, 20 Mar 2008 08:03:23 GMT

hi,

do this way ..

if not ls_orderadm_h[] is initial.

SELECT a~tdspras INTO language

FROM STXH as a

INNER JOIN CRMD_ORDERADM_H as b

ON a_{tdname = b}guid

for all entries in ls_orderadm_h

WHERE b~object_id EQ ls_orderadm_h-object_id.

ENDSELECT.

endif.

Re: wrong select statement

Former Member — Thu, 20 Mar 2008 08:08:50 GMT

Try seperating the selections, The join statement disterb you.

2 possible solutions:

1.Select all records from first table and than loop

at this internal table and select from second

table.

2. Use left outer join if it's OK with your

functionality.

Please reward if helpfull..

Rebeka.

Re: wrong select statement

Former Member — Thu, 20 Mar 2008 08:23:55 GMT

Hello Santosh,

your code don´t work.

The field language is still empty.

Regards

Philipp

Re: wrong select statement

Former Member — Thu, 20 Mar 2008 08:27:23 GMT

Hi Philipp,

anyways u r not processing selected value inside select / endselect...

Also , u r not using all key fields from both table...so language field can not be single...

it is better to use...select...into table it_lang...it'll definitely improve the performance also...

this code may help u...

*===========================================

types : begin of ty_lang,

language TYPE sy-langu,

end of ty_lang.

data : it_lang type table of ty_lang,

wa_lang type ty_lang.

SELECT a~tdspras INTO it_lang

FROM STXH as a

INNER JOIN CRMD_ORDERADM_H as b

ON a_{tdname = b}guid

WHERE b~object_id EQ ls_orderadm_h-object_id.

read table it_lang into wa_lang where language is not initial.

IF sy-subrc = 0.

cv_language = wa_lang-language.

ELSE.

cv_language = sy-langu.

endif.

*============================================

Reward points if useful...

Sachin

Re: wrong select statement

Former Member — Thu, 20 Mar 2008 08:27:48 GMT

have you checked whether there is any suitable record in the table satisfying the select condition ....

Regards,

Santosh

Re: wrong select statement

Former Member — Thu, 20 Mar 2008 08:33:49 GMT

Hello Sachin,

it_lang is an internal table and is not allowed.

Regards

Philipp

Re: wrong select statement

Former Member — Thu, 20 Mar 2008 08:35:14 GMT

Hello Santosh,

yes there exists an according value.

Regards

Philipp

Re: wrong select statement

Former Member — Thu, 20 Mar 2008 08:50:14 GMT

hi Philip,

Remove join and use for all entries statement then.

Regards,

Santosh

Re: wrong select statement

Former Member — Thu, 20 Mar 2008 08:55:50 GMT

Just check both the tables for the record u r looking for.

also use SELECT SINGLE instead of SELECT-ENDSELECT.

Reward if useful.

S@meer

Re: wrong select statement

Former Member — Thu, 20 Mar 2008 09:00:09 GMT

Try this,

SELECT single a~tdspras INTO language

FROM STXH as a

INNER JOIN CRMD_ORDERADM_H as b

ON a_{tdname = b}guid

WHERE b~object_id EQ ls_orderadm_h-object_id.

IF language IS NOT INITIAL.

cv_language = language.

ELSE.

cv_language = sy-langu.

ENDIF.

SELECT a~tdspras INTO language

FROM STXH as a

INNER JOIN CRMD_ORDERADM_H as b

ON a_{tdname = b}guid

WHERE b~object_id EQ ls_orderadm_h-object_id.

IF language IS NOT INITIAL.

cv_language = language.

ELSE.

cv_language = sy-langu.

ENDIF.

ENDSELECT.