topic Re: regarding editable alv in Application Development and Automation Discussions

topic Re: regarding editable alv in Application Development and Automation Discussions https://community.sap.com/t5/application-development-and-automation-discussions/regarding-editable-alv/m-p/3378230#M811146 <HTML><HEAD></HEAD><BODY><P>Hi,</P><P></P><P>First of all It is not a good programming practice to update database table directly from the program. It will avoid all the validations & there may be unknown other tables that need to be updated when you update your table.</P><P></P><P>The following statement i feel is wrong, because table VBAP and I_FINAL are not the same structure. </P><P></P><P>MODIFY VBAP FROM TABLE i_final.</P><P></P><P>Instead try like this.</P><P></P><P>UPDATE VBAP set <vbap field> = i_final-field</P><P> <vbap field> = i_final-field</P><P> ...</P><P> where VBELN = i_final-field.</P><P></P><P>Hope this helps..</P><P>Harikrishna.</P></BODY></HTML> Mon, 18 Feb 2008 07:49:25 GMT Former Member 2008-02-18T07:49:25Z regarding editable alv https://community.sap.com/t5/application-development-and-automation-discussions/regarding-editable-alv/m-p/3378228#M811144 <HTML><HEAD></HEAD><BODY><P>Hi all,</P><P> Frnds i am working in editable alv using function modules not object oriented abap.</P><P></P><P>i m trying to edit a Field(MATNR ) in my output list and finally update it with changed values in the DB table.</P><P>But i m getting syntax error like</P><P>"the work area i_final is not alligned properly</P><P></P><P>below i m providing my code.</P><P></P><P><code></P><P></P><P><STRONG>&----</STRONG></P><HR originaltext="----------------------------------------------------------------" /><P></P><P>*& Report ZEDITABLE_ALV1</P><P>*&</P><P><STRONG>&----</STRONG></P><HR originaltext="----------------------------------------------------------------" /><P></P><P>*&</P><P>*&</P><P><STRONG>&----</STRONG></P><HR originaltext="----------------------------------------------------------------" /><P></P><P></P><P>REPORT ZEDITABLE_ALV1.</P><P></P><P></P><P>TABLES: vbak,vbap.</P><P></P><P>TYPE-POOLS: slis. "ALV Declarations</P><P></P><P>data: BEGIN OF i_final occurs 0,</P><P> vbeln like vbap-vbeln,</P><P> posnr like vbap-posnr,</P><P> matnr like vbap-matnr,</P><P> erdat like vbap-erdat,</P><P>END OF i_final.</P><P></P><P>DATA : C_X(1) TYPE C VALUE 'X',</P><P> C_FC_MODIFY(6) TYPE C VALUE 'MODIFY'.</P><P>*DATA: i_final TYPE STANDARD TABLE OF T_FINAL with header line.</P><UL><LI level="1" type="ul"><P> i_temp type standard table of T_FINAL with header line.</P></LI></UL><P>*wa_final like line of i_final.</P><P></P><P>*DATA:i_final LIKE vbap OCCURS 0.</P><P>*DATA:wa_final LIKE vbap.</P><P></P><P>*ALV data declarations</P><P>DATA: fieldcatalog TYPE slis_t_fieldcat_alv WITH HEADER LINE,</P><P>gd_tab_group TYPE slis_t_sp_group_alv,</P><P>gd_layout TYPE slis_layout_alv,</P><P>gd_repid LIKE sy-repid.</P><P>*Start-of-selection.</P><P>START-OF-SELECTION.</P><P></P><P>PERFORM data_retrieval.</P><P>PERFORM build_fieldcatalog.</P><P>PERFORM build_layout.</P><P>PERFORM display_alv_report.</P><P>*&----</P><HR originaltext="----------------------------------------------------------------" /><P>*& Form BUILD_FIELDCATALOG</P><P>*&----</P><HR originaltext="----------------------------------------------------------------" /><P>* Build Fieldcatalog for ALV Report</P><P>*----</P><HR originaltext="-----------------------------------------------------------------" /><P>FORM build_fieldcatalog.</P><P></P><P>fieldcatalog-fieldname = 'VBELN'.</P><P>fieldcatalog-seltext_m = 'sales order'.</P><P>fieldcatalog-col_pos = 0.</P><P>APPEND fieldcatalog TO fieldcatalog.</P><P>CLEAR fieldcatalog.</P><P></P><P>fieldcatalog-fieldname = 'ERDAT'.</P><P>fieldcatalog-seltext_m = 'date'.</P><P>fieldcatalog-col_pos = 1.</P><P>APPEND fieldcatalog TO fieldcatalog.</P><P>CLEAR fieldcatalog.</P><P></P><P>fieldcatalog-fieldname = 'MATNR'.</P><P>fieldcatalog-seltext_m = 'material no.'.</P><P>fieldcatalog-col_pos = 2.</P><P>fieldcatalog-edit = 'X'.</P><P>APPEND fieldcatalog TO fieldcatalog.</P><P>CLEAR fieldcatalog.</P><P></P><P>fieldcatalog-fieldname = 'POSNR'.</P><P>fieldcatalog-seltext_m = 'line item no.'.</P><P>fieldcatalog-col_pos = 3.</P><P>APPEND fieldcatalog TO fieldcatalog.</P><P>CLEAR fieldcatalog.</P><P></P><P>fieldcatalog-FIELDNAME = 'REC_SEL'.</P><P>fieldcatalog-NO_OUT = C_X.</P><P>APPEND fieldcatalog TO fieldcatalog.</P><P>CLEAR fieldcatalog.</P><P>ENDFORM. " BUILD_FIELDCATALOG</P><P>*&----</P><HR originaltext="----------------------------------------------------------------" /><P>*& Form BUILD_LAYOUT</P><P>*&----</P><HR originaltext="----------------------------------------------------------------" /><P>* Build layout for ALV grid report</P><P>*----</P><HR originaltext="-----------------------------------------------------------------" /><P>FORM build_layout.</P><P>gd_layout-no_input = 'X'.</P><P>gd_layout-colwidth_optimize = 'X'.</P><P>gd_layout-totals_text = 'Totals'(201).</P><P> gd_layout-totals_only = 'X'.</P><P> gd_layout-f2code = 'DISP'. "Sets fcode for when double</P><P> "click(press f2)</P><P> gd_layout-zebra = 'X'.</P><P> gd_layout-group_change_edit = 'X'.</P><P> gd_layout-header_text = 'helllllo'.</P><P>ENDFORM. " BUILD_LAYOUT</P><P></P><P>*&----</P><HR originaltext="----------------------------------------------------------------" /><P>*& Form DISPLAY_ALV_REPORT</P><P>*&----</P><HR originaltext="----------------------------------------------------------------" /><P>* Display report using ALV grid</P><P>*----</P><HR originaltext="-----------------------------------------------------------------" /><P>FORM display_alv_report.</P><P>gd_repid = sy-repid.</P><P>CALL FUNCTION 'REUSE_ALV_GRID_DISPLAY'</P><P>EXPORTING</P><P>i_callback_program = gd_repid</P><P>i_callback_user_command = 'USER_COMMAND'</P><P>i_callback_pf_status_set = 'GUI_STAT'</P><P>*i_grid_title = outtext</P><P>is_layout = gd_layout</P><P>it_fieldcat = fieldcatalog[]</P><P>*it_special_groups = gd_tabgroup</P><P>*it_events = it_events</P><P>i_save = 'X'</P><P>*is_variant = z_template</P><P>TABLES</P><P>t_outtab = i_final</P><P>EXCEPTIONS</P><P>program_error = 1</P><P>OTHERS = 2.</P><P>IF sy-subrc <> 0.</P><P>MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO</P><P>WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.</P><P>ENDIF.</P><P>ENDFORM. " DISPLAY_ALV_REPORT</P><P>*&----</P><HR originaltext="----------------------------------------------------------------" /><P>**& Form DATA_RETRIEVAL</P><P>*&----</P><HR originaltext="----------------------------------------------------------------" /><P>* Retrieve data form EKPO table and populate itab it_ekko</P><P>*----</P><HR originaltext="-----------------------------------------------------------------" /><P>FORM data_retrieval.</P><P></P><P>*SELECT a<SUB>vbeln a</SUB>erdat b<SUB>matnr b</SUB>posnr FROM vbak AS a</P><P>*INNER JOIN vbap AS b ON a<SUB>vbeln = b</SUB>vbeln</P><P>*INTO TABLE i_final WHERE a~vbeln = b~vbeln.</P><P></P><P>select VBELN ERDAT MATNR POSNR up to 10 rows from vbap into corresponding fields of table i_final.</P><P></P><P></P><P>ENDFORM. " DATA_RETRIEVAL</P><P>*</P><P>*----</P><HR originaltext="----------------------------------------------------------------" /><P>* FORM GUI_STAT *</P><P>*----</P><HR originaltext="----------------------------------------------------------------" /><P>* ........ *</P><P>*----</P><HR originaltext="----------------------------------------------------------------" /><P>* --> RT_EXTAB *</P><P>*----</P><HR originaltext="----------------------------------------------------------------" /><P>FORM gui_stat USING rt_extab TYPE slis_t_extab.</P><P>SET PF-STATUS 'MODIFY' EXCLUDING rt_extab.</P><P>ENDFORM.</P><P>*----</P><HR originaltext="----------------------------------------------------------------" /><P>* FORM USER_COMMAND *</P><P>*----</P><HR originaltext="----------------------------------------------------------------" /><P>* ........ *</P><P>*----</P><HR originaltext="----------------------------------------------------------------" /><P>* --> U_COMM *</P><P>* --> RS_SELFIELD *</P><P>*----</P><HR originaltext="----------------------------------------------------------------" /><P>FORM user_command USING u_comm LIKE sy-ucomm</P><P>rs_selfield TYPE slis_selfield.</P><P>DATA:selfield TYPE slis_selfield.</P><P></P><P>*RS_SELFIELD-REFRESH = C_X.</P><P></P><P>CASE u_comm.</P><P></P><P>*IF U_COMM = C_FC_MODIFY.</P><P></P><P></P><P></P><P>WHEN 'UPDATE'.</P><P></P><P></P><P>LOOP AT i_final. " into wa_final."into wa_final.</P><P></P><P>*READ TABLE I_TEMP WITH KEY VBELN = I_FINAL-VBELN.</P><P>*IF SY-SUBRC = 0.</P><P>i_final-matnr = vbap-matnr.</P><P></P><P>*MODIFY I_final INDEX SY-TABIX.</P><P>*ENDIF.</P><P>ENDLOOP.</P><P>*ENDIF.</P><P>MODIFY VBAP FROM TABLE i_final.</P><P>IF SY-SUBRC = 0.</P><P>COMMIT WORK AND WAIT.</P><P>*MESSAGE I000 WITH SY-DBCNT</P><P>*' Record(s) has been Updated'(020).</P><P>ENDIF.</P><P></P><P>*append i_final.</P><P>*it_temp = i_final.</P><P>*append it_temp.</P><P>*</P><P>**UPDATE sflight FROM TABLE sflight_tab.</P><P>*ENDLOOP.</P><P>*update vbap from table i_final.</P><P>*IF sy-subrc = 0.</P><P>*MESSAGE s000(0) WITH 'records updated successfully'.</P><P>*ENDIF.</P><P>ENDCASE.</P><P>ENDFORM.</P><P></P><P></code></P><P></P><P>Frnds plz help me in this regard.</P><P></P><P>Thanks,</P><P>satya</P></BODY></HTML> Mon, 18 Feb 2008 07:20:21 GMT https://community.sap.com/t5/application-development-and-automation-discussions/regarding-editable-alv/m-p/3378228#M811144 Former Member 2008-02-18T07:20:21Z Re: regarding editable alv https://community.sap.com/t5/application-development-and-automation-discussions/regarding-editable-alv/m-p/3378229#M811145 <HTML><HEAD></HEAD><BODY><P>Do Mark the Line....</P></BODY></HTML> Mon, 18 Feb 2008 07:39:04 GMT https://community.sap.com/t5/application-development-and-automation-discussions/regarding-editable-alv/m-p/3378229#M811145 kesavadas_thekkillath 2008-02-18T07:39:04Z Re: regarding editable alv https://community.sap.com/t5/application-development-and-automation-discussions/regarding-editable-alv/m-p/3378230#M811146 <HTML><HEAD></HEAD><BODY><P>Hi,</P><P></P><P>First of all It is not a good programming practice to update database table directly from the program. It will avoid all the validations & there may be unknown other tables that need to be updated when you update your table.</P><P></P><P>The following statement i feel is wrong, because table VBAP and I_FINAL are not the same structure. </P><P></P><P>MODIFY VBAP FROM TABLE i_final.</P><P></P><P>Instead try like this.</P><P></P><P>UPDATE VBAP set <vbap field> = i_final-field</P><P> <vbap field> = i_final-field</P><P> ...</P><P> where VBELN = i_final-field.</P><P></P><P>Hope this helps..</P><P>Harikrishna.</P></BODY></HTML> Mon, 18 Feb 2008 07:49:25 GMT https://community.sap.com/t5/application-development-and-automation-discussions/regarding-editable-alv/m-p/3378230#M811146 Former Member 2008-02-18T07:49:25Z Re: regarding editable alv https://community.sap.com/t5/application-development-and-automation-discussions/regarding-editable-alv/m-p/3378231#M811147 <HTML><HEAD></HEAD><BODY><P>Hi Keshu,</P><P> That syntax error got solved but my problem is </P><P></P><P>I am able to edit the output field (matnr) but my problem is its not modifying and updating the table vbap .</P><P></P><P></P><P>can you help me regarding this.</P><P></P><P></P><P>regards,</P><P>satya</P></BODY></HTML> Mon, 18 Feb 2008 07:52:33 GMT https://community.sap.com/t5/application-development-and-automation-discussions/regarding-editable-alv/m-p/3378231#M811147 Former Member 2008-02-18T07:52:33Z Re: regarding editable alv https://community.sap.com/t5/application-development-and-automation-discussions/regarding-editable-alv/m-p/3378232#M811148 <HTML><HEAD></HEAD><BODY><P>Try something like this...ur code was not clear..i have done something u can understand.</P><P></P><P>First check that u r not trying to update the primary key field.</P><P>first before updating.</P><P></P><P>Before updating select the record u r going to update from the main table.</P><P></P><P>select single * from VBAP where <pass the key values>.</P><P>if sy-subrc = 0.</P><P>move the rest of the values to the table header except the key values.</P><P>vbap-<field1> = value1.</P><P>vbap-<field2> = value2.</P><P></P><P>after moving the values.</P><P></P><P>update <table>.</P><P>if sy-subrc = 0.</P><P>commit work.</P><P>endif.</P><P></P><P></P><P></P><P>*****************************************</P><P></P><P>data:st_vbap type vbap.</P><P>WHEN 'UPDATE'.</P><P></P><P>LOOP AT i_final. " into wa_final."into wa_final.</P><P>select single * from vbap where vbeln = I_FINAL-VBELN.</P><P>move-corresponding i_final to vbap.</P><P>update vbap.</P><P>if sy-subrc = 0.</P><P>commit work.</P><P>wk_cnt = wk_cnt + 1.</P><P>endif.</P><P></P><P>at last.</P><P>*MESSAGE I000 WITH SY-DBCNT</P><P>*' Record(s) has been Updated'(020).</P><P>endat.</P><P></P><P>endloop</P></BODY></HTML> Mon, 18 Feb 2008 08:20:10 GMT https://community.sap.com/t5/application-development-and-automation-discussions/regarding-editable-alv/m-p/3378232#M811148 kesavadas_thekkillath 2008-02-18T08:20:10Z Re: regarding editable alv https://community.sap.com/t5/application-development-and-automation-discussions/regarding-editable-alv/m-p/3378233#M811149 <HTML><HEAD></HEAD><BODY><P>Hi keshu ,</P><P></P><P> I like to say, it never recommand to change the table from any Z program. Although if your recommand are like that onyl then go ahead but try some bapi or BDC.</P><P></P><P>About the Table updation not happening,better you check your command.</P><P></P><P>But before doing the such things please</P><P></P><P>Lock the table,So that no one can else change the same table entry at the same time.</P><P></P><P>I hope it may be use full.</P><P></P><P>Regards</P><P>Swati</P></BODY></HTML> Mon, 18 Feb 2008 08:25:59 GMT https://community.sap.com/t5/application-development-and-automation-discussions/regarding-editable-alv/m-p/3378233#M811149 Former Member 2008-02-18T08:25:59Z