topic Re: Urgent ..... check the program code, in Application Development and Automation Discussions

Urgent ..... check the program code,

Former Member — Tue, 11 Dec 2007 09:22:13 GMT

The below is my code, my superior say that ,this is not correct

he suggest me not use OCCUR or With header line,

And even is there anything worng in ''Start od selection''

so anyone check my code and tell me what is worng in it and what correct is required

____________________________________________________________________

Tables: LIKP, LIPS, VBRK, VBRP, KNA1, MARA, MAKT, vbpa, VBAK.

DATA : itab type STANDARD TABLE OF ZTARA_STRUC WITH HEADER LINE.

Select-options: so_kunnr for kna1-kunnr,

So_Fkdat for vbrk-fkdat.

data : container type ref to cl_gui_custom_container,

grid type ref to cl_gui_alv_grid,

fieldcat type lvc_t_fcat.

DATA : lt_vbrk type STANDARD TABLE OF vbrk WITH HEADER LINE,

lt_vbrp TYPE STANDARD TABLE OF vbap WITH HEADER LINE,

lt_VBAK TYPE STANDARD TABLE OF VBAK WITH HEADER LINE,

lt_veda TYPE STANDARD TABLE OF veda WITH HEADER LINE,

lt_kna1 TYPE STANDARD TABLE OF KNA1 WITH HEADER LINE,

it_vbak type standard table of vbak with header line.

Start-of-selection.

so_kunnr = so_kunnr-low.

So_Fkdat = So_Fkdat-low.

SELECT kunnr Name1 ort01 FROM KNA1 INTO CORRESPONDING FIELDS OF TABLE lt_kna1

WHERE kunnr in so_kunnr.

loop at lt_kna1.

itab-CUSTOMER_NUMBER = lt_kna1-kunnr.

itab-CUSTOMER_NAME = lt_kna1-Name1.

itab-city = lt_kna1-ort01.

SELECT vbeln fkdat kunag FROM VBRK INTO CORRESPONDING FIELDS OF TABLE lt_vbrk

WHERE kunag = itab-CUSTOMER_NUMBER

AND Fkdat in So_Fkdat.

if sy-SUBRC = 0.

LOOP AT lt_vbrk.

itab-SOLD2PARTY = lt_kna1-kunnr.

itab-INVOICE_DATE = lt_vbrk-Fkdat.

itab-Vbeln = lt_vbrk-Vbeln.

SELECT POSNR Matnr ARKTX FROM vbrp INTO CORRESPONDING FIELDS OF TABLE lt_vbrp

WHERE vbeln = itab-Vbeln.

LOOP AT lt_vbrp.

itab-MATERIAL_DESCRIP = lt_vbrp-ARKTX.

SELECT AUDAT FROM VBAK INTO CORRESPONDING FIELDS OF TABLE lt_VBAK

WHERE VBELN = itab-VBELN.

LOOP AT lt_VBAK.

itab-AUDAT = lt_VBAK-AUDAT.

SELECT VBEGDAT VENDDAT FROM veda INTO CORRESPONDING FIELDS OF TABLE lt_veda

WHERE VBELN = itab-CUSTOMER_NUMBER.

LOOP AT lt_veda.

itab-VBEGDAT = lt_veda-VBEGDAT.

itab-VENDDAT = lt_veda-VENDDAT.

ENDLOOP.

ENDLOOP.

*select * FROM vbak INTO CORRESPONDING FIELDS OF TABLE it_vbak

WHERE VBELN = itab-VBELN
and ERDAT = itab-invoice_date.

*LOOP AT it_vbak.

*itab-VBELN = it_vbak-VBELN.

itab-INVOICE_DATE = it_vbak-ERDAT.
APPEND itab.

*ENDLOOP.

else.

exit.

endif.

APPEND itab.

ENDLOOP.

call screen 9000.

&----

*& Module STATUS_9000 OUTPUT

&----

text

----

MODULE STATUS_9000 OUTPUT.

SET PF-STATUS 'MAIN MENU'.

SET TITLEBAR 'TITLE'.

CREATE OBJECT CONTAINER

EXPORTING

PARENT =

CONTAINER_NAME = 'CUS_CONTAINER'

STYLE =
LIFETIME = lifetime_default
REPID =
DYNNR =
NO_AUTODEF_PROGID_DYNNR =

EXCEPTIONS

CNTL_ERROR = 1

CNTL_SYSTEM_ERROR = 2

CREATE_ERROR = 3

LIFETIME_ERROR = 4

LIFETIME_DYNPRO_DYNPRO_LINK = 5

others = 6

IF SY-SUBRC <> 0.

*MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO

WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.

ENDIF.

CREATE OBJECT GRID

EXPORTING

I_SHELLSTYLE = 0
I_LIFETIME =

I_PARENT = CONTAINER

I_APPL_EVENTS = space
I_PARENTDBG =
I_APPLOGPARENT =
I_GRAPHICSPARENT =
I_NAME =
I_FCAT_COMPLETE = SPACE

EXCEPTIONS

ERROR_CNTL_CREATE = 1

ERROR_CNTL_INIT = 2

ERROR_CNTL_LINK = 3

ERROR_DP_CREATE = 4

others = 5

IF SY-SUBRC <> 0.

MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.

ENDIF.

CALL METHOD GRID->SET_TABLE_FOR_FIRST_DISPLAY

EXPORTING

I_BUFFER_ACTIVE =
I_BYPASSING_BUFFER =
I_CONSISTENCY_CHECK =

I_STRUCTURE_NAME = 'ZTARA_STRUC'

IS_VARIANT =
I_SAVE =
I_DEFAULT = 'X'
IS_LAYOUT =
IS_PRINT =
IT_SPECIAL_GROUPS =
IT_TOOLBAR_EXCLUDING =
IT_HYPERLINK =
IT_ALV_GRAPHICS =
IT_EXCEPT_QINFO =
IR_SALV_ADAPTER =

CHANGING

IT_OUTTAB = itab[]

IT_FIELDCATALOG = lt_fcat
IT_SORT =
IT_FILTER =

EXCEPTIONS

INVALID_PARAMETER_COMBINATION = 1

PROGRAM_ERROR = 2

TOO_MANY_LINES = 3

others = 4

IF SY-SUBRC <> 0.

MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.

ENDIF.

ENDMODULE. " STATUS_9000 OUTPUT

&----

*& Module USER_COMMAND_9000 INPUT

&----

text

----

MODULE USER_COMMAND_9000 INPUT.

case sy-ucomm.

when 'BACK'.

Leave Program.

when others.

Leave Program.

endcase.

ENDMODULE. " USER_COMMAND_9000 INPUT

Re: Urgent ..... check the program code,

Former Member — Tue, 11 Dec 2007 09:25:55 GMT

USE types DECLARATION LIKE THIS SEE THIS PROGRAM AND YOU CAN UNDERSTAND VERY EASILY

**************DATA TYPES DECLARATION **********************

TABLES: HRP1001, HRP1026, HRP1000,PCHDY.

TYPE-POOLS SLIS.

TYPES :BEGIN OF ST_OUTPUT,

COUNT TYPE STRING,

OBJID TYPE HRP1001-OBJID,

STEXT TYPE HRP1000-STEXT,

BEGDA TYPE HRP1000-BEGDA,

ENDDA TYPE HRP1000-ENDDA,

CANCRT TYPE T77CRT-CANCRT,

AEDTM TYPE HRP1026-AEDTM,

UNAME TYPE HRP1026-UNAME,

LSTEXT TYPE HRP1000-STEXT,

RINVT TYPE T777V-RINVT,

END OF ST_OUTPUT.

TYPES: BEGIN OF ST_HRP1000,

OBJID TYPE HRP1001-OBJID,

STEXT TYPE HRP1000-STEXT,

END OF ST_HRP1000.

TYPES : BEGIN OF ST_HRP1001,

OTYPE TYPE HRP1001-OTYPE,

OBJID TYPE HRP1001-OBJID,

RELAT type hrp1001-RELAT,

BEGDA TYPE HRP1001-BEGDA,

ENDDA TYPE HRP1001-ENDDA,

SCLAS TYPE HRP1001-SCLAS,

SOBID TYPE HRP1001-SOBID,

END OF ST_HRP1001.

TYPES : BEGIN OF ST_HRP1026,

OTYPE TYPE HRP1026-OTYPE,

OBJID TYPE HRP1001-OBJID,

AEDTM TYPE HRP1026-AEDTM,

UNAME TYPE HRP1026-UNAME,

DELET TYPE HRP1026-DELET,

CANCR TYPE HRP1026-CANCR,

END OF ST_HRP1026.

TYPES : BEGIN OF ST_REASON,

CANCR TYPE HRP1026-CANCR,

CANCRT TYPE T77CRT-CANCRT,

END OF ST_REASON.

TYPES : BEGIN OF ST_SOBID,

OTYPE TYPE HRP1001-OTYPE,

OBJID TYPE HRP1001-OBJID,

RELAT type hrp1001-OBJID,

BEGDA TYPE HRP1001-BEGDA,

ENDDA TYPE HRP1001-ENDDA,

SCLAS TYPE HRP1001-SCLAS,

SOBID TYPE HRP1001-OBJID,

END OF ST_SOBID.

TYPES : BEGIN OF ST_OBJID,

OBJID TYPE HRP1001-OBJID,

END OF ST_OBJID.

TYPES : BEGIN OF ST_LOCATION,

OTYPE TYPE HRP1001-OTYPE,

OBJID TYPE HRP1001-OBJID,

RSIGN TYPE HRP1001-RSIGN,

RELAT TYPE HRP1001-RELAT,

SCLAS TYPE HRP1001-SCLAS,

SOBID TYPE HRP1001-SOBID,

END OF ST_LOCATION.

TYPES : BEGIN OF ST_LOCATION1,

OTYPE TYPE HRP1001-OTYPE,

OBJID TYPE HRP1001-OBJID,

RSIGN TYPE HRP1001-RSIGN,

RELAT TYPE HRP1001-RELAT,

SCLAS TYPE HRP1001-SCLAS,

SOBID TYPE HRP1001-OBJID,

END OF ST_LOCATION1.

TYPES : BEGIN OF ST_LSTEXT,

OTYPE TYPE HRP1000-OTYPE,

OBJID TYPE HRP1000-OBJID,

LSTEXT TYPE HRP1000-STEXT,

END OF ST_LSTEXT.

TYPES : BEGIN OF ST_OBJID_SH,

OTYPE TYPE HRP1000-OTYPE,

OBJID TYPE HRP1000-OBJID,

END OF ST_OBJID_SH.

DATA : IT_OBJID_SH TYPE STANDARD TABLE OF ST_OBJID_SH.

DATA : WA_OBJID_SH TYPE ST_OBJID_SH.

DATA : IT_LSTEXT TYPE STANDARD TABLE OF ST_LSTEXT. "TOS STORE THE TEXT OF COURCE LOCATION

DATA : WA_LSTEXT TYPE ST_LSTEXT.

DATA : IT_LOCATION TYPE STANDARD TABLE OF ST_LOCATION. " TO STORE THE LOCATION OF COURCE

DATA : WA_LOCATION TYPE ST_LOCATION.

DATA : IT_LOCATION1 TYPE STANDARD TABLE OF ST_LOCATION1. " TO CONVERT SOBID INTO OBJID FOR COURCE LOCATION

DATA : WA_LOCATION1 TYPE ST_LOCATION1.

DATA : IT_SOBID TYPE STANDARD TABLE OF ST_SOBID. " TO CHANGE THE SOBID OF HRP1001 TO OBJID OF HRP1026

DATA : WA_SOBID TYPE ST_SOBID. " BY USING FOR ALL ENTRIES

DATA : IT_REASON TYPE STANDARD TABLE OF ST_REASON. "TO STORE T HE REASON FOR CANCELL TEXT

DATA : WA_REASON TYPE ST_REASON.

DATA : IT_OUTPUT TYPE STANDARD TABLE OF ST_OUTPUT. "OUTPUT FEILDS OF REPORT.

DATA : WA_OUTPUT TYPE ST_OUTPUT.

DATA : IT_OUTPUT_1 TYPE STANDARD TABLE OF ST_OUTPUT. " TEMP OUTPUT FEILDS OF REPORT.

DATA : WA_OUTPUT_1 TYPE ST_OUTPUT.

DATA : IT_HRP1000 TYPE STANDARD TABLE OF ST_HRP1000. "DATA FROM HRP1000 TABLE

DATA : WA_HRP1000 TYPE ST_HRP1000.

DATA : IT_HRP1001 TYPE STANDARD TABLE OF ST_HRP1001. "DATA FROM HRP1001 TABLE

DATA : WA_HRP1001 TYPE ST_HRP1001.

DATA : IT_HRP1026 TYPE STANDARD TABLE OF ST_HRP1026. "DATA FROM HRP1026 TABLE

DATA : WA_HRP1026 TYPE ST_HRP1026.

DATA : IT_OBJID TYPE STANDARD TABLE OF ST_OBJID. " TO STORE THE OBJID OF HRP1001

DATA : WA_OBJID TYPE ST_OBJID.

DATA: WS_FCAT TYPE SLIS_FIELDCAT_ALV . " FEILDCATALOG FOR ALV REPORT

DATA: IN_FCAT TYPE SLIS_T_FIELDCAT_ALV.

DATA: W_LAYOUT TYPE SLIS_LAYOUT_ALV.

DATA : LV_COUNT TYPE I. "FEILD FOR SERIAL NUMBER

***************************END OF DATA DECLARATION******************************************

***********SELECTION SCREEN DESIGN***********************

SELECTION-SCREEN BEGIN OF BLOCK B1 WITH FRAME TITLE TEXT-001.

*SELECT-OPTIONS : S_OTYPE FOR HRP1001-OTYPE NO INTERVALS .

SELECT-OPTIONS : S_OBJID FOR HRP1001-OBJID NO INTERVALS .

SELECT-OPTIONS : DATE FOR SY-DATUM NO-EXTENSION OBLIGATORY.

SELECTION-SCREEN END OF BLOCK B1.

**********END OF SELECTION SCREEN DESIGN*****************

*****INITIALIZATION VENT TO ASIGN DEFAULT VALUES TO OTYPE

*INITIALIZATION.

S_OTYPE-LOW = 'D'.
S_OTYPE-SIGN = 'I'.
S_OTYPE-OPTION = 'EQ'.
APPEND S_OTYPE.
CLEAR S_OTYPE.

*************END OF EVENT INITIALIZATION*****************

*********VALIDATION FOR SCREEN FIELDS********************

AT SELECTION-SCREEN ON VALUE-REQUEST FOR S_OBJID-LOW.

IF S_OBJID IS NOT INITIAL.

SELECT OTYPE OBJID FROM HRP1000

INTO TABLE IT_OBJID_SH

WHERE OTYPE = 'D'.

IF SY-SUBRC EQ 0.

SEARCH HELP FOR QUALIFICATION.

CALL FUNCTION 'F4IF_INT_TABLE_VALUE_REQUEST'

EXPORTING

DDIC_STRUCTURE = ' '

RETFIELD = 'OBJID'

PVALKEY = ' '

DYNPPROG = SY-REPID

DYNPNR = SY-DYNNR

DYNPROFIELD = 'S_OBJID'

STEPL = 0
WINDOW_TITLE =
VALUE = ' '

VALUE_ORG = 'S'

MULTIPLE_CHOICE = ' '
DISPLAY = ' '
CALLBACK_PROGRAM = ' '
CALLBACK_FORM = ' '
MARK_TAB =
IMPORTING
USER_RESET =

TABLES

VALUE_TAB = IT_OBJID_SH

FIELD_TAB =
RETURN_TAB = RETURN_TAB
DYNPFLD_MAPPING =
EXCEPTIONS
PARAMETER_ERROR = 1
NO_VALUES_FOUND = 2
OTHERS = 3

IF SY-SUBRC <> 0.

MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.

ENDIF.

IF SY-SUBRC NE 0.
MESSAGE 'NO RECORD FOUND FOR THE GIVEN SELECTION CRITERIA.' TYPE 'E'.
ENDIF.

ENDIF.
REFRESH IT_OBJID.

***************VALIDATION OF SCREEN FIELDS ENDS***********

*****************START OF SELECTION ************************

START-OF-SELECTION.

SELECT OTYPE

OBJID

RELAT

BEGDA

ENDDA

SCLAS

SOBID FROM HRP1001 INTO TABLE IT_HRP1001

WHERE OTYPE = 'D'

AND OBJID IN S_OBJID

AND BEGDA GE DATE-LOW

AND ENDDA LE DATE-HIGH

AND ( SCLAS = 'E' OR SCLAS = 'ET' ).

IF SY-SUBRC NE 0.

MESSAGE 'NO RECORD FOUND FOR THE GIVEN SELECTION CRITERIA ' TYPE 'E'.

ENDIF.

LOOP AT IT_HRP1001 INTO WA_HRP1001.

WA_SOBID-OTYPE = WA_HRP1001-OTYPE.

WA_SOBID-OBJID = WA_HRP1001-OBJID.

WA_SOBID-RELAT = WA_HRP1001-RELAT.

WA_SOBID-BEGDA = WA_HRP1001-BEGDA.

WA_SOBID-ENDDA = WA_HRP1001-ENDDA.

WA_SOBID-SCLAS = WA_HRP1001-SCLAS.

WA_SOBID-SOBID = WA_HRP1001-SOBID.

APPEND WA_SOBID TO IT_SOBID.

ENDLOOP.

SELECT OTYPE

OBJID

AEDTM

UNAME

DELET

CANCR

NCONT

FROM HRP1026

INTO TABLE IT_HRP1026

FOR ALL ENTRIES IN IT_SOBID

WHERE OBJID = IT_SOBID-SOBID

AND ( OTYPE = 'E' OR OTYPE = 'ET' )

AND DELET = 'X' AND

BEGDA GE DATE-LOW AND

ENDDA LE DATE-HIGH.

IF SY-SUBRC EQ 0.

SELECT OBJID

STEXT

FROM HRP1000

INTO TABLE IT_HRP1000

FOR ALL ENTRIES IN IT_SOBID

WHERE OBJID = IT_SOBID-SOBID AND

BEGDA GE DATE-LOW AND

ENDDA LE DATE-HIGH.

SELECT CANCR

CANCRT

FROM T77CRT

INTO TABLE IT_REASON

FOR ALL ENTRIES IN IT_HRP1026

WHERE CANCR = IT_HRP1026-CANCR

AND LANGU = 'E' .

********PERFORM FOR GETTING T HE LOCATION OF THE COURCE**

PERFORM GET_LOCATION.

**************END OF LOCATION OF COURCE ******************

ELSE.

MESSAGE 'NO RECORD FOUND FOR THE GIVEN SELECTION CRITERIA ' TYPE 'E'.

ENDIF.

*****PERFORM FOR GETTING DATA INTO THE FINAL INTERNAL TABLE IT_OUTPUT**

PERFORM GET_DATA.

*********************************END OF PERFORM ET DATA ***************

***********LOGIC FOR PRONTING NUMBER OF RECORDS ***********************

LV_COUNT = 0.

LOOP AT IT_OUTPUT INTO WA_OUTPUT.

LV_COUNT = LV_COUNT + 1.

WA_OUTPUT-COUNT = LV_COUNT.

APPEND WA_OUTPUT TO IT_OUTPUT_1.

ENDLOOP.

REFRESH IT_OUTPUT.

IT_OUTPUT = IT_OUTPUT_1.

********************END OF LOGIC FOR NUMBER OF RECORDS ***************

****************DISPLAYING OUTPUT BY USEING GRID DISPLAY**********

PERFORM ALV_DISPLAY.

****************************END OF PERFORM FOR DISPLAYING **********

&----

*& Form PERFORM_ALV

&----

DISPLAY THE RECORDS IN ALV GRID FORMAT.

----

FORM ALV_DISPLAY.

PERFORM FIELD_CATALOG USING 'COUNT' 'Sr. No.'.

PERFORM FIELD_CATALOG USING 'OBJID' 'COURCE ID.'.

PERFORM FIELD_CATALOG USING 'STEXT' 'COURCE NAME'.

PERFORM FIELD_CATALOG USING 'LSTEXT' 'COURCE LOATION'.

PERFORM FIELD_CATALOG USING 'BEGDA' 'BEGIN DATE '.

PERFORM FIELD_CATALOG USING 'ENDDA' 'END DATE '.

PERFORM FIELD_CATALOG USING 'CANCRT' 'REASON'.

PERFORM FIELD_CATALOG USING 'AEDTM' 'DATE Of CANCEL'.

PERFORM FIELD_CATALOG USING 'NCONT' 'NUMBER OF BOOKINGS'.
PERFORM FIELD_CATALOG USING 'LOCTX' 'COURCE LOCATION'.

PERFORM FIELD_CATALOG USING 'UNAME' 'WHO CANCELLED'.

PERFORM FIELD_CATALOG USING 'LSTEXT' 'COURCE LOATION'.

CALL FUNCTION 'REUSE_ALV_GRID_DISPLAY'

EXPORTING

I_STRUCTURE_NAME = 'IT_OUTPUT'

I_GRID_TITLE = ' Cancelled courses with reason '

IT_FIELDCAT = IN_FCAT

TABLES

T_OUTTAB = IT_OUTPUT.

IF SY-SUBRC <> 0.

MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.

ENDIF.

ENDFORM. "PERFORM_ALV

&----

*& Form FIELD_CATALOG

&----

text

----

-->FIELD_NAME text
-->DIS_TEXT text

----

FORM FIELD_CATALOG USING FIELD_NAME DIS_TEXT.

CLEAR WS_FCAT.

WS_FCAT-TABNAME = 'IT_OUTPUT'.

WS_FCAT-FIELDNAME = FIELD_NAME.

WS_FCAT-SELTEXT_M = DIS_TEXT.

APPEND WS_FCAT TO IN_FCAT .

ENDFORM. "FIELD_CATALOG

&----

*& Form GET_DATA

&----

text

----

--> p1 text
<-- p2 text

----

FORM GET_DATA .

*sort it_sobid by objid.

LOOP AT IT_SOBID INTO WA_SOBID." where otype eq s_otype and objid eq s_objid.

READ TABLE IT_HRP1026 WITH KEY OBJID = WA_SOBID-SOBID OTYPE = WA_SOBID-SCLAS INTO WA_HRP1026.

IF SY-SUBRC EQ 0.

READ TABLE IT_HRP1000 WITH KEY OBJID = WA_SOBID-SOBID INTO WA_HRP1000.

READ TABLE IT_REASON WITH KEY CANCR = WA_HRP1026-CANCR INTO WA_REASON.

WA_OUTPUT-OBJID = WA_HRP1026-OBJID.

WA_OUTPUT-BEGDA = WA_SOBID-BEGDA.

WA_OUTPUT-ENDDA = WA_SOBID-ENDDA.

WA_OUTPUT-AEDTM = WA_HRP1026-AEDTM.

WA_OUTPUT-UNAME = WA_HRP1026-UNAME.

WA_OUTPUT-NCONT = WA_HRP1026-NCONT.

READ TABLE IT_HRP1000 WITH KEY OBJID = WA_SOBID-SOBID INTO WA_HRP1000.

WA_OUTPUT-STEXT = WA_HRP1000-STEXT.

READ TABLE IT_REASON WITH KEY CANCR = WA_HRP1026-CANCR INTO WA_REASON.

WA_OUTPUT-CANCRT = WA_REASON-CANCRT.

CLEAR WA_REASON-CANCRT.

READ TABLE IT_LOCATION1 WITH KEY OBJID = WA_HRP1026-OBJID INTO WA_LOCATION1..

READ TABLE IT_LSTEXT WITH KEY OBJID = WA_LOCATION1-SOBID OTYPE = 'F' INTO WA_LSTEXT.

WA_OUTPUT-LSTEXT = WA_LSTEXT-LSTEXT.

CLEAR WA_LSTEXT-LSTEXT.

APPEND WA_OUTPUT TO IT_OUTPUT.

CLEAR WA_OUTPUT.

CLEAR WA_OUTPUT-CANCRT.

ENDIF.

ENDLOOP.

ENDFORM. " GET_DATA

&----

*& Form GET_LOCATION

&----

text

----

--> p1 text
<-- p2 text

----

FORM GET_LOCATION .

SELECT OTYPE

OBJID

RSIGN

RELAT

SCLAS

SOBID

FROM HRP1001

INTO TABLE IT_LOCATION

FOR ALL ENTRIES IN IT_HRP1026

WHERE OTYPE = 'E' AND OBJID = IT_HRP1026-OBJID

AND RSIGN = 'A' AND RELAT = '024' AND SCLAS = 'F'

AND BEGDA GE DATE-LOW AND ENDDA LE DATE-HIGH.

IF SY-SUBRC NE 0.

MESSAGE 'NO RECORD FOUND FOR THE GIVEN SELECTION CRITERIA ' TYPE 'E'.

ENDIF.

LOOP AT IT_LOCATION INTO WA_LOCATION.

WA_LOCATION1-OTYPE = WA_LOCATION-OTYPE.

WA_LOCATION1-OBJID = WA_LOCATION-OBJID.

WA_LOCATION1-RSIGN = WA_LOCATION-RSIGN.

WA_LOCATION1-RELAT = WA_LOCATION-RELAT.

WA_LOCATION1-SCLAS = WA_LOCATION-SCLAS.

WA_LOCATION1-SOBID = WA_LOCATION-SOBID.

APPEND WA_LOCATION1 TO IT_LOCATION1.

CLEAR WA_LOCATION1.

ENDLOOP.

SELECT OTYPE

OBJID

STEXT

FROM HRP1000

INTO TABLE IT_LSTEXT

FOR ALL ENTRIES IN IT_LOCATION1

WHERE OBJID = IT_LOCATION1-SOBID

AND OTYPE = 'F'.

AND BEGDA GE DATE-LOW
AND ENDDA LE DATE-HIGH.

ENDFORM. " GET_LOCATION

Re: Urgent ..... check the program code,

Former Member — Tue, 11 Dec 2007 09:29:54 GMT

Hi,

Your superior means, don't declare internal table as below

DATA : itab type STANDARD TABLE OF ZTARA_STRUC WITH HEADER LINE

Declare like this

Data: ITAB TYPE TABLE OF ZTARA_STRUC,

WA TYPE ZTARA_STRUC.

Avoid Into Corresponding fields of.

While doing loop.. endloop do like this

LOOP AT ITAB INTO WA.

Move data to WA.

APPEND WA TO ITAB.

CLEAR WA.

ENDLOOP.

Avoid Select Queries inside the loop, Keep them outside the loop and use For all entries.

Regards,

Satish

Re: Urgent ..... check the program code,

Former Member — Tue, 11 Dec 2007 09:38:30 GMT

Hi...

thanks for ur help,..

but even though iam getting some problem and error also

can you give me ur mail id , so i can send scrren shot and what all the required

inthe coding, and also check my coding aslo

Re: Urgent ..... check the program code,

Former Member — Tue, 11 Dec 2007 09:41:23 GMT

hi,

DATA : lt_vbrk type STANDARD TABLE OF vbrk WITH HEADER LINE,

lt_vbrp TYPE STANDARD TABLE OF vbap WITH HEADER LINE,

lt_VBAK TYPE STANDARD TABLE OF VBAK WITH HEADER LINE,

lt_veda TYPE STANDARD TABLE OF veda WITH HEADER LINE,

lt_kna1 TYPE STANDARD TABLE OF KNA1 WITH HEADER LINE,

it_vbak type standard table of vbak with header line.

Instead of the above declarations better go for this way,

types: begin of i_vbak.

include structure vbak.

types: end of i_vbak.

data: it_vbak type standard table of i_vbak.

data wa_vbak type i_vbak.

Reward if found usefull.

cheers,

Ram.

Re: Urgent ..... check the program code,

Former Member — Tue, 11 Dec 2007 09:44:58 GMT

And also avoind using select statement inside a loop,

Instead take the entire data into an internal table by using select quiry ( into table itab ) and perform READ on the internal table instead.

Cheers,

Ram.

Re: Urgent ..... check the program code,

Former Member — Tue, 11 Dec 2007 09:47:37 GMT

Paste the error here, which you are getting.

Regards,

Satish

Re: Urgent ..... check the program code,

Former Member — Tue, 11 Dec 2007 09:56:48 GMT

'' ITAB'' is the table without header line and therefore has no component called '' Customer_Number''. this is the error

this is my mail id can u once check the coding , if possible make correction and send it to my mail id. It, would be very helpfull 2 me raghuraj.raj@gmail.com

Re: Urgent ..... check the program code,

Former Member — Tue, 11 Dec 2007 10:13:16 GMT

Hi,

Have you declared the ITAB as i told you above?

Then don't move values directly into ITAB, First move into Work Area and then append to ITAB from WA.

Regards,

Satish

Re: Urgent ..... check the program code,

Former Member — Tue, 11 Dec 2007 10:34:17 GMT

even...i did like that also....

hey..its better.... just correct my code and send it back naa

Re: Urgent ..... check the program code,

Former Member — Tue, 11 Dec 2007 10:52:43 GMT

I request to check my code, correct it and send me back complete code..........

Re: Urgent ..... check the program code,

Former Member — Tue, 11 Dec 2007 10:58:06 GMT

Sorry dear no one is here to do your work .. we are here to help not to complete your work,..

regarding urr error .. it seems you are using internal table as a work area ..

or you are not mention 'into table' in select qurery

go tru debugger and check the exact line in which u r getting error and check for able mistakes..