topic Re: rollback multiple transaction in Application Development and Automation Discussions

rollback multiple transaction

Former Member — Mon, 26 Nov 2007 01:26:22 GMT

Hello Experts:

Got a quick question needs fast answer..

I am doing a sales order create and then turn into invoice. two function handle it.

BAPI_SALESORDER_CREATEFROMDATA for sales order and BAPI_BILLINGDOC_CREATEMULTIPLE to turn it into invoice. Sales order fail, that's fine. But if invoice failed. I want the sales order to roll back as well. Is there a start transaction ... then end with roll back or commit kind of thing in ABAP? Appreciate any hint at all.! !!!!

Sincerely Yours

Bo Peng

Re: rollback multiple transaction

Sougata — Mon, 26 Nov 2007 01:56:36 GMT

Hello Bo,

try like this: (see pseudo code below)

Loop at Sales Docs.   "For every sales document
 CALL FUNCTION BAPI_SALESORDER_CREATEFROMDATA .....

  If success.   "sales order was created but not yet written to database
    CALL FUNCTION BAPI_BILLINGDOC_CREATEMULTIPLE .....
      If success.   "invoice was created but not yet written to database
       Commit Work.     "or use FM BAPI_TRANSACTION_COMMIT
      else.           "failed to create invoice
           Rollback Work.
      endif.
  Endif.
Endloop.

<b>Don't forget to reward points please.</b>

Cheers,

Sougata.

Re: rollback multiple transaction

Former Member — Mon, 26 Nov 2007 03:00:26 GMT

Hello Sougata:

Yes. this is what I have tried as well. However I think there is a commit build in BAPI_Salesorder_createfromdata. I have the exact same structure. As you did... I even tried using BAPI_TRANSACTION_ROLLBACK. But the sales order is still created. Any ideas? Should I try reverse the sales order in that case then? How to reverse sales order?

Sincerely

Re: rollback multiple transaction

Sougata — Mon, 26 Nov 2007 03:11:55 GMT

Hi Bo,

Another idea...

Instead of creating the sales orders/invoices, try to simulate them first using BAPI_SALESORDER_SIMULATE and BAPI_BILLINGDOC_SIMULATE. Then check if everything OK.

If OK go ahead with the actual create/post.

If not OK, delete the lines of the internal table in error and write as exception report, then go ahead with the rest of the internal table which now has only "Good" ones.

What do you think?

or instead of using SIMULATE you can use the same BAPIs with TESTRUN = 'X', then check the RETURN.

Message was edited by:

Sougata Chatterjee

Re: rollback multiple transaction

Former Member — Mon, 26 Nov 2007 03:50:18 GMT

Hello Sougata:

I thought of that as well. The problem is I am creating billing document base on existing sales order.

Option 1. using BAPI_SALESORDER_SIMULATE and BAPI_BILLINGDOC_SIMULATE. Then check if everything OK.

If sales order doesn't actually get created then billing document doesn't have a reference to create from. Or does it? I assume when using salesorder_simulate. It doesn't actually create the sales order just trying to create then roll back. So I need something that will actually create, but still easily to roll back to.

Option 2. TESTRUN = 'X', then check the RETURN.

BAPI_SALESORDER_CREATEFROMDATA doesn't have a testrun.

I thought there might be a standard way of doing this, since this got to be a pretty usual problem...

I appreciate your help very much. And I am gonna keep on trying to see what works. I was actually thinking about reverse sales order if billing document does get created successfully Don't know if that's a proper thing to do or not!

Sincerely Yours

Re: rollback multiple transaction

Sougata — Mon, 26 Nov 2007 04:23:07 GMT

Hi Bo,

Not sure which release you are on but you should be using BAPI_SALESORDER_CREATEFROMDAT2 to create sales orders and indeed it has a import parameter named TESTRUN.

Please note BAPI_SALESORDER_CREATEFROMDATA is obsolete as of release 4.0A so avoid using it if you are >= release 4.0A.

As I understand, your objective is to create the Invoices if Sales Order creation is successful. That's the reason I asked you to use TESTRUN = 'X' or SIMULATE...

It will not create the Sales Order but this way you can eliminate the "bad" orders from your internal table i.e. for the ones you don't want to create the Invoices.

After you delete all the "bad" (error) lines in your main sales order itab you'll be left with "good" ones. Now if you loop at sales order itab and call the BAPI_SALESORDER_CREATEFROMDAT2 with TESTRUN = space you'll actually create the sales orders in the database without fail. So in the same loop you can create the Invoices as well now that you know sales order creation will not fail for sure...so no rollback is required, just commit work after all sales orders and invoices are finished creating. <b>Before deleting the error lines of your sales order internal table, append it to another internal table say error_tab</b>..then once you are finished with creating all sales orders/invoices, handle the error_tab as per your requirement i.e. print/email/display as error log etc. with error message e.g. "Sales Order/Invoices cannot be created with the following data" etc.

Hope you get my point.

I don't see any points yet and already I've spent more than 30 mins for you out of my busy schedule!!

Message was edited by:

Sougata Chatterjee

Message was edited by:

Sougata Chatterjee

Re: rollback multiple transaction

Former Member — Mon, 26 Nov 2007 05:28:34 GMT

@Sougata - I've modified your code to add another rollback. I haven't tested it, so I don't know if it will help.

Loop at Sales Docs.   "For every sales document
 CALL FUNCTION BAPI_SALESORDER_CREATEFROMDATA .....
 
  If success.   "sales order was created but not yet written to database
    CALL FUNCTION BAPI_BILLINGDOC_CREATEMULTIPLE .....
      If success.   "invoice was created but not yet written to database
       Commit Work.     "or use FM BAPI_TRANSACTION_COMMIT
      else.           "failed to create invoice
           Rollback Work.
      endif.
      else.
            ROLLBACK.             "<========
  Endif.
Endloop.

Re: rollback multiple transaction

Sougata — Mon, 26 Nov 2007 05:49:53 GMT

Thanks Rob, I overlooked that part.

Bo,

The logic as per my first post (now with Rob's correction) should work fine. I don't see how it would not work for your requirement. In the loop instead of calling the old BAPI call the new BAPI_SALESORDER_CREATEFROMDAT2.

Cheers,

Sougata.

I reckon its not working because Bo is not rewarding us points! What do you say Rob?

Message was edited by:

Sougata Chatterjee