topic Re: binary search problem in Application Development and Automation Discussions

binary search problem

Former Member — Mon, 05 Sep 2005 10:07:35 GMT

a binary search see below is returning a sy-subrc code of 8 and not finding the record as i expect. anyone know why?

in debug i can see the entry in the internal table. it just doesn't find it using the binary search. the values are correct in the select statement and i don't think there is a problem with formatting. there are approx 700,000 entries in the table. the dis_ch (result) field is empty and should be populated with the bussct field.

internal table declaration

TYPES: BEGIN OF s_custsa,

salorg type /BIC/PIO_CUSTSA-/BIC/IO_SALORG,

dis_ch type /BIC/PIO_CUSTSA-/BIC/IO_DIS_CH,

divs type /BIC/PIO_CUSTSA-/BIC/IO_DIVS,

custsa type /BIC/PIO_CUSTSA-/BIC/IO_CUSTSA,

bussct type /BIC/PIO_CUSTSA-/BIC/IO_BUSSCT,

END OF s_custsa.

DATA: it_pio_custsa TYPE STANDARD TABLE OF s_custsa with header line

WITH NON-UNIQUE DEFAULT KEY INITIAL SIZE 10.

filling the internal table with all active records.

SELECT /BIC/IO_SALORG /BIC/IO_DIS_CH /BIC/IO_DIVS /BIC/IO_CUSTSA

/BIC/IO_BUSSCT

FROM /BIC/PIO_CUSTSA

INTO table it_pio_custsa

WHERE OBJVERS = 'A'.

delete it_pio_custsa where bussct = ''.

sort it_pio_custsa by custsa salorg divs.

now try to find the entry

read table it_pio_custsa with key

SALORG = COMM_STRUCTURE-/BIC/IO_SALORG

DIVS = COMM_STRUCTURE-/BIC/IO_DIVS

CUSTSA = COMM_STRUCTURE-/BIC/IO_CUSTSA binary search.

if sy-subrc = 0.

RESULT = it_pio_custsa-bussct.

endif.

Re: binary search problem

Former Member — Mon, 05 Sep 2005 10:14:12 GMT

read internal table as

read table it_pio_custsa with key

CUSTSA = COMM_STRUCTURE-/BIC/IO_CUSTSA

SALORG = COMM_STRUCTURE-/BIC/IO_SALORG

DIVS = COMM_STRUCTURE-/BIC/IO_DIVS

binary search.

if sy-subrc = 0.

RESULT = it_pio_custsa-bussct.

endif.

order should be same as in sort.

did you got it

regards

Re: binary search problem

Vinod_Chandran — Mon, 05 Sep 2005 10:18:08 GMT

Hi,

Not sure whether this will work. But worth trying...

The order of fields given in SORT and READ TABLE is different.

sort it_pio_custsa by custsa salorg divs.

read table it_pio_custsa with key

CUSTSA = COMM_STRUCTURE-/BIC/IO_CUSTSA

SALORG = COMM_STRUCTURE-/BIC/IO_SALORG

DIVS = COMM_STRUCTURE-/BIC/IO_DIVS

binary search.

if sy-subrc = 0.

RESULT = it_pio_custsa-bussct.

endif.

Thanks

Vinod

Re: binary search problem

Former Member — Mon, 05 Sep 2005 10:20:57 GMT

Hi,

If u want to retain the read statement as it is,

then sort the table by -

sort it_pio_custsa by salorg divs custa.

rather than -

sort it_pio_custsa by custsa salorg divs.

it makes sense to change the sort sequence because data type for internal table is defined in the same order.

Re: binary search problem

Former Member — Mon, 05 Sep 2005 10:44:56 GMT

thanks all for your comments. what i find strange is that out of a sample debug of 140 records only 3 fail to be found using the original code. why would this be the case?

i will amend the code as suggested keeping the internal table and read formats as they correspond to the master data table that is being read from. and just change the sort sequence.

i'll award some points tomorrow if it works!!

Re: binary search problem

Former Member — Mon, 05 Sep 2005 13:51:16 GMT

do the sorting as per in the read statement

sort it_pio_custsa by custsa salorg divs

instead of the above statement change it like

sort it_pio_custsa by salorg divs custsa.

Cheers,

Sasi