topic Re: Efficiency in Application Development and Automation Discussions

Efficiency

Former Member — Fri, 19 Oct 2007 06:21:23 GMT

Hi,

I have a code

LOOP AT I_VBRK_VBRP.

move sy-TABIX to vbrk_vbrp_indx.

move-corresponding i_vbrk_vbrp to w_vbrk_vbrp.

READ TABLE I_KONV WITH KEY KNUMV = I_VBRK_VBRP-KNUMV

KPOSN = I_VBRK_VBRP-POSNR

BINARY SEARCH.

IF SY-SUBRC NE 0.

DELETE I_VBRK_VBRP.

ELSE.

LOOP AT I_KONV WHERE KNUMV = I_VBRK_VBRP-KNUMV

AND KPOSN = I_VBRK_VBRP-POSNR.

IF I_VBRK_VBRP-KSCHL IS INITIAL

OR NOT RB_AG5 IS INITIAL.

MOVE I_KONV-KSCHL TO I_VBRK_VBRP-KSCHL.

MODIFY I_VBRK_VBRP index vbrk_vbrp_indx.

ELSE.

MOVE I_KONV-KSCHL TO W_VBRK_VBRP-KSCHL.

APPEND W_VBRK_VBRP.

CLEAR W_VBRK_VBRP.

ENDIF.

ENDLOOP.

ENDIF.

ENDLOOP.

I want to merge the read operation in the second loop to make the operation more efficint.

Can anybody suggest me how to do?(without changing the output)

Re: Efficiency

former_member404244 — Fri, 19 Oct 2007 06:29:45 GMT

Hi,

Instead of second loop try like this

read table I_KONV WHERE KNUMV = I_VBRK_VBRP-KNUMV

AND KPOSN = I_VBRK_VBRP-POSNR.

if sy-subrc eq 0.

IF I_VBRK_VBRP-KSCHL IS INITIAL

OR NOT RB_AG5 IS INITIAL.

MOVE I_KONV-KSCHL TO I_VBRK_VBRP-KSCHL.

MODIFY I_VBRK_VBRP index vbrk_vbrp_indx.

ELSE.

MOVE I_KONV-KSCHL TO W_VBRK_VBRP-KSCHL.

APPEND W_VBRK_VBRP.

CLEAR W_VBRK_VBRP.

ENDIF.

endif.

Reward if helpful.

reagrds,

Nagaraj

Re: Efficiency

Former Member — Fri, 19 Oct 2007 06:36:27 GMT

hi,

use like this.

read table I_KONV into <w_area> with key KNUMV = I_VBRK_VBRP-KNUMV

KPOSN = I_VBRK_VBRP-POSNR.

binary search.

if sy-subrc eq 0.

IF I_VBRK_VBRP-KSCHL IS INITIAL

OR NOT RB_AG5 IS INITIAL.

MOVE I_KONV-KSCHL TO I_VBRK_VBRP-KSCHL.

MODIFY I_VBRK_VBRP index vbrk_vbrp_indx.

ELSE.

MOVE I_KONV-KSCHL TO W_VBRK_VBRP-KSCHL.

APPEND W_VBRK_VBRP.

CLEAR W_VBRK_VBRP.

ENDIF.

endif.

<b><i>Reward points if useful</i></b>

Chandra

Re: Efficiency

Former Member — Fri, 19 Oct 2007 06:52:00 GMT

Instead of removing the second loop, is there any way to remove the read option?

keeping the output same.

Re: Efficiency

Former Member — Fri, 19 Oct 2007 06:58:35 GMT

LOOP AT I_KONV WHERE KNUMV = I_VBRK_VBRP-KNUMV

in this code declare the internal table as SORTED TABLE instaed of standard table , this will improve performance

Re: Efficiency

former_member404244 — Fri, 19 Oct 2007 07:00:51 GMT

Hi,

try like this

LOOP AT I_VBRK_VBRP.

move sy-TABIX to vbrk_vbrp_indx.

move-corresponding i_vbrk_vbrp to w_vbrk_vbrp.

LOOP AT I_KONV WHERE KNUMV = I_VBRK_VBRP-KNUMV

AND KPOSN = I_VBRK_VBRP-POSNR.

IF I_VBRK_VBRP-KSCHL IS INITIAL

OR NOT RB_AG5 IS INITIAL.

MOVE I_KONV-KSCHL TO I_VBRK_VBRP-KSCHL.

MODIFY I_VBRK_VBRP index vbrk_vbrp_indx.

ELSE.

MOVE I_KONV-KSCHL TO W_VBRK_VBRP-KSCHL.

APPEND W_VBRK_VBRP.

CLEAR W_VBRK_VBRP.

ENDIF.

ENDLOOP.

ENDIF.

ENDLOOP.

Regards,

NAGARAJ