topic Re: loop inside loop in Application Development and Automation Discussions

loop inside loop

Former Member — Mon, 01 Oct 2007 06:41:38 GMT

Hi Experts

I am using nested loops

but as it is not good practice

please send me alternative for this......

LOOP AT IT_VBAK INTO WA_VBAK.

READ TABLE IT_VBAP INTO WA_VBAP WITH KEY VBELN = WA_VBAK-VBELN.

READ TABLE IT_KNA1 INTO WA_KNA1 WITH KEY KUNNR = WA_VBAK-KUNNR.

SORT IT_VBKD BY VBELN POSNR.

SORT IT_VEDA BY VBELN .

LOOP AT IT_VBAP INTO WA_VBAP .

READ TABLE IT_VBKD INTO WA_VBKD WITH KEY VBELN = WA_VBAP-VBELN POSNR =

WA_VBAP-POSNR.

READ TABLE IT_VEDA INTO WA_VEDA WITH KEY VBELN = WA_VEDA-VBELN.

MOVE-CORRESPONDING WA_VBKD TO WA_DISPLAY.

MOVE-CORRESPONDING WA_VEDA TO WA_DISPLAY.

ENDLOOP.

MOVE-CORRESPONDING WA_VBAK TO WA_DISPLAY.

MOVE-CORRESPONDING WA_VBAP TO WA_DISPLAY.

MOVE-CORRESPONDING WA_KNA1 TO WA_DISPLAY.

APPEND WA_DISPLAY TO IT_DISPLAY

Re: loop inside loop

Former Member — Mon, 01 Oct 2007 06:45:31 GMT

For Line item data, you should use Loop inside Loop.

Few changes were required in your code. Changes are marked in Bold.

SORT IT_VBKD BY VBELN POSNR.

SORT IT_VEDA BY VBELN .

SORT IT_VBAP BY VBELN.

SORT IT_KNA1 by KUNNR.

LOOP AT IT_VBAK INTO WA_VBAK.

READ TABLE IT_VBAP INTO WA_VBAP WITH KEY VBELN = WA_VBAK-VBELN BINARY SEARCH.

READ TABLE IT_KNA1 INTO WA_KNA1 WITH KEY KUNNR = WA_VBAK-KUNNR BINARY SEARCH.

* SORT IT_VBKD BY VBELN POSNR.

SORT IT_VEDA BY VBELN .

LOOP AT IT_VBAP INTO WA_VBAP WHERE VBELN = WA_VBAK-VEBLN .

READ TABLE IT_VBKD INTO WA_VBKD WITH KEY VBELN = WA_VBAP-VBELN POSNR =

WA_VBAP-POSNR BINARY SEARCH.

READ TABLE IT_VEDA INTO WA_VEDA WITH KEY VBELN = WA_VEDA-VBELN BINARY SEARCH.

MOVE-CORRESPONDING WA_VBKD TO WA_DISPLAY.

MOVE-CORRESPONDING WA_VEDA TO WA_DISPLAY.

ENDLOOP.

MOVE-CORRESPONDING WA_VBAK TO WA_DISPLAY.

MOVE-CORRESPONDING WA_VBAP TO WA_DISPLAY.

MOVE-CORRESPONDING WA_KNA1 TO WA_DISPLAY.

APPEND WA_DISPLAY TO IT_DISPLAY

Re: loop inside loop

Former Member — Mon, 01 Oct 2007 06:47:17 GMT

Hi Ameet,

I think your logic is not correct. VBAP is item structure so you need to use LOOP here but you are not handling it correctly in the output table.

LOOP AT IT_VBAK INTO WA_VBAK.

READ TABLE IT_KNA1 INTO WA_KNA1 WITH KEY KUNNR = WA_VBAK-KUNNR.

SORT IT_VBKD BY VBELN POSNR.

SORT IT_VEDA BY VBELN .

MOVE-CORRESPONDING WA_VBAK TO WA_DISPLAY.

MOVE-CORRESPONDING WA_KNA1 TO WA_DISPLAY.

LOOP AT IT_VBAP INTO WA_VBAP .

READ TABLE IT_VBKD INTO WA_VBKD WITH KEY VBELN = WA_VBAP-VBELN POSNR =

WA_VBAP-POSNR.

READ TABLE IT_VEDA INTO WA_VEDA WITH KEY VBELN = WA_VEDA-VBELN.

MOVE-CORRESPONDING WA_VBKD TO WA_DISPLAY.

MOVE-CORRESPONDING WA_VEDA TO WA_DISPLAY.

MOVE-CORRESPONDING WA_VBAP TO WA_DISPLAY.

APPEND WA_DISPLAY TO IT_DISPLAY

ENDLOOP.

Regards,

Atish

Re: loop inside loop

Former Member — Mon, 01 Oct 2007 06:54:28 GMT

atish

i dint get you will you please explain more

Re: loop inside loop

varma_narayana — Mon, 01 Oct 2007 07:02:25 GMT

hi Ameet..

Check this code.. It should work for u..

**Since the internal tables are sorted we can use BINARY SEARCH to improve the **performance

SORT IT_VBKD BY VBELN POSNR.

SORT IT_VEDA BY VBELN .

SORT IT_VBAK BY VBELN.

SORT IT_VBAP BY VBELN.

SORT IT_KNA1 BY KUNNR.

LOOP AT IT_VBAP INTO WA_VBAP .

MOVE-CORRESPONDING WA_VBAP TO WA_DISPLAY.

READ TABLE IT_VBAK INTO WA_VBAK

WITH KEY VBELN = WA_VBAK-VBELN

BINARY SEARCH.

IF SY-SUBRC = 0.

MOVE-CORRESPONDING WA_VBAK TO WA_DISPLAY.

READ TABLE IT_KNA1 INTO WA_KNA1 WITH KEY KUNNR = WA_VBAK-KUNNR.

IF SY-SUBRC = 0.

MOVE-CORRESPONDING WA_KNA1 TO WA_DISPLAY.

ENDIF.

READ TABLE IT_VBKD INTO WA_VBKD

WITH KEY VBELN = WA_VBAP-VBELN POSNR = WA_VBAP-POSNR

BINARY SEACH.

IF SY-SUBRC = 0.

MOVE-CORRESPONDING WA_VBKD TO WA_DISPLAY.

ENDIF.

READ TABLE IT_VEDA INTO WA_VEDA

WITH KEY VBELN = WA_VEDA-VBELN

BINARY SEARCH.

IF SY-SUBRC = 0.

MOVE-CORRESPONDING WA_VEDA TO WA_DISPLAY.

ENDIF.

APPEND WA_DISPLAY TO IT_DISPLAY

ENDLOOP.

Reward if Helpful.

Re: loop inside loop

Former Member — Mon, 01 Oct 2007 07:04:32 GMT

Hi Ameet,

Use parallel cursor method for this. It will be best in terms of performance. As per performance point of view it is not good to sort the tables inside the loop.

One more thing is VBAP is an item table and may contain many records for single VBELN in VBAK. so, we have to loop on that table.

Try using the below code.

Data : lw_index type sy-tabix.

SORT IT_VBKD BY VBELN POSNR.

SORT IT_VEDA BY VBELN .

SORT IT_VBAP BY VBELN.

SORT IT_VBAK BY VBELN.

SORT IT_KNA1 by KUNNR.

lw_index = 1.

LOOP AT IT_VBAK INTO WA_VBAK.

READ TABLE IT_KNA1 INTO WA_KNA1 WITH KEY KUNNR = WA_VBAK-KUNNR.

LOOP AT IT_VBAP INTO WA_VBAP from index lw_index.

If wa_vbap-vbeln GT wa_vbak-vbeln.

lw_index = sy-tabix.

exit.

elseif wa_vbap-vbeln EQ wa_vbak-vbeln.

READ TABLE IT_VBKD INTO WA_VBKD WITH KEY VBELN = WA_VBAP-VBELN POSNR =

WA_VBAP-POSNR binary search.

READ TABLE IT_VEDA INTO WA_VEDA WITH KEY VBELN = WA_VEDA-VBELN binary search.

MOVE-CORRESPONDING WA_VBKD TO WA_DISPLAY.

MOVE-CORRESPONDING WA_VEDA TO WA_DISPLAY.

endif.

ENDLOOP.

MOVE-CORRESPONDING WA_VBAK TO WA_DISPLAY.

MOVE-CORRESPONDING WA_VBAP TO WA_DISPLAY.

MOVE-CORRESPONDING WA_KNA1 TO WA_DISPLAY.

APPEND WA_DISPLAY TO IT_DISPLAY

ENDLOOP.

Hope this will help you.

Re: loop inside loop

varma_narayana — Mon, 01 Oct 2007 07:04:40 GMT

Hi Ameet ..

Some corrections from my Prev post.

Try this:

hi Ameet..

Check this code.. It should work for u..

**Since the internal tables are sorted we can use BINARY SEARCH to improve the **performance

SORT IT_VBKD BY VBELN POSNR.

SORT IT_VEDA BY VBELN .

SORT IT_VBAK BY VBELN.

SORT IT_VBAP BY VBELN.

SORT IT_KNA1 BY KUNNR.

LOOP AT IT_VBAP INTO WA_VBAP .

MOVE-CORRESPONDING WA_VBAP TO WA_DISPLAY.

READ TABLE IT_VBAK INTO WA_VBAK

WITH KEY VBELN = WA_VBAP-VBELN

BINARY SEARCH.

IF SY-SUBRC = 0.

MOVE-CORRESPONDING WA_VBAK TO WA_DISPLAY.

READ TABLE IT_KNA1 INTO WA_KNA1

WITH KEY KUNNR = WA_VBAK-KUNNR.

IF SY-SUBRC = 0.

MOVE-CORRESPONDING WA_KNA1 TO WA_DISPLAY.

ENDIF.

READ TABLE IT_VBKD INTO WA_VBKD

WITH KEY VBELN = WA_VBAP-VBELN POSNR = WA_VBAP-POSNR

BINARY SEACH.

IF SY-SUBRC = 0.

MOVE-CORRESPONDING WA_VBKD TO WA_DISPLAY.

ENDIF.

READ TABLE IT_VEDA INTO WA_VEDA

WITH KEY VBELN = WA_vbap-VBELN

BINARY SEARCH.

IF SY-SUBRC = 0.

MOVE-CORRESPONDING WA_VEDA TO WA_DISPLAY.

ENDIF.

APPEND WA_DISPLAY TO IT_DISPLAY

ENDLOOP.

Re: loop inside loop

Former Member — Mon, 01 Oct 2007 07:08:55 GMT

i want reward points to u how sld i do this?

Re: loop inside loop

Former Member — Mon, 01 Oct 2007 07:14:37 GMT

use 'for all entries'.

Redesign your logic..

Re: loop inside loop

Former Member — Mon, 01 Oct 2007 07:27:01 GMT

Hi Ameet,

As you have not posted the thread as a question I think you cant reward points for this thread.

I hope your problem is resolved.

In future post threads as questions.