topic Re: Is it correct code? in Application Development and Automation Discussions

Is it correct code?

Former Member — Wed, 29 Aug 2007 11:45:31 GMT

Is the correct code for the below requirement.

1.Check if operating concern(I_ERKRS) is 0001 than go to step 2 else go to step

2.Read each record of T_Item which is of structure CE10001 table and verify

the value for item category(CE10001-PSTYV) .

3. If the item Category (CE10001-PSTYV) is TAS Than change Warehouse cost value field (CE10001-VV504) value to 0.00 irrespective of its current value).

Else don’t change value of warehouse cost value field(CE10001-VV504).

4.Exit from the function module.

Code:

CASE i_erkrs.

WHEN '0001'.

LOOP AT t_item.

MOVE-CORRESPONDING t_item TO ce1_0001.

IF ce1_0001-pstyv = 'TAS'.

ce1_0001-vv504 = '0.00'.

ELSE.

ENDIF.

MOVE-CORRESPONDING ce1_0001 TO t_item.

MODIFY t_item FROM t_item.

ENDLOOP.

EXIT.

ENDCASE.

Thanks,

sudhakar

Re: Is it correct code?

former_member188827 — Wed, 29 Aug 2007 11:48:09 GMT

use endif before modify.

only den it makes sense.

CASE i_erkrs.

WHEN '0001'.

LOOP AT t_item.

MOVE-CORRESPONDING t_item TO ce1_0001.

IF ce1_0001-pstyv = 'TAS'.

ce1_0001-vv504 = '0.00'.

ELSE.

MOVE-CORRESPONDING ce1_0001 TO t_item.

ENDIF.

MODIFY t_item FROM t_item.

ENDLOOP.

EXIT.

ENDCASE

Re: Is it correct code?

former_member188827 — Wed, 29 Aug 2007 11:51:11 GMT

also i dont c ny need for da exit statement as well...

plz reward points if it helps

Re: Is it correct code?

Former Member — Wed, 29 Aug 2007 11:52:11 GMT

yes u r right.

u can write simply like this.

CASE i_erkrs.

WHEN '0001'.

LOOP AT t_item.

MOVE-CORRESPONDING t_item TO ce1_0001.

IF ce1_0001-pstyv = 'TAS'.

ce1_0001-vv504 = '0.00'.

ENDIF.

MOVE-CORRESPONDING ce1_0001 TO t_item.

MODIFY t_item.

ENDLOOP.

EXIT.

ENDCASE.

(Or)

CASE i_erkrs.

WHEN '0001'.

LOOP AT t_item.

IF t_item-pstyv = 'TAS'.

t_item-vv504 = '0.00'.

ENDIF.

MODIFY t_item.

ENDLOOP.

EXIT.

ENDCASE.

rgds,

bharat.

Re: Is it correct code?

Former Member — Wed, 29 Aug 2007 11:57:01 GMT

SEE THIS CODE:

CASE i_erkrs.

WHEN '0001'.

LOOP AT t_item.

MOVE-CORRESPONDING t_item TO ce1_0001.

IF ce1_0001-pstyv = 'TAS'.

ce1_0001-vv504 = '0.00'.

ELSE.

CONTINUE.

ENDIF.

MOVE-CORRESPONDING ce1_0001 TO t_item.

MODIFY t_item FROM t_item.

ENDLOOP.

EXIT.

ENDCASE.

regards,

srinivas

*reward for useful answers*

Re: Is it correct code?

Former Member — Wed, 29 Aug 2007 12:14:16 GMT

Thanks for replying.