topic Re: Time consuming in Loop ... in Application Development and Automation Discussions

Time consuming in Loop ...

Former Member — Mon, 02 Jul 2007 12:35:44 GMT

Hi Experts,

Pl. have a look in the below program and explain why it takes long time in loop.

START-OF-SELECTION.

select * from mara client specified

into corresponding fields of table itab

where mandt = sy-mandt and matnr in matnr1

and matkl in ptype and mtart = 'ZFIN'.

sort itab by matnr.

select * from makt into corresponding fields of table it_makt

for all entries in itab where matnr = itab-matnr.

sort it_makt by matnr.

select * from a304 client specified

into corresponding fields of table it_a304

where mandt = sy-mandt and kschl = 'PR00'.

sort it_a304 by matnr.

select * from konp client specified

into corresponding fields of table it_konp

where mandt = sy-mandt and KSCHL = 'PR00'.

sort it_konp by knumh.

loop at itab.

it_out-matnr = itab-matnr.

it_out-matkl = itab-matkl.

read table it_makt with key matnr = itab-matnr.

it_out-maktx = it_makt-maktx.

read table it_a304 with key matnr = itab-matnr.

it_out-kschl = it_a304-kschl.

it_out-vkorg = it_a304-vkorg.

it_out-vtweg = it_a304-vtweg.

it_out-knumh = it_a304-knumh.

read table it_konp with key knumh = it_a304-knumh.

it_out-kbetr = it_konp-kbetr.

IF IT_OUT-KBETR <= '5.00'.

IT_OUT-FACTOR = IT_OUT-KBETR.

ELSE.

IT_OUT-FACTOR = ( IT_OUT-KBETR ) * '0.55'.

ENDIF.

APPEND IT_out.

endloop.

Re: Time consuming in Loop ...

Former Member — Mon, 02 Jul 2007 12:42:56 GMT

**using binary search in READ statement makes it very fast, but shud be sorted

sort it_makt by matnr.

sort it_a304 by matnr.

sort it_konp by knumh.

loop at itab.

it_out-matnr = itab-matnr.

it_out-matkl = itab-matkl.

read table it_makt with key matnr = itab-matnr bimary search.

it_out-maktx = it_makt-maktx.

read table it_a304 with key matnr = itab-matnr binary search.

it_out-kschl = it_a304-kschl.

it_out-vkorg = it_a304-vkorg.

it_out-vtweg = it_a304-vtweg.

it_out-knumh = it_a304-knumh.

read table it_konp with key knumh = it_a304-knumh binary search.

it_out-kbetr = it_konp-kbetr.

IF IT_OUT-KBETR <= '5.00'.

IT_OUT-FACTOR = IT_OUT-KBETR.

ELSE.

IT_OUT-FACTOR = ( IT_OUT-KBETR ) * '0.55'.

ENDIF.

APPEND IT_out.

endloop.

Re: Time consuming in Loop ...

Former Member — Mon, 02 Jul 2007 12:43:14 GMT

also use BINARY SEARCH option

loop at itab.

it_out-matnr = itab-matnr.

it_out-matkl = itab-matkl.

read table it_makt with key matnr = itab-matnr BINARY SEARCH .

if sy-subrc eq 0.

it_out-maktx = it_makt-maktx.

endif.

read table it_a304 with key matnr = itab-matnr BINARY SEARCH .

if sy-subrc eq 0.

it_out-kschl = it_a304-kschl.

it_out-vkorg = it_a304-vkorg.

it_out-vtweg = it_a304-vtweg.

it_out-knumh = it_a304-knumh.

endif.

read table it_konp with key knumh = it_a304-knumh BINARY SEARCH .

if sy-subrc eq 0.

it_out-kbetr = it_konp-kbetr.

endif.

IF IT_OUT-KBETR <= '5.00'.

IT_OUT-FACTOR = IT_OUT-KBETR.

ELSE.

IT_OUT-FACTOR = ( IT_OUT-KBETR ) * '0.55'.

ENDIF.

APPEND IT_out.

endloop.

Re: Time consuming in Loop ...

rodrigo_paisante3 — Mon, 02 Jul 2007 12:43:36 GMT

Hi,

change your select, put only the fields you really need. select * is bad for performance.

START-OF-SELECTION.

select field1... field n from mara client specified

into corresponding fields of table itab

where mandt = sy-mandt and matnr in matnr1

and matkl in ptype and mtart = 'ZFIN'.

sort itab by matnr.

if not itab[] is initial.

select field1... field n from makt into corresponding fields of table it_makt

for all entries in itab where matnr = itab-matnr.

sort it_makt by matnr.

endif.

select field1... field n from a304 client specified

into corresponding fields of table it_a304

where mandt = sy-mandt and kschl = 'PR00'.

sort it_a304 by matnr.

select field1... field n from konp client specified

into corresponding fields of table it_konp

where mandt = sy-mandt and KSCHL = 'PR00'.

sort it_konp by knumh.

loop at itab.

it_out-matnr = itab-matnr.

it_out-matkl = itab-matkl.

read table it_makt with key matnr = itab-matnr.

it_out-maktx = it_makt-maktx.

read table it_a304 with key matnr = itab-matnr.

it_out-kschl = it_a304-kschl.

it_out-vkorg = it_a304-vkorg.

it_out-vtweg = it_a304-vtweg.

it_out-knumh = it_a304-knumh.

read table it_konp with key knumh = it_a304-knumh.

it_out-kbetr = it_konp-kbetr.

IF IT_OUT-KBETR <= '5.00'.

IT_OUT-FACTOR = IT_OUT-KBETR.

ELSE.

IT_OUT-FACTOR = ( IT_OUT-KBETR ) * '0.55'.

ENDIF.

APPEND IT_out.

endloop.

Re: Time consuming in Loop ...

Former Member — Mon, 02 Jul 2007 12:44:55 GMT

Sorry, the two first already given answers are right. I got something wrong.

Timo.

Re: Time consuming in Loop ...

Former Member — Mon, 02 Jul 2007 12:53:42 GMT

THanks Tripath,

YAB

Re: Time consuming in Loop ...

Clemenss — Mon, 02 Jul 2007 12:55:12 GMT

Hi YUSUF BHORI,

small addition/change:


sort:
  it_makt by matnr,  
  it_a304 by matnr ,
  it_konp by knumh.
field-symbols:
  <itab> like itab,
  <makt> like it_makt,
  <konp> like it_konp.
loop at itab assigning <itab>.

it_out-matnr = <itab>-matnr.
it_out-matkl = <itab>-matkl.

read table it_makt assigning <makt>
  with key matnr = <itab>-matnr
  binary search.
it_out-maktx = <makt>-maktx.

read table it_a304  assigning <a304> 
  with key matnr = <itab>-matnr
  binary search.
  it_out-kschl = <a304>-kschl.
  it_out-vkorg = <a304>-vkorg.
  it_out-vtweg = <a304>-vtweg.
  it_out-knumh = <a304>-knumh.

read table it_konp   assigning <konp>
  with key knumh = <a304>-knumh
  binary search.
 it_out-kbetr = <konp>-kbetr.

IF IT_OUT-KBETR <= '5.00'.
IT_OUT-FACTOR = IT_OUT-KBETR.
ELSE.
IT_OUT-FACTOR = ( IT_OUT-KBETR ) * '0.55'.
ENDIF.
APPEND IT_out.

endloop

This is just´a quick shot, but I'm conviced this will do factor 8 to 20 for the loop, depenmds on data amount.

Loop assigning will not waste the time copying each table line to the header line in the loop.

READ ... BINARY SEARCH will reduce search time logarithmically.

BTW: Replace SELECT * bay select into corresponding fields. Remove CLIENT SPECIFIED - it's nonsense.

Regards,

Clemens

Re: Time consuming in Loop ...

Clemenss — Mon, 02 Jul 2007 12:56:25 GMT

sorry I was too slow but my solution is the fastest

Re: Time consuming in Loop ...

S0025444845 — Mon, 02 Jul 2007 12:58:11 GMT

Hi,

1)donot use select * use select< particular fields only>.

2) declare structures with types with the particular fields needed and then decclre internal tables of those structrues. like.

types: begin of ty_makt.

matnr typr makt-matnr,

maktx type makt-maktx,

end of ty_makt.

data : it_makt type standard table of ty_makt.

if itab[] is not initial.

select matnr makt into table it_makt from makt

for all entries in itab where matnr = itab-matnr.

3) use binary search before that sort the internal tables with the keys by which u r reading.like

sort it_makt by matnr.

loop at itab.

read table it_makt with key matnr = itab-matnr

binary search.

4) check sy-subrc.

if sy-subr4c is initial.

it_out-maktx = it_makt-maktx.

endif.

5) clear all header lines like

clear: it_makt.

then append it-out.

endloop.

regards,

sudha