topic Re: Please review this select statement in Application Development and Automation Discussions

Please review this select statement

Former Member — Tue, 03 Jul 2007 14:04:43 GMT

please see this,

I have to select Fname and value_old from CDPOS on given conditions plus from tables ADRC and ADR2. but sometime only ADRC table might be changed and ADR2 table may not be changed and sometime vice versa and some times both tables have changed .

anyway I have to select changes happened in both tables, if change is only in one table (either ADRC or ADR2), I have to pick from that table only, if both I have to pick from both tables. Please review this code.

SELECT FNAME VALUE_OLD

INTO CORRESPONDING FIELDS OF I_CDPOS

FROM CDPOS

WHERE CDPOS~OBJECTID = I_CDPOS-OBJECTID AND

CDPOS~OBJECTCLAS = I_CDPOS-OBJECTCLAS AND

CDPOS~CHANGENR = I_CDPOS-CHANGENR AND

( CDPOS_{TABNAME = 'ADRC' and CDPOS}TABNAME = 'ADR2' ).

Thanks & Regards

Venkat

Re: Please review this select statement

Former Member — Tue, 03 Jul 2007 14:08:02 GMT

try this..

SELECT FNAME VALUE_OLD

INTO CORRESPONDING FIELDS OF I_CDPOS

FROM CDPOS

WHERE CDPOS~OBJECTID = I_CDPOS-OBJECTID AND

CDPOS~OBJECTCLAS = I_CDPOS-OBJECTCLAS AND

CDPOS~CHANGENR = I_CDPOS-CHANGENR AND

CDPOS~TABNAME IN ( 'ADRC' , 'ADR2' ).

Re: Please review this select statement

Former Member — Tue, 03 Jul 2007 14:10:51 GMT

Hi Venkat,

Instead of writing select query on CDPOS ,use FM for Better performance

FM - CHANGEDOCUMENT_READ_POSITIONS

Thanks

Seshu

Re: Please review this select statement

Former Member — Tue, 03 Jul 2007 14:41:02 GMT

Hi Seshu / Sekhar,

Thanks for your replies.

Sekhar, I tried your code !!!! it gives me syntax error, 'comma without preceding colon' Moreover I am using internal table i_cdpos in where clause so I think I can"t use IN Statement.

I guess I have to use

SELECT FNAME VALUE_OLD

INTO CORRESPONDING FIELDS OF I_CDPOS

FROM CDPOS

WHERE CDPOS~OBJECTID = I_CDPOS-OBJECTID AND

CDPOS~OBJECTCLAS = I_CDPOS-OBJECTCLAS AND

CDPOS~CHANGENR = I_CDPOS-CHANGENR AND

( CDPOS_{TABNAME = 'ADRC' OR CDPOS}TABNAME = 'ADR2' ).

Seshu, Thanks for your advice, this is just a simple chang, So I would like to go with this change in code instead of using FM, I guess I have to change lot of code, If I use FM. I know that FM would be better solution.

Once again thanks for your replies.

Regards

Venkat

Message was edited by:

venkat Kumbham

Re: Please review this select statement

Former Member — Tue, 03 Jul 2007 14:52:07 GMT

just remove the spaces after first bracket and before second bracket

SELECT FNAME VALUE_OLD

INTO CORRESPONDING FIELDS OF I_CDPOS

FROM CDPOS

WHERE CDPOS~OBJECTID = I_CDPOS-OBJECTID AND

CDPOS~OBJECTCLAS = I_CDPOS-OBJECTCLAS AND

CDPOS~CHANGENR = I_CDPOS-CHANGENR AND

CDPOS~TABNAME IN ('ADRC' , 'ADR2').

Re: Please review this select statement

Former Member — Tue, 03 Jul 2007 15:15:10 GMT

Thanks Sekhar, I got it !!!

Closiing thread !!! Alloting points !1

Regards

Venkat