topic Re: Select loop in Application Development and Automation Discussions

Select loop

joerg_arndt — Fri, 22 Jun 2007 12:16:30 GMT

Hi Folks,

I try to download all the Reports to a file with the following code.

But it selects only 1 record and then it stops with a runtime error.

REPORT Z_DOWNLOAD_REPORTS .

tables trdir.

DATA : BEGIN OF ITAB OCCURS 0,

F(72) TYPE C,

END OF ITAB.

select *

from trdir

where name like 'BA%'.

READ REPORT trdir-name INTO ITAB.

CALL FUNCTION 'GUI_DOWNLOAD'

EXPORTING

FILENAME = 'C:\PRG.TXT'

TABLES

DATA_TAB = ITAB.

endselect.

Thank you very much for the help.

Joerg

Re: Select loop

seshatalpasai_madala — Fri, 22 Jun 2007 12:19:58 GMT

Hi,

Dont put any FM call between SELECT and ENDSELECT.

What you can do instead use SELECT INTO TABLE and then

data: it_trdir type table trdir.

SELECT * FROM TRDIR INTO TABLE it_trdir where name like 'BA%'.

call the FM

CALL FUNCTION 'GUI_DOWNLOAD'

EXPORTING

FILENAME = 'C:\PRG.TXT'

TABLES

DATA_TAB = ITAB.

Regards,

Sesh

Re: Select loop

Former Member — Fri, 22 Jun 2007 12:20:01 GMT

try removing the select end select loop. Instead, take all programs in to another internal table and loop at that internal table to read the program and download.

reward if it helps

krishna

Re: Select loop

Former Member — Fri, 22 Jun 2007 12:23:09 GMT

Your GUI_DOWNLOAD statement is inside the select statement thats y , for each record it will excecute the GUI_DOWNLOAD fm. thts y one record is coming, the error is because of callin the fm in side the select statement.

regards

prabhu

Re: Select loop

Former Member — Fri, 22 Jun 2007 12:23:35 GMT

regards

prabhu

reward if it is helpful

Re: Select loop

kostas_tsioubris — Fri, 22 Jun 2007 12:24:18 GMT

Hi,

your code has 2 errors. First of all the GUI_DOWNLOAD probably performs a commit work or something which in turn crash your program. Second since you are giving the same file name your file will be overwriten.

Do something like this.

data : begin of lt_name occurs 0,

name like trdir-name,

end of lt_name.

data: filename type string.

select name

from trdir into table lt_name

where name like 'BA%'.

loop at lt_name.

READ REPORT lt_name-name INTO ITAB.

filename = lt_name-name.

condense filename no-gaps.

concatenate ''C:\' filename '.txt' into filename.

condense filename no-gaps.

CALL FUNCTION 'GUI_DOWNLOAD'

EXPORTING

FILENAME = filename

TABLES

DATA_TAB = ITAB.

endloop.

Regards

Kostas

Message was edited by:

Kostas Tsioubris

Re: Select loop

Former Member — Fri, 22 Jun 2007 12:26:11 GMT

Hi,

Remove the FM from Select... EndSelect.

Instead use

REPORT Z_DOWNLOAD_REPORTS .

tables trdir.

DATA : BEGIN OF ITAB OCCURS 0,

F(72) TYPE C,

END OF ITAB.

SELECT *

FROM TRDIR INTO TABLE ITAB

WHERE NAME LIKE 'BA%'.

CALL FUNCTION 'GUI_DOWNLOAD'

EXPORTING

FILENAME = 'C:\PRG.TXT'

TABLES

DATA_TAB = ITAB.

Reward points if useful,

Kiran

Re: Select loop

Former Member — Fri, 22 Jun 2007 12:28:59 GMT

since you put the same program in select loop. you ll get the last output of the FM in last pass of the loop.

so your approach shud be like this

1. make a select on table and populate the data in internal table

2. loop at itab into wa.

use FM using WA

Endloop.

3. Cheers.

Re: Select loop

joerg_arndt — Fri, 22 Jun 2007 13:06:30 GMT

Thank you very much.