topic Performance problem in Application Development and Automation Discussions

Performance problem

Former Member — Thu, 31 May 2007 11:52:38 GMT

Hi friends ,

Below is the one of the perform in my program which is taking more time .. Can you please suggest me to find a solution to take less time for execution.

Thanks in Adv .

Varma ..

DATA: l_count TYPE i.

SELECT m~customer

m~name

m~payer

t~txtmd

INTO TABLE gt_cust2

FROM /bi0/pcustomer AS m

JOIN /bi0/tcustomer AS t

ON m_{customer EQ t}customer

WHERE m~objvers EQ 'A'

AND m~accnt_grp NE space.

SORT gt_cust2 BY customer.

SELECT m~customer

m~name

m~payer

t~txtmd

INTO TABLE gt_cust

FROM /bi0/pcustomer AS m

JOIN /bi0/tcustomer AS t

ON m_{customer EQ t}customer

WHERE m~objvers EQ 'A'

AND m~accnt_grp IN s_ktokd

AND m~payer NE space.

IF sy-subrc = 0.

SORT gt_cust BY customer.

LOOP AT gt_cust.

CLEAR l_count.

LOOP AT gt_cust2 WHERE payer = gt_cust-payer.

ADD 1 TO l_count.

IF l_count > 1.

EXIT.

ENDIF.

ENDLOOP.

gt_soldto-customer = gt_cust-customer.

gt_soldto-payer = gt_payer-payer = gt_cust-payer.

IF l_count > 1.

Payer found

CLEAR gt_cust2.

READ TABLE gt_cust2 WITH KEY customer = gt_cust-payer

BINARY SEARCH.

IF NOT gt_cust2-name IS INITIAL.

gt_payer-name = gt_cust2-name.

ELSE.

gt_payer-name = gt_cust2-txtmd.

ENDIF.

ELSE.

Stand alone customer

gt_soldto-payer = gt_payer-payer = p_nonpyr.

gt_payer-name = p_nonpnm.

ENDIF.

COLLECT: gt_soldto,

gt_payer.

ENDLOOP.

SORT: gt_soldto,

gt_payer.

ENDIF.

Re: Performance problem

Former Member — Thu, 31 May 2007 12:01:04 GMT

ok what i would do is not to do 2 of such big selects.

your first select and your second select are almost identical.

Only yout got one more condition in your second select.

this again means your recordset you gain from your second select is just a subset of the reocrdset you gain with your first select.

This again means you dont need to go down to the DB another time, since all the data you need is already in your internal table you fill with your first select.

So in your first select you need to add the fields for which in your second select conditions exist.

Then you can do your second select not on the DB-table but on your internal table.

Statement for this is "READ TABLE" instead of SELECT.

Re: Performance problem

dev_parbutteea — Thu, 31 May 2007 12:03:00 GMT

HI,

LOOP AT gt_cust.<b>use loop assigning field symbol</b>

CLEAR l_count.

<b>LOOP AT gt_cust2 WHERE payer = gt_cust-payer.

ADD 1 TO l_count.

IF l_count > 1.

EXIT.

ENDIF.

ENDLOOP.</b>

just do a read gt_cust2 into Wa_cust2 where payer = gt_cust-payer

Re: Performance problem

Former Member — Thu, 31 May 2007 12:12:12 GMT

hi varma,

use for all entries instead of innerjoin and try to avoid nested loops.

regards,

seshu.

Re: Performance problem

Former Member — Thu, 31 May 2007 12:12:53 GMT

Are there any other ways ... Please suggest ..

Thanks ,

Varma