code review

Former Member — Mon, 23 Apr 2007 11:47:44 GMT

what is code review in realtime?.how can we use it?

Re: code review

Former Member — Mon, 23 Apr 2007 11:58:17 GMT

there will be some checklist to review the code written by others

eg :

--> whether the internal table is cleared and refreshed before select statements

--> whether there are any errors in EC check

Select Statements

Primary key(s) specified while using statements 'Select single'/'For all entries in internal table' and even Pool tables

SY-SUBRC check is done before adding/ moving data to internal tables / Clear statement for the database tables before the 'Select' statement ( if sy-subrc chk cannot be done)

Check for proper fields (selected database fields) being moved while populating them into internal tables

Check whether the internal table is populated before further Processing/Selections

Required fields ( in the order as per the database table ) have been selected while using 'Select Into Table'

Loops / Performs / Internal Tables

Usage of correct parameters( field lengths and data-types ) while using 'Call Function'

Proper usage of parameters while invoking routines using ‘Perform’ statements

Internal table structure is defined as per the sorting priority used in the code for AT-NEW / AT-END command

Transaction Validations

Check screen flow in the transaction

Check the OK_CODE for each of the screens

Check and validate field lengths

Check data types/format of the fields in the screens. Be careful of date formats.

Check for the mandatory and suppressed fields in the screen

Message was edited by:

Chandrasekhar Jagarlamudi

topic Re: code review in Application Development and Automation Discussions

code review

Re: code review