topic Re: Help on performance issues in Application Development and Automation Discussions

Help on performance issues

Former Member — Thu, 03 May 2007 06:46:36 GMT

Hi All,

Could you correct me to the following coding with the Bold part, how to avoid using the Loop for below coding which will not effect the performance issues.

OPEN DATASET p_inpfl FOR INPUT IN TEXT MODE.

DO.

READ DATASET p_inpfl INTO i_input.

IF sy-subrc EQ 0.

APPEND i_input.

CLEAR i_input.

ELSE.

EXIT.

ENDIF.

ENDDO.

CLOSE DATASET p_inpfl.

ENDIF.

CONSTANTS: con_tab TYPE x VALUE '09'.

LOOP AT i_input.

SPLIT i_input AT con_tab INTO i_finaltab-Field1 i_input.

SPLIT i_input AT con_tab INTO i_finaltab-Field2 i_input.

APPEND i_finaltab.

CLEAR i_finaltab.

ENDLOOP.

Re: Help on performance issues

Former Member — Thu, 03 May 2007 06:59:26 GMT

Hi,

OPEN DATASET p_inpfl FOR INPUT IN TEXT MODE.

if sy-subrc = 0.

DO.

READ DATASET p_inpfl INTO i_input.

IF sy-subrc EQ 0.

APPEND i_input.

CLEAR i_input.

ELSE.

EXIT.

ENDIF.

ENDDO.

endif.

CLOSE DATASET p_inpfl.

CONSTANTS: con_tab TYPE x VALUE '09'.

LOOP AT i_input.

***SPLIT i_input AT con_tab INTO i_finaltab-Field1 i_input.

*****SPLIT i_input AT con_tab INTO i_finaltab-Field2 i_input.

TRANSFER i_input TO i_finaltab.

****APPEND i_finaltab.

*****CLEAR i_finaltab.

ENDLOOP.

reward if useful

regards,

nazeer

Re: Help on performance issues

Former Member — Thu, 03 May 2007 07:45:33 GMT

Hi - do the SPLIT after you have fill the work area w_input - this has the same structure as the internal table i_input. This way you only have 1 internal table to fill and you don't need to loop through i_input

CONSTANTS: con_tab TYPE x VALUE '09'.

OPEN DATASET p_inpfl FOR INPUT IN TEXT MODE.

DO.

READ DATASET p_inpfl INTO w_input.

IF sy-subrc NE 0.

EXIT

ENDIF.

SPLIT w_input AT con_tab INTO i_finaltab-Field1 i_input.

SPLIT w_input AT con_tab INTO i_finaltab-Field2 i_input.

APPEND i_finaltab.

CLEAR i_finaltab.

ENDDO.

CLOSE DATASET p_inpfl.