topic Re: Dual Nature for Abap code. in Application Development and Automation Discussions

Dual Nature for Abap code.

Former Member — Tue, 21 Dec 2004 06:41:43 GMT

Hi,

Requirment is

For a Material,

Orders required quantity

components for that material

their requirment.

my program takes material and orders from RESB table.

to get components i am looping through header table using Function module -'CS_BOM_EXPL_MAT_V2'.

If i do the debugginf i am able to see that data is going properly to internal table. but when i execute, Components data is missing.

Any body can help me in this?

What might be the cause?

Regards,

Lijo Joseph

Re: Dual Nature for Abap code.

athavanraja — Tue, 21 Dec 2004 06:50:52 GMT

It will be really difficult to address your issue with the info. you have given. Can you post the code here , that will help us to analyze it better.

Regards

Raja

Re: Dual Nature for Abap code.

Former Member — Tue, 21 Dec 2004 07:40:03 GMT

SELECT aufnr matnr werks bdmng meins bdter INTO CORRESPONDING FIELDS OF TABLE it_resb FROM resb WHERE aufnr IN s_aufnr AND matnr IN s_matnr.

IF sy-subrc <> 0.

MESSAGE 'No Values Found' TYPE 'I'.

LEAVE LIST-PROCESSING.

ENDIF.

**Checking Status of order.

*************************************

LOOP AT it_afko.
CALL FUNCTION 'ZPP_VALID_REL_ORDER'
EXPORTING
aufnr = it_afko-lead_aufnr
IMPORTING
valid = it_afko-stat.
MODIFY it_afko TRANSPORTING stat.
ENDLOOP.
DELETE it_afko WHERE stat = 'N'.

************************************

DELETE it_resb WHERE aufnr = space.

SORT it_resb BY matnr.

LOOP AT it_resb.

ON CHANGE OF it_resb-matnr.

FORMAT COLOR COL_HEADING ON.

WRITE:/ sy-vline,it_resb-matnr,sy-uline.

FORMAT COLOR OFF.

ENDON.

WRITE:/ sy-vline,it_resb-aufnr,it_resb-bdmng,it_resb-meins.

AT END OF matnr.

READ TABLE it_resb INDEX sy-tabix.

SUM.

l_bdmng = it_resb-bdmng.

PERFORM bom_explode.

LOOP AT stb.

WRITE:/ sy-vline,stb-idnrk,stb-mnglg.

ENDLOOP.

WRITE: sy-uline.

ENDAT.

ENDLOOP.

TOP-OF-PAGE.

CALL FUNCTION 'ZCA_REPORT_HEADER'

EXPORTING

hdval = 'Cutting List For Stores'

rpsize = 130

plant = 'BLR'.

&----

*& Form bom_explode

&----

text

----

--> p1 text
<-- p2 text

----

FORM bom_explode .

CALL FUNCTION 'CS_BOM_EXPL_MAT_V2'

EXPORTING

aufsw = ' '

aumng = 0

capid = 'PP01'

datuv = sy-datum

ehndl = '1'

emeng = it_resb-bdmng

mktls = 'X'

mehrs = 'X'

mtnrv = it_resb-matnr

stpst = 0

svwvo = 'X'

werks = it_resb-werks

vrsvo = 'X'

IMPORTING

topmat = topmat

dstst = dstst

TABLES

stb = stb

matcat = matcat

EXCEPTIONS

alt_not_found = 1

call_invalid = 2

material_not_found = 3

missing_authorization = 4

no_bom_found = 5

no_plant_data = 6

no_suitable_bom_found = 7

conversion_error = 8

OTHERS = 9.

IF sy-subrc <> 0.

MESSAGE ID sy-msgid TYPE sy-msgty NUMBER sy-msgno
WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4.

ELSE.

WRITE:/ sy-uline.

ENDIF.

ENDFORM. " bom_explode

Re: Dual Nature for Abap code.

Former Member — Tue, 21 Dec 2004 07:55:51 GMT

The subject line of this message has been very interesting.

Some questions that come to my mind are :

a) Do you see the output perfectly in debugging mode ?

b) Is the subroutine bom_explode working as you have intended it to ?

Something to try :

a) In debugging mode, try pressing F6 when it comes to the PERFORM bom_explode, line, and check whether the internal table still has proper values ?

b) Try the same with F5 and check again if it has proper values ?

c) If it does not, check whether the values of it_resb internal table are proper while you pass it to the function module.

d) Instead of using 'ON CHANGE OF', try 'AT NEW MATNR'. It is a little dangerous to use 'ON CHANGE OF' in LOOP.

As far as I have seen, there might be some oversight/trivial issue which needs to be solved with patience.

Hope this helps.

Regards,

Subramanian V.

Re: Dual Nature for Abap code.

athavanraja — Tue, 21 Dec 2004 09:06:28 GMT

Hi,

Its clear now.

You are looping at it_resb and within that loop at end of matnr you have PERFORM bom_explode.

In that perform you are calling FM 'CS_BOM_EXPL_MAT_V2' and passing it_resb-bdmng ,it_resb-matnr and it_resb-werks .

In this case since the perfrom is within at end of and end at the vales of it_resb-bdmng & it_resb-werks will be ******* , only the value of matnr will be there .

I am surprised that it worked in debuggin.

try moving the it_resb to a work area before using at end of stt. and use that to pass it to the function.

Hope i am clear.

Regards

Raja

Re: Dual Nature for Abap code.

Former Member — Tue, 21 Dec 2004 09:43:34 GMT

Hello Raja,

Before the subroutine call, the read statement


READ TABLE it_resb INDEX sy-tabix.

would populate the header. Correct me if I'm wrong.

Joseph :

Sorry if this sounds a little silly, but did you, by accident declare another STB internal table within the subroutine? Because, in that case, the declaration you have made globally will always be empty. And in the debugging mode you will still be able to see the entries in the internal table (the one that's declared locally)

Please do get back on this one.

Regards,

Anand Mandalika.

Re: Dual Nature for Abap code.

Former Member — Tue, 21 Dec 2004 09:58:00 GMT

1)I am getting Result perfectly in Debugging mode when i go through it by pressing f6.

2)Subroutine is working accrding to the expectation when i do debugging.

When debugging comes to Internal table data is populated in internal table.

Let me clear one thing.. Why you have mention use of on change is danger? in what aspect?

Regards,

Lijo Joseph

Re: Dual Nature for Abap code.

Former Member — Tue, 21 Dec 2004 10:04:31 GMT

Hello Poornanand Mandalika ,

AS you said my read statement populate the header.

I have not declared two internal tables.

i am getting output properly while i do debugging by pressing f6 and excecute it.

If required i will write whole code in the forum.

Regards,

Lijo Joseph

Re: Dual Nature for Abap code.

athavanraja — Tue, 21 Dec 2004 10:09:25 GMT

Hi Anand,

Sorry i missed the stt. you are correct, that would populate the header.

Joseph :

When you come out of the perform, and try to loop at stb, are the values available in stb. If not then i would assume that stb is not declared globally.

Regards

Raja

Re: Dual Nature for Abap code.

Former Member — Tue, 21 Dec 2004 10:26:09 GMT

Hello Durai raj,

I am getting data in STB after performing BOM explode.

Even i get desired output if i go through debugging.

Only if i execute directly, i am loosing some data which comes from BOM Function module.

Will it be because of lack of authorizations?

Regards,

Lijo Joseph

Re: Dual Nature for Abap code.

Former Member — Tue, 21 Dec 2004 10:31:10 GMT

Hi,

I still feel the problem should not lie with/without debugging.

The below note has been fetched from SAP Help, why ON CHANGE OF should not be used with LOOP.


Note

There are special control structures for processing control breaks in 

LOOPs on internal tables or extract datasets ( 
AT ).

ON CHANGE OF is unsuitable for recognizing control levels
in loops of this type because it always creates a global 
auxiliary field which is used to check for changes. This 
global auxiliary field is only changed in the relevant ON 
CHANGE OF statement. It is not reset when the processing
enters loops or subroutines, so unwanted effects can 
occur if the loop or subroutine is executed again. Also, 
since it is set to its initial value when created (like 
any other field), any ON CHANGE OF processing will be 
executed after the first test, unless the contents of the 
field concerned happen to be identical to the initial 
value.

Regards,

Subramanian V.

Re: Dual Nature for Abap code.

Former Member — Tue, 21 Dec 2004 10:32:54 GMT

Hello Joseph,

Just try one thing out - include the write statements in the subroutine itself. For example,


LOOP AT it_resb.

  ................................
  ................................
  ................................
  ................................

  AT END OF matnr.

    READ TABLE it_resb INDEX sy-tabix.
    SUM.
    l_bdmng = it_resb-bdmng.

    PERFORM bom_explode.

    WRITE: sy-uline.

  ENDAT.

ENDLOOP.


FORM bom_explode .

  CALL FUNCTION 'CS_BOM_EXPL_MAT_V2'
    EXPORTING
      .....      
      .....
      .....
    TABLES
      stb = stb
      matcat = matcat
    EXCEPTIONS
      .....      
      .....

  IF sy-subrc <> 0.
  ELSE.
    WRITE:/ sy-uline.
  ENDIF.

    LOOP AT stb.
      WRITE:/ sy-vline,stb-idnrk,stb-mnglg.
    ENDLOOP.

endform.

If that still doesn't work, then please paste your entire code here in the forum. We will be able to help you better.

Also, please note that the ON CHANGE OF block will fail in some cases eg: where the matnr is initial for the first (few) loop pass(es).

Hope to see your problem resolved.

Regards,

Anand Mandalika.

Re: Dual Nature for Abap code.

Former Member — Tue, 21 Dec 2004 10:42:08 GMT

Dear Subramanian,

If on change makes the problem, how its working in Debugging?

And as you said i have tried by using at end of also. it does nt work.

To use function modules, whether we require some authorization?

Regards,

Lijo Joseph

Re: Dual Nature for Abap code.

Former Member — Tue, 21 Dec 2004 10:46:32 GMT

Hello Joseph,

It has got nothing to do with authorizations. If you are saying that it is working in the debug-mode, it means that you have the authorizations required.

Hope that's clear.

Also please refer to my post below.

Regards,

Anand Mandalika.

P.S. : As and when you read a response, if you like it, please reward the points to the person posting the message. Click the yellow icon in the Post's header to do that.

Re: Dual Nature for Abap code.

athavanraja — Tue, 21 Dec 2004 10:57:39 GMT

As Anand said, it has nothing to do with authorization as its working in debug mode.

i thinks its time that you have to provide us the full code here to analyze the issue.

Regards

Raja

Re: Dual Nature for Abap code.

Former Member — Tue, 21 Dec 2004 10:58:42 GMT

Hi Lijo,

I suggest you copy-paste the program here. I do not have the answer to the question "How is this 'On Change Of' working properly in debugging mode?". Probably one of those weird days.

As Anand has already said, there is no authorisation problem. Had this been an issue, even in debugging, it would not work. First , you need to remove the floating theory that, ABAP compiler has dual roles. (If this really is true, my goodness, can't even imagine..)

Regards,

Subramanian V.

Re: Dual Nature for Abap code.

Former Member — Tue, 21 Dec 2004 11:10:58 GMT

Hi friends, here is the code.

REPORT zpp_cut_mat_issue LINE-SIZE 130 LINE-COUNT 65(3) NO STANDARD PAGE HEADING .

*************************************************************************

*Tables

*************************************************************************

TABLES : resb,makt,marc,afko,mara,aufk.

*************************************************************************

*Inputs

*************************************************************************

*PARAMETERS :

*Lead Production Order No.

P_AUFNR LIKE AFPO-AUFNR OBLIGATORY.

SELECT-OPTIONS :

*From No. to No.

s_matnr FOR resb-matnr ,

s_bdter FOR resb-bdter , "

s_ekgrp FOR marc-ekgrp,

s_mtyp FOR mara-extwg NO-EXTENSION NO INTERVALS ," TYPE C OBLIGATORY.

s_aufnr FOR resb-aufnr, "production order

s_dispo FOR marc-dispo, "MRP type

s_erdat FOR aufk-erdat. "prdn order creation date

PARAMETERS :

p_print TYPE c AS CHECKBOX,

p_sum TYPE c AS CHECKBOX.

RANGES : r_resb FOR afko-rsnum.

********************************************************************

*Constants

********************************************************************

*************************************************************************

*Type Pools

************************************************************************

TYPE-POOLS : cs01.

*************************************************************************

*Data Declaration

*************************************************************************

DATA :

ismast TYPE cs01_mastb OCCURS 0 WITH HEADER LINE,

topmat TYPE cstmat OCCURS 0 WITH HEADER LINE,

stb TYPE stpox OCCURS 0 WITH HEADER LINE,

matcat TYPE cscmat OCCURS 0 WITH HEADER LINE,

dstst TYPE csdata-xfeld.

START-OF-SELECTION.

DATA it_resb LIKE resb OCCURS 0 WITH HEADER LINE.

SELECT aufnr matnr werks bdmng meins bdter INTO CORRESPONDING FIELDS OF TABLE it_resb FROM resb WHERE aufnr IN s_aufnr AND matnr IN s_matnr.

IF sy-subrc <> 0.

MESSAGE 'No Values Found' TYPE 'I'.

LEAVE LIST-PROCESSING.

ENDIF.

DELETE it_resb WHERE aufnr = space.

SORT it_resb BY matnr.

LOOP AT it_resb.

*Writing header

ON CHANGE OF it_resb-matnr.

FORMAT COLOR COL_HEADING ON.

WRITE:/ sy-vline,it_resb-matnr,sy-uline.

FORMAT COLOR OFF.

DATA: l_bdmng LIKE resb-bdmng.

ENDON.

*Writing Line Items.

WRITE:/ sy-vline,it_resb-aufnr,it_resb-bdmng,it_resb-meins.

AT END OF matnr.

*Writing Components Details

IF sy-subrc = 0.

READ TABLE it_resb INDEX sy-tabix.

SUM.

l_bdmng = it_resb-bdmng.

*Getting Components

PERFORM bom_explode.

*Displaying Components.

LOOP AT stb.

WRITE:/ sy-vline,stb-idnrk,stb-mnglg.

ENDLOOP.

ENDIF.

WRITE: sy-uline.

ENDAT.

ENDLOOP.

&----

*& Form bom_explode

&----

text

----

--> p1 text
<-- p2 text

----

FORM bom_explode .

CALL FUNCTION 'CS_BOM_EXPL_MAT_V2'

EXPORTING

aufsw = ' '

aumng = 0

capid = 'PP01'

datuv = sy-datum

ehndl = '1'

emeng = it_resb-bdmng

mktls = 'X'

mehrs = 'X'

mtnrv = it_resb-matnr

stpst = 0

svwvo = 'X'

werks = it_resb-werks

vrsvo = 'X'

IMPORTING

topmat = topmat

dstst = dstst

TABLES

stb = stb

matcat = matcat

EXCEPTIONS

alt_not_found = 1

call_invalid = 2

material_not_found = 3

missing_authorization = 4

no_bom_found = 5

no_plant_data = 6

no_suitable_bom_found = 7

conversion_error = 8

OTHERS = 9.

IF sy-subrc <> 0.

MESSAGE ID sy-msgid TYPE sy-msgty NUMBER sy-msgno
WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4.

ELSE.

WRITE:/ sy-uline.

ENDIF.

ENDFORM. " bom_explode

TOP-OF-PAGE.

CALL FUNCTION 'ZCA_REPORT_HEADER'

EXPORTING

hdval = 'Cutting List For Stores'

rpsize = 130

plant = 'BLR'.

Re: Dual Nature for Abap code.

ssimsekler — Tue, 21 Dec 2004 11:45:01 GMT

Hi Lijo

Firstly,

"ON CHANGE OF" has a buggy situation (Subramanian pointed before) as far as I know. Hence, just after your loop ends, insert the code:


CLEAR it_resb-matnr .
ON CHANGE OF it_resb-matnr .
ENDON .

This will clear the temporary work area that "ON CHANGE OF" uses.

Secondly,

I do not know what the "CS_BOM..." function is used for. Will a commit work statement after it do any work? I know, you do not seem updating anything, however although this is a very very poor possibility but the function may need it. So put a commit statement after calling your FM.

*--Serdar

Re: Dual Nature for Abap code.

Former Member — Tue, 21 Dec 2004 11:58:16 GMT

Hello Joseph,

1.What's the sy-subrc check doing within the AT END OF block ?

2. It is my opinion that the program is not sufficiently modularized. The subroutine must have an interface and all the values used within it should be passed into it. Similarly, the values required outside the subroutine should be pssed out of it.

As I have mentioned in an earlier post, in this case, the write statements for the STB internal table are best written inside the subroutine.

Instead of trying to analyze why the program you have written is not working, (which is most probably because of some global data issue), it is better that you first try to modularize the subroutine properly. That would localize the area of error.

Hope this helps,

Regards,

Anand Mandalika.

Re: Dual Nature for Abap code.

Former Member — Tue, 21 Dec 2004 11:59:21 GMT

Hi Serdar,

Thank you for your points. But my problem is not fully solved. Given function module explode the Bill of Material and list all the child materials.

As you said i have coded commit work after perform.

Now i am able to get last explosion result. but i want that explosion details for all the materials. I f i give two materials, i should get components for that materials.

i have commented "On change of" it is used just to display the material.

can you briefly tell me what Commit work do? and work and wait?