topic Re: Code review in Application Development and Automation Discussions

Code review

Former Member — Tue, 20 Feb 2007 10:47:09 GMT

Hi all,

I was doing Code review for a report, when I was checking code through extended program check it was giving a warning as below

Program: ZCSRE_HU_PRODUCTION_REPORT Include: ZCSRM_HU_PRD_PROCESS_FORMS Line : 149

P_FIELDCAT stands for 2 fields: Table P_FIELDCAT[] and its header line

Field P_FIELDCAT is not referenced statically in the program

Can you please suggest me how to remove this warning.

Thanks in advance

Re: Code review

Former Member — Tue, 20 Feb 2007 10:48:28 GMT

Hi,

U might not used P_FIELDCAT field in the program. Comment the field, error will be rectified.

Regards

kannaiah

Re: Code review

seshatalpasai_madala — Tue, 20 Feb 2007 10:50:05 GMT

Hi,

P_FIELDCAT is an internal table with headerline in your case. SO P_FILEDCAT[] is the internal table and P_FILEDCAT is the header line. I think in your program there is not static (IN the code) reference to it. Just try and comment the declaration of thisP_FIELDCAT and see if you still get this warninig.

Regards,

Sesh

Re: Code review

Former Member — Tue, 20 Feb 2007 10:52:46 GMT

Thanks for you response below is the code where it is using it please see it

FORM f9004_display_data TABLES p_output

p_fieldcat.

CALL METHOD o_alvgrid->set_table_for_first_display

EXPORTING

is_variant = w_variant

i_save = c_a

is_layout = w_layout

CHANGING

it_outtab = p_output[]

it_fieldcatalog = p_fieldcat[]

EXCEPTIONS

invalid_parameter_combination = 1

program_error = 2

too_many_lines = 3

OTHERS = 4.

IF sy-subrc <> 0.

MESSAGE i000 WITH text-e06."Error in ALV report display

LEAVE LIST-PROCESSING.

ENDIF.

ENDFORM. " f9004_display_data

Re: Code review

Former Member — Tue, 20 Feb 2007 10:57:35 GMT

Hi,

Write the form like below:

FORM f_populate_item TABLES P_OUTPUT structure ....

P_fieldcat STRUCTURE ....

Regards

Kannaiah

Re: Code review

raviprakash — Tue, 20 Feb 2007 11:01:39 GMT

Hi Ranjith,

I have faced the similar problem. It happens due to the usage of the TABLE parameter in the SUBROUTINE interface. Your TABLE PARAMETER is : P_FIELDCAT.

You can eliminate this by using the changing parameter instead. For this, create a GLOBAL DATA in TOP include of the report as:-

DATA: GT_FIELDCAT Type Table of ..... .

Then in the subroutine defination write:-

FORM <SUBROUTINE NAME> Changing P_FIELDCAT TYPE GT_FIELDCAT.

.....

ENDFORM.

Then in program call subroutine as following:-

PERFORM <SUBROUTINE NAME> changing p_fieldcat.

NOTE: This would DEFINITELY solve your problem. Also restrict using TABLE

PARAMETER as it creates a header line by default. Instead use

CHANGING AND USING.

NOTE: Please award points if you feel satisfied with the solution :D.

Thanks and regards,

Ravi .

Re: Code review

raviprakash — Tue, 20 Feb 2007 11:05:46 GMT

Hi Ranjith,

Replace your code by following code.And it would work.

In GLOBAL DATA or TOP Include add the following line:-

Data: GT_FIELDCAT type table of <STRUCTURE_NAME>.

FORM f9004_display_data CHANGING p_fieldcat LIKE GT_FIELDCAT

TABLES p_output.

CALL METHOD o_alvgrid->set_table_for_first_display

EXPORTING

is_variant = w_variant

i_save = c_a

is_layout = w_layout

CHANGING

it_outtab = p_output[]

it_fieldcatalog = p_fieldcat[]

EXCEPTIONS

invalid_parameter_combination = 1

program_error = 2

too_many_lines = 3

OTHERS = 4.

IF sy-subrc <> 0.

MESSAGE i000 WITH text-e06."Error in ALV report display

LEAVE LIST-PROCESSING.

ENDIF.

ENDFORM. " f9004_display_data

Thanks and regards,

Ravi .

Re: Code review

Former Member — Tue, 20 Feb 2007 12:00:07 GMT

Hi Ravi,

and iam getting another warnig for the same line please go through it

<b>Program: ZCSRE_HU_PRODUCTION_REPORT Include: ZCSRM_HU_PRD_PROCESS_FORMS Line : 149

P_OUTPUT stands for 2 fields: Table P_OUTPUT[] and its header line

Field P_OUTPUT is not referenced statically in the program</b>

PERFORM f9004_display_data TABLES i_final

i_fieldcat.

FORM f9004_display_data TABLES p_output

p_fieldcat.

CALL METHOD o_alvgrid->set_table_for_first_display

EXPORTING

is_variant = w_variant

i_save = c_a

is_layout = w_layout

CHANGING

it_outtab = p_output[]

it_fieldcatalog = p_fieldcat[]

EXCEPTIONS

invalid_parameter_combination = 1

program_error = 2

too_many_lines = 3

OTHERS = 4.

IF sy-subrc <> 0.

MESSAGE i000 WITH text-e06."Error in ALV report display

LEAVE LIST-PROCESSING.

ENDIF.

ENDFORM. " f9004_display_data

Please see this code