topic Re: IF statement Execution Error in Application Development and Automation Discussions

IF statement Execution Error

anurag_singh16 — Fri, 25 Jan 2019 07:30:38 GMT

Hi All,

Sorry to bother but I didn't know how to put up the question in better way than this.

If you have another thread for this query, kindly lead me to that thread.

I have a condition in code and the problem is that when the condition check is reached, the code is exited irrespective of the result of IF condition i.e., neither True nor False part is getting executed.

Please find below the code to understand the scenario.

1 is the IF condition.

2 is the True part of IF condition.

3 is the area of code which is out of so many nested conditions and is getting executed just after 1 instead of True or False part.

So, why is 2 not getting executed even if the value of 1 is True?

I am not able to figure out why is it happening and how to fix it.

Thanks,

Anurag

Re: IF statement Execution Error

tamitdassharma — Fri, 25 Jan 2019 07:35:50 GMT

Hello Anurag,

Replace your first IF condition with a range table.

Something like IF lv_flstr IN lt_range_table.

This will solve your issue.

Also, if you want to go ahead with the code that you have written, replace the AND with an OR and it should work fine.

Re: IF statement Execution Error

matt — Fri, 25 Jan 2019 07:51:36 GMT

"So, why is 2 not getting executed even if the value of 1 is True?"

Because the value of 1 is not true.

Set a breakpoint at 1. Run your program. Examine the values of

lv_flstr
lv_low
lv_high

If you still can't figure out the issue from that, then comment on this answer with the values of these variables, and their defined types.

Re: IF statement Execution Error

matt — Fri, 25 Jan 2019 07:54:44 GMT

This is not good advice. You have no idea where the lv_low and lv_high are being set, nor the context of the program.

You certainly cannot declare "this will solve your issue".

Anyway, it's far more important for the OP to understand why there's an issue with his code, then he just gets a "fix". If he follows your advice and by some chance it works, then all he's doing is programming by coincidence.

Re: IF statement Execution Error

Muthu_raja — Fri, 25 Jan 2019 08:20:31 GMT

Hi Anurag,

Is there any Else statement part found for the first if condition ??. Suppose if it is not there and condition fails, It would directly go to the line after the Endif statement of first if condition ( may be in your case line no: 159 )

if lv_flstr ge lv_low and lv_flstr le lv_high.
  read table...
  if
  endif
  if
  endif...
Else <--- search for this


endif.

So please check the Else part is available or not for the first if condition.

Re: IF statement Execution Error

tamitdassharma — Fri, 25 Jan 2019 09:08:49 GMT

Hello matthew.billingham,

It is clearly evident from the piece of code posted by anurag.singh16 that he is trying to execute a piece of code - labelled 2 in the screenshot when the condition in label 1 is fulfilled.

If you read the statement properly it is clear that he is comparing the value of lv_flstr to be in between lv_low and lv_high including both the limits. Hence I have suggested using a range table in place of that. I hope you will understand it better if you try to dry run the statement.

For the second suggestion of using OR. Since anurag has used the and operator and considering the value of lv_flstr to be greater than equal to lv_low the predecessor of the AND operator always forms to be true and the second part is considered to be false. And we all know any comparison including AND operator like (True AND False) will always result in false.

This is not programming by coincidence but understanding each line of code.

Hope you will try to understand answers provided by community users before criticizing.

Re: IF statement Execution Error

anurag_singh16 — Fri, 25 Jan 2019 09:19:06 GMT

Hi Muthu,

The code was working fine till yesterday.

It has just come up yesterday evening.

Still we are figuring out the reason for the same.

And also, the else part if added to check if the false reaches to Else or not, but failing to get even there.

Regards,

Anurag Singh

Re: IF statement Execution Error

anurag_singh16 — Fri, 25 Jan 2019 09:22:40 GMT

Hi Matthew,

The value of below variables at run time is as follows:

lv_flstr -> 85
lv_low -> 80
lv_high -> 100

So I guess, the value of IF is True. right ?

And also if it's False, then it should reach out to Else part of the same IF condition.

Now suggest.

Re: IF statement Execution Error

Muthu_raja — Fri, 25 Jan 2019 09:29:16 GMT

Ok I doubt whether the Else part was added recently is corresponding to the first if condition. Ok please confirm once the if condition fails which line it was going ??

Re: IF statement Execution Error

ArthurParisius — Fri, 25 Jan 2019 09:30:14 GMT

He also asked for their defined types, since that might also have an influence.

Re: IF statement Execution Error

Sandra_Rossi — Fri, 25 Jan 2019 09:44:38 GMT

dassharma : criticizing is always a good thing if it's fair and argumented (not done in a "lynch mob" way), and I find Matthew's comment fair and argumented, sorry to say that. Now, about your answer, I don't understand how it would help the OP solve his issue. Matthew's answer is better: it doesn't go in the "true" block of the IF because the condition is false, simple as that. Now, probably there's something tricky somewhere, and the question doesn't give clues what it can be... PS: please, don't bold your last sentences, it sounds like "yelling".

Re: IF statement Execution Error

Sandra_Rossi — Fri, 25 Jan 2019 09:46:30 GMT

Is it possible that you didn't restart your program ? (i.e. the source code in the debugger refers to the current source code, but the real code executed corresponds the old compiled code/old source code)

Re: IF statement Execution Error

matt — Fri, 25 Jan 2019 09:49:39 GMT

Sorry dassharma but I disagree.

I'm well aware of the fact that he's doing a simple "BETWEEN". And there's nothing wrong with that.

I find your suggestion that he convert that into a range is over complicating the issue. A range could contain anything - include patterns, exclusions etc. IN range is semantically very different from a simple comparison of low and high. Since programming should be a specific as possible to avoid unwanted side effects, it's not a good idea to add a generalisation such as a range, when a simple between test is what is required. If you've ever programmed in HR or used time-dependent infoobjects in BW, you'll frequently use BEGDA and ENDDA. To use a range to see if something lies between begda and endda would not be sensible.

On that basis I say your advice is not good.

Furthermore replacing the between with a range could end up with him programming by coincidence if he doesn't understand why the code is failing the first place.

On your second point concerning OR (which I've not commented on so far), unless I've entirely misunderstood, you're simply wrong. The OP gave us these values:

lv_flstr -> 85
lv_low -> 80
lv_high -> 100

DATA(lv_flstr) = 85.
DATA(lv_low) = 80.
DATA(lv_high) = 100.

IF lv_flstr GE lv_low AND lv_flstr LE lv_high.
  WRITE / 'In between'.
ELSE.
  WRITE / 'Not in between'.
ENDIF.

Is 85 greater than or equal to 80. True
Is 85 less than or equal to 100. True.

Output "In between".

You propose

If lv_flstr GE lv_low OR lv_flstr LE lv_high.

Consider lv_low = 80 and lv_high = 100. The following values of lv_flstr will give this clause as true.
75, 80, 105.
Which is probably not what he wants.

Re: IF statement Execution Error

matt — Fri, 25 Jan 2019 09:52:21 GMT

anurag.singh16 The value of the IF is true. But only if you've got your typing right.

"If you still can't figure out the issue from that, then comment on this answer with the values of these variables, and their defined types."

If the types are numeric, then another possibility is that the program/include isn't activated,and the runtime is not the same version as what you see in the editor.

Re: IF statement Execution Error

matt — Fri, 25 Jan 2019 10:16:06 GMT

This is where my thoughts are going.

Re: IF statement Execution Error

anurag_singh16 — Fri, 25 Jan 2019 10:23:21 GMT

Hello Guys,

Thank you all. And please don't take it as argument. We are helping each other to clear the doubts and there can be a bit of difference in opinions and approach towards problem.

So, let's take it lightly and chill. 🙂 🙂

I cracked it now.

I commented the original statement and split the condition into 2 parts as below.

It is working fine now.

But the question is why was it not working earlier only from past 24 hours. Before yesterday that query was working absolutely fine and accordingly.

Regards,
Anurag

Re: IF statement Execution Error

anurag_singh16 — Fri, 25 Jan 2019 10:27:54 GMT

Hi Sandra,

May be you are right.

But I got this error last evening reported by Client. Then I checked into my system late night and found this again.

Then I came office and checked again in the morning, found the same error in both, Dev and Quality System. So, that possibility is eliminated for now in my case.

Thanks,
Anurag

Re: IF statement Execution Error

matt — Fri, 25 Jan 2019 11:16:58 GMT

IF lv_flstr GE lv_low AND lv_flstr LE lv_high.

is logically identical to

IF lv_flstr GE lv_low.
  IF lv_flstr LE lv_high.

There is absolutely no way that the first doesn't work and the second does, unless you have not given us accurate and complete information. I'd suggest that either you're testing with different data (you still haven't told us the types of the three variables), or you're not showing us the actual code (this happens, it's easy to do).

I'm now rather worried for you. About two things.

1) You posted originally.

IF lv_flstr GE lv_low AND lv_flstr LE lv_high.
  READ ...
  IF sy-subrc = 0.

It looks like you've replaced that with

IF lv_flstr GE lv_low.
  IF lv_flstr LE lv_high.
    IF sy-subrc = 0.

Where's the READ gone?

2) You say you've cracked it, and it's working fine. But that's only half the story. You (and us) still don't understand why it wasn't working before. If don't get that understanding, then you are programming by coincidence, which, if you follow the link I post earlier, you should understand is a very dangerous thing to do.

Re: IF statement Execution Error

Sandra_Rossi — Fri, 25 Jan 2019 12:38:18 GMT

I agree 100% with Matthew

Re: IF statement Execution Error

anurag_singh16 — Fri, 25 Jan 2019 14:24:23 GMT

Hi Matthew,

Me and my functional both sat together and checked in debugging mode. It worked then, but now again it's creating the problem.

I'll share the details.

Now, the problem is coming at below condition:

1.   IF lv_flstr GE lv_low.   "This was working fine this time around 2 hours back
         IF lv_flstr LE lv_high.  "This was working fine this time around 2 hours back



2.   IF lv_flstr GE lv_low.   "This is working fine now also
         IF lv_flstr LE lv_high.  "But this is creating same problem again i.e., exiting out of code block

Regarding Data Types of all variables in condition statement:

1. lv_flstr  -> char15  
2. lv_low    -> char5
3. lv_high   -> char5
4. lv_flstr1 -> char5

I am fetching 'lv_flstr' after splitting a variable by '-' into lv_low and lv_high.
Earlier lv_flstr was used in condition, then I moved lv_flstr to lv_flstr1 and replaced lv_flstr with lv_flstr1 in  condition.

I guess the problem is from the beginning and data type has to be corrected for all.

Let me know if any further details required.

Regards,
Anurag