topic Re: loop on internal table in Application Development and Automation Discussions

loop on internal table

Former Member — Tue, 23 Jan 2007 14:15:45 GMT

Hi ,

I have two internal tables. T_FINAL and T_ITAB.

for each record in T_FINAL there are more than one record in T_ITAB.

OBJNR is the common field.

I have to duplicate the entries in T_FINAL table wrt corresponding entries in T_ITAB based on OBJNR.

Tables are pretty big. How do i go about doing this with optimized results.

Thanks,

amit

Re: loop on internal table

Former Member — Tue, 23 Jan 2007 14:18:39 GMT

Hi,

I hope following code will solve your problem.

LOOP AT t_itab.

READ TABLE t_final WITH KEY objnr = t_itab-objnr.

IF sy-subrc = 0.

...

....

ENDIF.

ENDLOOP.

Reward points if the answer is helpful.

Regards,

Mukul

Re: loop on internal table

Former Member — Tue, 23 Jan 2007 14:19:18 GMT

we have to use nested loops only i guess for this

loop at t_final.
 loop at t_itab where objnr eq t_final-objnr.
  move-corresponding t_itab to t_final.
  append t_final.
  clear t_final.
 endloop.
endloop.

Re: loop on internal table

Former Member — Tue, 23 Jan 2007 14:21:17 GMT

This is taken fro SE30 hints and tips.

I = 1.

LOOP AT ITAB1 INTO WA1.

LOOP AT ITAB2 INTO WA2 FROM I.

IF WA2-K <> WA1-K.

I = SY-TABIX.

EXIT.

ENDIF.

" ...

ENDLOOP.

It is the best way to run a nested loop. If you are going to use the read statement, also use the BINARY SEARCH command otherwise it will run slow, especially as you mentioned that there are many entries in the table.

Re: loop on internal table

Former Member — Tue, 23 Jan 2007 14:26:36 GMT

thanks chandra.

what if objnr is blank in t_final ... i will miss that record ?

Re: loop on internal table

Former Member — Tue, 23 Jan 2007 14:26:39 GMT

loop at t_itab .

loop at t_final where objnr = t_itab-objnr .

endloop.

endloop .

If you can change you logic while filling internal table some different logic can also be applied which would be more efficiant .

Re: loop on internal table

Former Member — Tue, 23 Jan 2007 14:36:10 GMT

If you use this code: -

loop at t_final.

loop at t_itab where objnr eq t_final-objnr.

move-corresponding t_itab to t_final.

append t_final.

clear t_final.

endloop.

It will run very slowly. Beleive me I know, I had the same problem. For every record in t_final, it will start reading every record in t_itab. So if you have 10000 records in t_final, it will read all of the records in t_itab 10000 times. If there are 10000 records in t_itab, the number of records read will be 10000 * 10000.

If u use the method I have mentioned, you will not have this problem. The index is stored when reading the table t_itab. Therefore the same record is never read more than once.

If you do not use this method, then do not put another posting on here moaning about the performance of the nested loop.

Re: loop on internal table

Former Member — Tue, 23 Jan 2007 14:54:15 GMT

Check this:

/people/rob.burbank/blog/2006/02/07/performance-of-nested-loops

Rob