topic Re: problem with FETCH NEXT CURSOR in Application Development and Automation Discussions

problem with FETCH NEXT CURSOR

Former Member — Mon, 03 Dec 2018 14:36:14 GMT

Hi expert,
could someone tell me why the below FETCH NEXT CURSOR keep getting the data from the database table although it has just 400000 records?
the statement keep going till I receive a dump with

no more storage space available for extending an internal table

OPEN CURSOR WITH HOLD lv_cursor FOR 
SELECT artkl_id FROM ZZ_artk.
DO. 
CLEAR lt_artk . 
FETCH NEXT CURSOR lv_cursor INTO CORRESPONDING FIELDS OF TABLE lt_artkl_data PACKAGE 
SIZE 10000. 
APPEND LINES OF lt_artk_data TO lt_artk_all.
IF sy-subrc <> 0 . 
CLOSE CURSOR lv_cursor_artkl_id.
EXIT.
ENDIF.
ENDDO.

Best regards

Jenie

Re: problem with FETCH NEXT CURSOR

Tomas_Buryanek — Mon, 03 Dec 2018 15:04:46 GMT

You should check sy-subrc after FETCH. Not after APPEND command.

Re: problem with FETCH NEXT CURSOR

Former Member — Mon, 03 Dec 2018 17:39:10 GMT

I did this but in vain the problem is that sy-subrc is is always = 0, in this case the data will be called again and again

Re: problem with FETCH NEXT CURSOR

Sandra_Rossi — Mon, 03 Dec 2018 18:35:31 GMT

The interest of using FETCH is to keep in memory a limited number of lines, not the whole table. So why do you append all the lines to an internal table? (your code is exactly like doing SELECT artkl_id FROM zz_artkl INTO TABLE lt_artk_all).

Re: problem with FETCH NEXT CURSOR

Sandra_Rossi — Mon, 03 Dec 2018 18:39:05 GMT

jennifer1988 it is just illogical to do it your way (and sometimes dangerous, hopefully APPEND does not alter SY-SUBRC). Instead, write it like this, it's just more logical:

FETCH NEXT CURSOR lv_cursor INTO CORRESPONDING FIELDS OF TABLE lt_artkl_data 
       PACKAGE SIZE 10000.
IF sy-subrc <> 0 . 
CLOSE CURSOR lv_cursor_artkl_id.
EXIT.
ENDIF.
APPEND LINES OF lt_artk_data TO lt_artk_all.

Re: problem with FETCH NEXT CURSOR

Sandra_Rossi — Mon, 03 Dec 2018 18:40:59 GMT

In your short dump, you should see the number of lines of the internal table, the memory used, etc. If needed, use the debugger to list the data objects sorted by the amount of memory used.

Re: problem with FETCH NEXT CURSOR

DoanManhQuynh — Tue, 04 Dec 2018 01:31:40 GMT

jennifer1988 : if it keep going mean it still fetchable, its very clear in F1 help about that.

Re: problem with FETCH NEXT CURSOR

Former Member — Tue, 04 Dec 2018 08:38:12 GMT

Hi Sandra,

I am using append just to control and stand on how many records has been called and this appended Table will not be used further...

Re: problem with FETCH NEXT CURSOR

matt — Tue, 04 Dec 2018 09:31:13 GMT

If you run in debug you should be able to solve by yourself.

Re: problem with FETCH NEXT CURSOR

Sandra_Rossi — Tue, 04 Dec 2018 15:06:20 GMT

jennifer1988 you ran into a memory problem, so 400.000 lines was too much in your situation, so either you troubleshoot the memory problem which is not related to your ABAP code (cf my other answer), or you reduce the memory consumption and you don't load all the lines of the table (if it's just to count the lines, then just use SELECT COUNT( * )).