topic Re: Performance Issue in Application Development and Automation Discussions

Performance Issue

Former Member — Fri, 03 Nov 2006 04:37:03 GMT

Hi All,

I have a doubt. iam looping at one internal table and in that loop iam reading the other internal table with key and if sy-subrc <> 0 , iam deleting the record from looped table. So my question is will there be any performance issue. Is it good practice ???. One of my senior told that instead of deleting a record to create a internal table and take only those entries which are success.

Please let me know which is the best way.

Also please send me if any one of you have material regarding the performance tuning or good coding standards.

Regards,

Kiran I

Re: Performance Issue

gopi_narendra — Fri, 03 Nov 2006 04:53:09 GMT

Hi krian,

instead of deleting inside the loop u can mark a flg for the record whichu wnt to delte and then delete them after the loop.

Chekc this link

http://www.erpgenie.com/sap/abap/performance.htm

Regards

- Gopi

Re: Performance Issue

Former Member — Fri, 03 Nov 2006 05:26:24 GMT

Hi Gopi,

Will there be any issue if i delete inside loop.

Also insted af deleting can i insert the other records into an other internal table.

Reagrds,

Kiran I

Re: Performance Issue

gopi_narendra — Fri, 03 Nov 2006 05:29:19 GMT

Hi again...

you can delete the records inside the loop if u r not triggering any data base Ztable. if it is internal table i dont think is a problem.

Yes u can even insert the othre records into another internal table using the move and append statements.

Regards

- Gopi

Re: Performance Issue

Former Member — Fri, 03 Nov 2006 05:41:24 GMT

thats rite. it's NOT a good practice to delete records from internal table inside the loop, especially when there is large number of records. instead i will suggest you to the following.

let say you have two internal tables ITAB1 AND ITAB2. now you are looping ITAB1 and reading records from ITAB2 according to some key fields from ITAB1 and if SY-SUBRC <> 0, then you are deleting records from ITAB1. so all you got to do is:

declare field symbol with an identical structure of IATB1.

FIELD-SYMBOLS <FS_ITAB1> TYPE TY_ITAB1.

LOOP AT ITAB1 ASSIGNING <FS_ITAB1>.

READ TABLE ITAB2 TRANSPORTING NO FIELDS

WITH KEY FLD1 = <FS_ITAB1>-FLD1

FLD2 = <FS_ITAB1>-FLD2....

BINARY SEARCH.

**DECLARE YOUR INTERNAL TABLES AS SORTED TABLES**

IF sy-subrc <> 0.

<FS_ITAB1>-flag = 'X'.

**HAVE ONE ADDITIONAL FIELD AS FLAG**

ENDIF.

ENDLOOP.

DELETE ITAB1 WHERE FLAG = 'X'.

this is quite fruitful when original performance is concerned.

shane

Re: Performance Issue

Former Member — Fri, 03 Nov 2006 06:07:53 GMT

Hi Kiran,

what your seniour told is correct insted of deleting that record in the loop before that you delete those records which is unnecessory get the sucess records and read that internal table. iam sending one sample code please go through this. Can i have your email id so that i can send u the code.

Thanks

Vikranth Khimavath

Re: Performance Issue

Former Member — Fri, 03 Nov 2006 16:36:48 GMT

Kiran,

Check the below link for my post in that link.

It just reiterates what the others replied. Just has additional info as to why.

Regards,

-Ramesh

Re: Performance Issue

Former Member — Tue, 07 Nov 2006 04:58:26 GMT

Hi Vikranth,

Sorry for late reply. My Mail id is immadisettygkk@yahoo.com. Please also send me any material on perfomance techniques.

Thanks & Regards,

Kiran I

Re: Performance Issue

anversha_s — Tue, 07 Nov 2006 05:10:10 GMT

hi kiran,

kindly chk ur mail.

I send a hands on note of mine.

It might be helpful for u.

regards

Anver

if helped pls mark points

Re: Performance Issue

anversha_s — Tue, 07 Nov 2006 06:57:29 GMT

Hi kiran,

kindly chk ur mail.

I send u one excellent OOPS doc.

If helped pls mark points.

Regards

Anver