topic Re: issues in Application Development and Automation Discussions

issues

Former Member — Mon, 11 Sep 2006 08:36:08 GMT

What is the best way to fix this loop performance wise?

loop at i_vbak.

loop at i_vbap where vbeln = i_vbak-vbeln.

loop at i_vbep where vbeln = i_vbep-vbeln.

xxxxxxxx

endloop.

and also .... do you see any errors/performance issues with these statements. Please donot take "select" query in to consideration. of course "sort i_vbak" is one that needs to be considered i guess

select * into i_vbak.

read table i_vbak where vbeln = 'xxx'

posnr = 'yyy'

vkorg = 'zzz'

binary search.

Thanks in advance. Enjoy! your weekends.

Mary

Re: issues

Former Member — Mon, 11 Sep 2006 08:37:54 GMT

loop at i_vbak.

*loop at i_vbap where vbeln = i_vbak-vbeln.

read table i_vbap with key vbeln = i_vbak-vbeln.

loop at i_vbep where vbeln = i_vbep-vbeln.--->wrong what is use of that.

xxxxxxxx

endloop.

*endloop.

it is better that u just send ur requirment.

we will try to code that.

Re: issues

Former Member — Mon, 11 Sep 2006 08:40:33 GMT

First of all nested loop is not good..we should always try and avoid it. As for your required since you dont want to use SELECT..is to surely sort the internal tables.

sort i_vbak.

sort i_vbap.

sort i_vbep.

loop at i_vbak.

clear i_vbap.

loop at i_vbap where vbeln = i_vbak-vbeln.

clear i_vbep.

read table i_vbep with key vbeln = i_vbap-vbeln

and posnr = i_vbap-posnr.

if sy-subrc = 0.

endif.

endloop.

--Try the above logic..

Regards

Anurag

--Please try an avoid opening the same issue in multiple threads ..Cheers !!

Re: issues

Former Member — Mon, 11 Sep 2006 08:44:40 GMT

good

loop at i_vbak. -Correct

loop at i_vbap where vbeln = i_vbak-vbeln.-Correct

loop at i_vbep where vbeln = i_vbep-vbeln.-Correct

xxxxxxxx

endloop.

wrong->

select * into i_vbak.

read table i_vbak where vbeln = 'xxx'-Correct

posnr = 'yyy'

vkorg = 'zzz'

binary search.

right->

select * from tablename into i_vbak .

thanks

mrutyun^

Re: issues

Former Member — Mon, 11 Sep 2006 09:01:37 GMT

Hello,

Avoid using nested loops wherever possible. Chk out the'read' statement/keyword.

Regards,

Shehryar