topic Re: Initial Structure in Application Development and Automation Discussions

Initial Structure

Former Member — Tue, 19 Jun 2018 09:11:25 GMT

Hi all,

Can anyone please tell me what this particular line of code does in this program?

Tables TCURT.

DATA: CURR_TAB TYPE TABLE OF TCURT.
................
................
SELECT * FROM TCURT INTO TABLE CURR_TAB 
 WHERE ....

LOOP AT CURR_tAB INTO TCURT.
WRITE: /5 SY-TABIX, TCURT-WAERS,TCURT-LTEXT.
ENDLOOP.

TCURT = SPACE. "initial structure TCURT.
TCURT-WAERS = 'IJK'.
TCURT-LTEXT = 'DUMMY CURRENCY'.

INSERT TCURT INTO CURR_TAB INDEX REC_NO.

Now in the above program my doubt is with this line -

TCURT = SPACE. "initial structure TCURT.

What does this line do? And in the comment beside it is written "initial structure TCURT" !

Can anyone please tell me what it's use / purpose?

With Warm Regards,

Namrata

Re: Initial Structure

matt — Tue, 19 Jun 2018 09:32:20 GMT

Why not run the program in debug and find out what the statement does?

Also, be aware that TABLES is an obsolete keyword and should not be used in new programs.

Re: Initial Structure

retired_member — Tue, 19 Jun 2018 09:33:27 GMT

https://help.sap.com/http.svc/rc/abapdocu_752_index_htm/7.52/en-US/index.htm?file=abenconversion_flat-elementary.htm

Of course, CLEAR tcurt would be better and working with TABLES should be avoided at all.

Re: Initial Structure

Former Member — Tue, 19 Jun 2018 09:47:53 GMT

Sir,

Thank you very much for the reply.

But it will be kind of you if you please tell me what is SPACE doing here ? I mean can you plz explain in a little details why TCURT is given the value 'space" instead of just avoiding it and directly inserting the values like

LOOP AT CURR_tAB INTO TCURT.
WRITE: /5 SY-TABIX, TCURT-WAERS,TCURT-LTEXT.
ENDLOOP.
"and completely avoiding the line TCURT = SPACE.
TCURT-WAERS ='IJK'.
TCURT-LTEXT ='DUMMY CURRENCY'.

Regards,

Namrata

Re: Initial Structure

retired_member — Tue, 19 Jun 2018 09:58:07 GMT

I can't explain to you the bad programming style of someone else.

One has to ask the author of the program why he/she does not simply use CLEAR.

What's happening in that line, you can learn from the documentation (the structure is filled up with blanks).

Re: Initial Structure

arpan_shukla — Tue, 19 Jun 2018 10:04:57 GMT

Dear Namrata,

It is always considered as a good coding practice to initialize the structure (or variable) before using it and that is the purpose of this line of code. However as suggested by Horst, it would have been better if CLEAR statement was used instead of passing SPACE.

Please let me know if you need any further clarificaiton on this.

Best Regards,

Arpan Shukla

Re: Initial Structure

Former Member — Tue, 19 Jun 2018 10:53:14 GMT

Hi Arpan,

Thanks for the reply.

Re: Initial Structure

Former Member — Tue, 19 Jun 2018 12:45:02 GMT

Hi Mathew and Horst,

Ok I got it. So do you think using "Data " keyword will be better to define a structured object like this below-

DATA: TCURT type TCURT

Will be better?

Re: Initial Structure

matt — Tue, 19 Jun 2018 14:15:47 GMT

Yes. It's better. But it's still bad. Why not give it a meaningful name, like line_of_tcurt or tcurt_record or currency_code_name_record