topic Re: is this code correct - logic wise and performance wise in Application Development and Automation Discussions

is this code correct - logic wise and performance wise

Former Member — Thu, 27 Jul 2006 20:16:08 GMT

Hello,

scenario: iterating through bkpf to get all the document within a selected range of dates and document type 'KZ' . Then iterating through bseg(where belnr = belnr of the retrieved records from bkpf). Then looping through the selected bseg records and picking out the line items. In this loop i have to display the vendor line item's WRBTR(KOART = 'K') and other line item's WRBTR.

The code is sumthing lyke:

select * from bkpf into t_bkpf where document type ='KZ' and bldat in s_bldat.

select single * from bseg into wa_bseg where belnr = t_bkpf-belnr.

append wa_bseg to t_bseg.

endselect.

loop at t_bseg into wa_bseg.

at new belnr.

// is this following also correct or wrong

if KOART EQ 'K'.

// pick up vendor's WRBTR

ELSE

// pick up other line item's WRBTR ( how ?? )

endif.

endat.

endloop.

I know this will comsume yur time, but if anyone is kind enuf to help me out or guide me through.

Thanks,

Shehryar

Re: is this code correct - logic wise and performance wise

Former Member — Thu, 27 Jul 2006 21:01:52 GMT

There are issues with the code.

Performance can be improved for the program. Instead of select * from bkpf you can use select belnr from bkpf as

you are using only that field and instead of select,endselect and calling bseg inside it you change it as select all the belnr into an internal table and then do a for all entries query on bseg.

at new belnr.

// is this following also correct or wrong

if KOART EQ 'K'.

// pick up vendor's WRBTR

ELSE

// pick up other line item's WRBTR ( how ?? )

endif.

endat.

This code will not work becuase when you do a at new belnr

the remaining all the fields in the work are will have ***

instead you can write it like this .

DATA : v_flag type c.

loop at t_bseg into wa_bseg.

at new belnr.

v_flag = 'X'.

endat.

if v_flag eq 'X'.

if wa_bseg-KOART EQ 'K'.

//Your logic

ELSE.

//Your logic

ENDIF.

clear v_flag.

endif.

endloop.

Re: is this code correct - logic wise and performance wise

Former Member — Fri, 28 Jul 2006 07:19:03 GMT

Thank Sudir.

refreshing the thread to get more view on this.

Re: is this code correct - logic wise and performance wise

Former Member — Fri, 28 Jul 2006 07:25:38 GMT

1. BKPF will generally have a lot of entries, its better if you can make use of any of the secondary indexes.

One of the index is combination of fields

BUKRS, BSTAT, BUDAT. So if you can populate some values to BUKRS and BSTAT then your select can improve a lot.

2. I wouldnt suggest:

SELECT BKPF

SELECT BSEG.

ENDSELECT.

instead:

SELECT BKPF into <interal table1>

SELECT BSEG into <internal table2> for all entries in BKPF where <all the common fields>.

Re: is this code correct - logic wise and performance wise

Former Member — Fri, 28 Jul 2006 07:54:33 GMT

Hello.

Sharath, what abt the 'loop at' and 'at new' logic ?

Re: is this code correct - logic wise and performance wise

aris_hidalgo — Fri, 28 Jul 2006 07:59:17 GMT

Hi,

If there are existing secondary indices for BKPF, use that. Also, try to avoid select * since it will consume more time. Its much better to specify the fields explicitly. In your loop, you can use field-symbols to improve performance. Please look at the code below:

LOOP AT it_equz ASSIGNING <fs_equz>.

get functional location and put in it_finaltab

READ TABLE it_iloa WITH TABLE KEY iloan = <fs_equz>-iloan

INTO wa_iloa.

IF sy-subrc = 0.

wa_finaltab-funcloc = wa_iloa-tplnr.

ENDIF.

if value is present in s_anln1, continue.

IF s_anln1[] IS INITIAL.

--~~-FOR RECORDS IN IT_EQUZ WITH A VALUE IN HEQUI~~---

IF NOT <fs_equz>-hequi IS INITIAL.

v_flag = 1.

check whether current hequi has already been processed

READ TABLE it_equz_dum WITH TABLE KEY hequi = <fs_equz>-hequi

INTO wa_equz_dum.

if not found, continue processing

IF sy-subrc <> 0.

wa_equz_dum = <fs_equz>-hequi.

INSERT wa_equz_dum INTO TABLE it_equz_dum.

CALL METHOD me->get_asset

EXPORTING equip_num = <fs_equz>-hequi

IMPORTING check = lv_check.

IF lv_check <> 'N'.

wa_finaltab-asset_dum = iloa-anlnr.

wa_finaltab-asset = iloa-anlnr.

wa_finaltab-description = eqkt-eqktx.

check whether current asset exists in ANLA

SELECT SINGLE anln1 anln2 ord42

FROM anla

INTO (wa_anla-anln1, wa_anla-anln2, wa_anla-ord42)

WHERE anln1 EQ wa_finaltab-asset

AND bukrs IN r_iwerk

AND deakt EQ '00000000'.

if not found, delete current record. Else, continue

IF sy-subrc = 0.

wa_finaltab-asset_sub = wa_anla-ord42.

CONCATENATE: wa_anla-anln1 '-' wa_anla-anln2

INTO wa_finaltab-asset_subnum.

ELSE.

DELETE it_equz WHERE equnr = <fs_equz>-equnr.

CLEAR: v_flag, wa_finaltab.

CONTINUE.

ENDIF.

READ TABLE it_t499s WITH TABLE KEY werks = wa_iloa-swerk

stand = wa_iloa-stort

INTO wa_t499s.

IF sy-subrc = 0.

wa_finaltab-location = wa_t499s-ktext.

ENDIF.

get records from ANLC based from current asset

SELECT gjahr kansw knafa kaafa answl nafav

nafag nafal aafav aafag nafap aafap

FROM anlc UP TO 1 ROWS

INTO (wa_anlc-gjahr, wa_anlc-kansw, wa_anlc-knafa,

wa_anlc-kaafa, wa_anlc-answl, wa_anlc-nafav,

wa_anlc-nafag, wa_anlc-nafal, wa_anlc-aafav,

wa_anlc-aafag, wa_anlc-nafap, wa_anlc-aafap)

WHERE anln1 = wa_anla-anln1

AND anln2 = wa_anla-anln2

AND bukrs IN r_iwerk

AND afabe = '01'

ORDER BY gjahr DESCENDING.

ENDSELECT.

wa_finaltab-accq_cost = wa_anlc-kansw + wa_anlc-answl.

IF p_posdep = 'X'.

wa_finaltab-acc_dep = wa_anlc-knafa +

wa_anlc-nafav +

wa_anlc-nafag +

wa_anlc-kaafa +

wa_anlc-aafav +

wa_anlc-aafag +

wa_anlc-nafal.

ELSE.

wa_finaltab-acc_dep = wa_anlc-knafa +

wa_anlc-nafav +

wa_anlc-kaafa +

wa_anlc-aafav +

wa_anlc-nafap +

wa_anlc-aafap.

ENDIF.

wa_finaltab-asset_book_val = wa_finaltab-accq_cost +

wa_finaltab-acc_dep.

ELSE.

lv_check = 'Y'.

ENDIF.

APPEND wa_finaltab TO it_finaltab.

CLEAR: wa_finaltab, wa_anla, wa_anlc, wa_iloa, eqkt, equz.

ENDIF.

Hope this helps...

P.S. Please award points for useful answers.

Re: is this code correct - logic wise and performance wise

Former Member — Fri, 28 Jul 2006 08:26:25 GMT

I think you can even use the below to simplify the code and efficient.

SELECT {list of fields required in your report from BKPF and BSEG}

INTO ITAB.

FROM BKPF AS A INNER JOIN BSEG AS B

ON A_{BUKRS = B}BUKRS AND

A_{BELNR = B}BELNR AND

A_{GJAHR = B}GJAHR

WHERE A_{BLART = 'KZ' AND A}BLDAT IN S_BLDAT.

U would need to initialise a variable for KOART as it would starred(*) during the AT NEW EVENT.

LOOP AT ITAB.

l_koart = itab-koart.

at new belnr.

if L_KOART EQ 'K'.

// pick up vendor's WRBTR

ELSE

// pick up other line item's WRBTR ( how ?? )

endif.

endat.

ENDLOOP.

Regards

Anurag

Re: is this code correct - logic wise and performance wise

Former Member — Fri, 28 Jul 2006 10:40:43 GMT

Hello,

Sharath, can u demonstrate how to achieve the following(u told) with a example.

SELECT BKPF into <interal table1>

SELECT BSEG into <internal table2> for all entries in BKPF where <all the common fields>.

what will be types n all..

Thanks..

Re: is this code correct - logic wise and performance wise

Former Member — Fri, 28 Jul 2006 11:22:48 GMT

Hi Anurag,

I aint getting anything when i give the condition for KOART = 'K'.

LOOP AT ITAB.

l_koart = itab-koart.

at new belnr.

if L_KOART EQ 'K'.

// pick up vendor's WRBTR

ELSE

// pick up other line item's WRBTR ( how ?? )

endif.

endat.

ENDLOOP.

why and how ?

Re: is this code correct - logic wise and performance wise

Former Member — Fri, 28 Jul 2006 12:26:19 GMT

refreshing thread. can someone query the above problem ?

thanking in anticipation.

Shehryar Dahar

Re: is this code correct - logic wise and performance wise

Former Member — Fri, 28 Jul 2006 14:32:44 GMT

Please check couple of things..first you have selected the B~koart field in the select. Secondly, you have defined ITAB with header.

If yes, to above questions than pls paste you code and I can check it.

Regards

Anurag

Re: is this code correct - logic wise and performance wise

Former Member — Fri, 28 Jul 2006 20:27:59 GMT

Hi Anurag,

the code is.

elect * from bkpf into t_bkpf where document type ='KZ' and bldat in s_bldat.

select single * from bseg into wa_bseg where belnr = t_bkpf-belnr.

append wa_bseg to t_bseg.

endselect.

loop at t_bseg into wa_bseg.

at new belnr.

// is this following also correct or wrong

if KOART EQ 'K'.

// pick up vendor's WRBTR

ELSE

// pick up other line item's WRBTR ( how ?? )

endif.

endat.

endloop.

basically what i wanna do is, iterate through bkpf whose bldat lies in the selected range and document type = 'KZ' , then iterate thru bseg for all entries(retrieved from bkpf). then loop thru these items(from bseg) and select vendor line item and other line items separately(cuz i have to show them in different columns).

but when i do,

AT NEW BELNR.

IF bseg-KOART EQ 'K'.

ENDIF.

ENDAT.

i am getting no value, whereas i get value when i remove the 'AT NEW BELNR' condition.

Thanks,

Shehryar Dahar

Re: is this code correct - logic wise and performance wise

Former Member — Mon, 31 Jul 2006 08:13:13 GMT

Hello Shehryar,

I would still advice you to use the SELECT statement with join. U can check the run time analysis or SQL Trace to understand which is efficient (My bet would be on the below as it is usually better to use one statement than nesting of loops.

SELECT {list of fields required in your report from BKPF and BSEG}

INTO T_BSEG.

FROM BKPF AS A INNER JOIN BSEG AS B

ON A_{BUKRS = B}BUKRS AND

A_{BELNR = B}BELNR AND

A_{GJAHR = B}GJAHR

WHERE A_{BLART = 'KZ' AND A}BLDAT IN S_BLDAT.

Ok as far as the Loop condition is concerned, it should as follows ...

loop at t_bseg into wa_bseg.

L_KOART = WA_BSEG-KOART.

at new belnr.

// is this following also correct or wrong

if L_KOART EQ 'K'.

// pick up vendor's WRBTR

ELSE

// pick up other line item's WRBTR ( how ?? )

endif.

endat.

endloop.

I feel the reason you are not able to see the value is due to the fact that KOART gets started out on AT NEW event and also you can use BSEG-KOART since you are looping the T_BSEG internal table(while BSEG-KOART would be indicating the last record value)

Regards

Anurag