topic Re: is this code correct ? in Application Development and Automation Discussions

is this code correct ?

Former Member — Tue, 08 Aug 2006 15:45:00 GMT

hello,

is this performance wise correct,



LOOP BSEG INTO WA.

  AT NEW BUZEI.

   SELECT SINGLE * FROM TABLE INTO VARIABLE WHERE ....

   SELECT SINGLE * FROM TABLE INTO VARIABLE WHERE ....

   SELECT SINGLE * FROM TABLE INTO VARIABLE WHERE ....
 
   WRITE:/ value, wa-value.

  ENDAT.

ENDLOOP.

Message was edited by: shehryar dahar

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 15:46:43 GMT

hi Dahar,

Use read table statement before select single statement ...

Regards,

Santosh

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 15:46:43 GMT

hi the code should be like this:: and in where condition which fields you are using... if these fileds after buzei in internaltable then u have to use Read statement.

AT NEW table-BUZEI.

read table itab with key buzei = some value.

SELECT SINGLE * FROM TABLE INTO VARIABLE WHERE ....

WRITE:/ value.

ENDAT.

Message was edited by: Ashok Parupalli

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 15:47:07 GMT

hi shehryar,

use READ stmts..

check if u have sorted the table...

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 15:47:09 GMT

Well, first off, if you are selecting * you need to select into a table structure; or

Select Single Fieldname From Table Into Variable Where

Re: is this code correct ?

suresh_datti — Tue, 08 Aug 2006 15:47:23 GMT

Unless unaviodable it is preferable not to use SELECTs inside a loop.. you would be better off dumping the required data into itabs & reading them inside the loop instead.

~ Suresh

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 15:48:14 GMT

Santosh, can u demonstrate with an example,

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 15:48:36 GMT

Hi,

Avoid using selects within a loop.

it affects ur performance.

regards,

keerthi.

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 15:49:11 GMT

hi,

here is an example of that..

    READ TABLE it_owners WITH KEY ba_ba_no  =  it_detail-own_no
                                 ba_seq_no =  it_detail-own_seq_no.

also make sure that your internal table in whicb you are collecting have in an order as they are in DB table ...

Please close all your previous threads even this once if it answered by marking all the helpful answers...

Regards,

Santosh

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 15:50:41 GMT

NOt correct.

Get the selects outside the loop and use for all entries instead.

inside the loop, you have to use read statements

SELECT * FROM TABLE INTO table it_table1

for all entries in it_bseg

WHERE

ERE ....

> LOOP at it_BSEG INTO WA.

> AT NEW BUZEI.

> read table it_table1 with key ere =

> read table it_table1 with key ere =>

> read table it_table1 with key ere =

> WRITE:/ value, wa-value.

> ENDAT.

> ENDLOOP.

Regards,

Ravi

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 15:50:55 GMT

hello,

priya.. yes, i have sorted the bseg with belnr and koart.

suresh.. can you demonstrate with an example ?

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 15:51:54 GMT

Performance cannot be measured like this. You have to give the exact code. If your table is a small table and you are hitting an index all the time, then I don't see why it will be a problem. But if your table has a lot of data and your WHERE clause is resulting in a sequential search, then yes, performance will be hit badly.

Please give us the exact code, without which this discussion will be with a lot suppositions.

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 15:53:41 GMT

Hi Ravi,

but i have to read from different tables inside the ' AT NEW BUZEI' ?

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 15:59:57 GMT

hi use

Read table xyz with some key value...

thanks

sony

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 16:02:31 GMT

Hello Advani,

i am writing this from home. Its sumthing like this,

[code]

select * from bkpf into t_bkpf where bldat in s_bldat and blart = 'KZ'.

select * from bseg into wa_bseg where belnr = t_bkpf-belnr.

append wa_bseg into t_bseg.

endselect.

clear wa_bseg.

sort t_bseg belnr koart.

LOOP AT t_bseg into waa_bseg.

AT NEW BUZEI.

IF waa_bseg-koart EQ 'K'.

SELECT SINGLE * FROM LFA1 into t_lfa1 where lifnr = waa_bseg-lifnr.

ELSEIF waa_bseg-koart EQ 'D'.

SELECT SINGLE * FROM KNA1 into t_kna1 where kunnr = waa_bseg-kunnr.

ENDIF.

WRITE:/ t_lfa1-name1.

WRITE:/ t_kna1-name1.

WRITE:/ waa_bseg-belnr.

ENDAT.

ENDLOOP.

itz approximately the same code snippet.

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 16:04:54 GMT

Ravi,

how do i get/display values after using the READ statements. ??

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 16:16:57 GMT

Just as I thought!!. There will not be any performance issue with the LOOP itself as you are hitting the tables with the primary key. Your performance will be bad because of the select statements before that (from BKPF and BSEG). Change that. See if you can pass BUKRS to BKPF select and then change the code as follows:


DATA: BEGIN OF t_bseg OCCURS 0.
        INCLUDE STRUCTURE bseg.
DATA: END OF t_bseg.

DATA: BEGIN OF t_bkpf OCCURS 0,
        bukrs LIKE bkpf-bukrs,
        belnr LIKE bkpf-belnr,
        gjahr LIKE bkpf-gjahr,
        bldat LIKE bkpf-bldat.
DATA: END OF t_bkpf.

SELECT-OPTIONS: s_bldat FOR t_bkpf-bldat.

SELECT bukrs belnr
       gjahr bldat FROM bkpf
                   INTO TABLE t_bkpf
                  WHERE blart EQ 'KZ'.
CHECK sy-subrc = 0.
DELETE t_bkpf WHERE NOT bldat IN s_bldat.

SELECT * FROM bseg
         INTO TABLE t_bseg FOR ALL ENTRIES IN t_bkpf
        WHERE belnr = t_bkpf-belnr.

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 16:20:26 GMT

If you can add BUKRS in the WHERE clause for BKPF and BSEG selects in my previous code, it will be even more faster.

Also consider going to BSIK, BSAK and BSID and BSAD tables if you are interested only in customer and vendor accounts.

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 16:20:31 GMT

hi Santosh,

How to get the value after using the read statement and secondly i was told to use read statements instead of select single ??

Re: is this code correct ?

Former Member — Tue, 08 Aug 2006 16:23:08 GMT

Hello Adavi,

thanks for the correction. So, the 'AT NEW BUZEI' part is correct ?