topic Re: Logic is needed. in Application Development and Automation Discussions

Logic is needed.

Former Member — Fri, 25 Aug 2006 05:29:24 GMT

This is the performance issue.

Can any one change the above logic?

I don’t want the select inside the loop.

Logic is needed.

Can any one change the above logic? (mentioned in red color)

I don’t want the select inside the loop.

loop at it_vttk.

clear v_tknum.

concatenate it_vttk-tknum '%' into v_tknum.

select fknum

fkpos

exti1

netwr

from vfkp

in to table t_vfkp

where exti1 like v_tknum.

endloop.

Re: Logic is needed.

Former Member — Fri, 25 Aug 2006 05:30:08 GMT

Hi,

loop at it_vttk.

clear v_tknum.

concatenate it_vttk-tknum '%' into v_tknum.

select fknum

fkpos

exti1

netwr

from vfkp

in to table t_vfkp

where exti1 like v_tknum.

endloop.

Create varible with RANGES <SELTAB> FOR VFKP-EXTI1. This will create internal table with structure as selection table.

loop t_vfkp.

clear SELTAB.

SELTAB-SIGN = 'I'.

SELTAB-OPTION = 'CP'

concatenate it_vttk-tknum '*' into SELTAB-LOW.

append SELTAB.

endloop.

Then use SELECT statement

select fknum

fkpos

exti1

netwr

from vfkp

in to table t_vfkp

where exti1 in SELTAB.

Hope this will help you to avoid select into loop.. enloop.

Please reward helpful replies.

Regards

Sunil

Message was edited by: Sunil Sawaiker

Re: Logic is needed.

former_member186741 — Fri, 25 Aug 2006 05:34:57 GMT

the obvious answer is to use 'for all entries' but I don't hink that will help you..... these tables are not linked very well so the select will be inefficient unless you create an index on table VFKP on exti1.

Do you really need the 'LIKE' clause? Surely the VTTk has the complete value.

If I'm right then you could do

select fknum

fkpos

exti1

netwr

from vfkp

into corresponding fields of table t_vfkp

for all entries in t_vttk

where exti1 = t_vttk-exti1.

But, as I said before this could still be very slow unless an index is created on exti1.

Re: Logic is needed.

Former Member — Fri, 25 Aug 2006 05:36:38 GMT

HI,

Consider the belowsaid option and reward if helpful.

<b>data : begin of str_tknum,
       tknum(10),
       end of str_tknum.

data : it_tknum like table of str_tknum with header line.

loop at it_vttk.
concatenate it_vttk-tknum '%' into it_tknum-tknum.
append it_tknum.
clear it_tknum.
endloop.

select fknum fkpos exti1 netwr from vfkp into table t_vfkp
for all entries in it_tknum where exti1 like it_tknum-tknum.</b>

Regards

Re: Logic is needed.

kanthimathikris — Fri, 25 Aug 2006 05:39:38 GMT

Can you try this logic,

v_tknum = 'tknum%'.

select fknum

fkpos

exti1

netwr

from vfkp

into table t_vfkp

for all entries in it_vttk

where exti1 like (v_tknum).

Re: Logic is needed.

Former Member — Fri, 25 Aug 2006 05:41:28 GMT

You can try this.

You can add another field to your it_vttk. ex. tknumtxt(20).

loop at it_vttk.

concatenate it_vttk-tknum '%' into it_vttk-tknumtxt.

modify it_vttk.

endloop.

select fknum fkpos exti1 netwr

from vfkp

FOR ALL ENTRIES IN IT_VTTK

into table t_vfkp

where exti1 like IT_VTTK-TknumTXT.

Hope this helps.

Re: Logic is needed.

Former Member — Fri, 25 Aug 2006 05:41:57 GMT

Hi,

ranges: r_tknum for vttk-tknum.

loop at it_vttk.

concatenate it_vttk-tknum '*' into r_tknum-low.

r_tknum-sign = 'I'.

r_tknum-option = 'CP'.

append r_tknum.

endloop.

select fknum

fkpos

exti1

netwr

from vfkp

into table t_vfkp

where exti1 in r_tknum.

Please award if it helps...

Thanks,

Naren

Re: Logic is needed.

Former Member — Fri, 25 Aug 2006 05:42:20 GMT

try this...

REPORT YCHATEST.

DATA : BEGIN OF IT_RANGE OCCURS 0,
        SIGN(1),
        OPTION(2),
        LOW LIKE V_TKNUM,
        HIGH LIKE V_TKNUM,
       END OF IT_RANGE.

CLEAR IT_RANGE.
REFRESH IT_RANGE.

LOOP AT IT_VTTK.
  CLEAR V_TKNUM.
  CONCATENATE IT_VTTK-TKNUM '%' INTO V_TKNUM.
  IT_RANGE-SIGN = 'I'.
  IT_RANGE-OPTION = <b>'CP'</b>.
  IT_RANGE-LOW = V_TKNUM.
  IT_RANGE-HIGH = ''.
  APPEND IT_RANGE.
  CLEAR IT_RANGE.
ENDLOOP.

SELECT FKNUM
FKPOS
EXTI1
NETWR
FROM VFKP
INTO TABLE T_VFKP.
WHERE EXTI1 IN IT_RANGE..

Message was edited by: Chandrasekhar Jagarlamudi

Re: Logic is needed.

Former Member — Fri, 25 Aug 2006 05:50:06 GMT

I am unable to use the LIKE In for all entries.

Re: Logic is needed.

Former Member — Fri, 25 Aug 2006 05:51:24 GMT

Hi,

Please check my earlier reply..

Thanks,

naren

Re: Logic is needed.

Former Member — Fri, 25 Aug 2006 05:56:01 GMT

I am not able to use the LIKE Statement in the for all entries.

Re: Logic is needed.

Former Member — Fri, 25 Aug 2006 05:57:33 GMT

Hi,

You are not using like instead you will be using the ranges..

ranges: r_tknum for vttk-tknum.

loop at it_vttk.

concatenate it_vttk-tknum '*' into r_tknum-low.

r_tknum-sign = 'I'.

r_tknum-option = 'CP'.

append r_tknum.

endloop.

select fknum

fkpos

exti1

netwr

from vfkp

into table t_vfkp

where exti1 in r_tknum.

Please award if it helps...

Thanks,

Naren

Message was edited by: Narendran Muthukumaran

Re: Logic is needed.

Former Member — Fri, 25 Aug 2006 06:02:52 GMT

It goes to shortdumb

Re: Logic is needed.

Former Member — Fri, 25 Aug 2006 06:12:00 GMT

i want to clarify a small doubt from

i know that ranges similar like select options...

so when we have to use ranges..

explanation needed

can u give some situations we can use.

waiting for ur reply

Re: Logic is needed.

Former Member — Fri, 25 Aug 2006 06:24:06 GMT

Priya,

Consider the following code, reward if helpful.

DATA: tknum(18) TYPE C,

ITAB LIKE TABLE OF tknum.

PARAMETERS: p_tknum(18) TYPE C.

CONCATENATE p_tknum '%' INTO tknum.

APPEND tknum TO ITAB.

SELECT fknum fkpos exti1 netwr INTO WA FROM vfkp

WHERE (ITAB).

WRITE / WA.

ENDSELECT.

Regards

Re: Logic is needed.

Former Member — Fri, 25 Aug 2006 06:43:17 GMT

have u tried my code??

Re: Logic is needed.

Former Member — Fri, 25 Aug 2006 06:53:09 GMT

Naren/chandra/

s still it goes to shot dumb

Error in the module RSQL accessing the database interface.

help me

Re: Logic is needed.

Former Member — Fri, 25 Aug 2006 06:55:54 GMT

i had changed my code at line , have u observed that?

first i had written BT , then changed to CP

it_range-option = <b>'CP'</b>.

Message was edited by: Chandrasekhar Jagarlamudi

Re: Logic is needed.

Former Member — Fri, 25 Aug 2006 07:02:22 GMT

Chandra,

it_range-option = 'CP'.

i tried the above option also.

REPORT YCHATEST.

*data: V_TKNUM like standard table of

data: V_TKNUM(30).

data: it_vttk like standard table of vttk with header line.

data: it_vfkp like standard table of vfkp with header line.

DATA : BEGIN OF IT_RANGE OCCURS 0,

SIGN(1),

OPTION(2),

LOW LIKE V_TKNUM,

HIGH LIKE V_TKNUM,

END OF IT_RANGE.

CLEAR IT_RANGE.

REFRESH IT_RANGE.

select * from vttk into table it_vttk.

LOOP AT IT_VTTK.

CLEAR V_TKNUM.

CONCATENATE IT_VTTK-TKNUM '%' INTO V_TKNUM.

IT_RANGE-SIGN = 'I'.

IT_RANGE-OPTION = 'CP'.

IT_RANGE-LOW = V_TKNUM.

IT_RANGE-HIGH = ''.

APPEND IT_RANGE.

CLEAR IT_RANGE.

ENDLOOP.

SELECT FKNUM

FKPOS

EXTI1

NETWR

FROM VFKP

INTO TABLE IT_VFKP

WHERE EXTI1 IN IT_RANGE .

write: 's'.

Re: Logic is needed.

Former Member — Fri, 25 Aug 2006 07:05:37 GMT

Zapper,

i tried ur optios also.

again it goes for dumb.