topic Re: How to avoid nested loop? in Application Development and Automation Discussions

How to avoid nested loop?

walkerist79 — Mon, 22 May 2023 12:43:26 GMT

Here is my current situation: 
DATA: T_FCAT1 TYPE slis_fieldcat_alv,
      t_fcat TYPE kkblo_t_fieldcat.
LOOP AT T_FCAT1 INTO LX_FCAT1.
    LOOP AT LT_FCATALOG INTO LX_FCATALOG.
    IF LX_FCAT1-FIELDNAME = LX_FCATALOG-FIELDNAME.
         LX_FCAT1-COL_POS = LX_FCATALOG-COL_POS.
         APPEND LX_FCAT1 TO T_FCAT1.
         CLEAR LX_FCAT1.
    ENDIF.
    ENDLOOP.
ENDLOOP.

It is possible to eliminate the nested loop here?
My goal is to overwrite the COL_POS from LX_FCATALOG to T_FCAT1 or LX_FCAT1
but the pre-requisite is to map it into correct field.
example:

T_FCAT1 OR LX_FCAT1.
FIELDNAME   COL_POS
EBELN          0


LT_FCATALOG OR LX_FCATALOG.
FIELDNAME    COL_POS
EBELN          23 <-----I want this to overwrite to T_FCAT1 OR LX_FCAT1.

Re: How to avoid nested loop?

matt — Mon, 22 May 2023 13:16:36 GMT

Looks to me like you've an endless loop (except where there are no shared FIELDNAME between the two internal tables), since you're looping through t_fcat1 you're adding new records into it.

Re: How to avoid nested loop?

fedaros — Mon, 22 May 2023 14:27:42 GMT

Seems no need of nested loop here. You can loop once T_FCAT1 assigning field symbol, as you want modify COL_POS, read table LT_FCATALOG per field and just set <fs_fcat1>-COL_POS = ls_fcatalog-COL_POS.

BTW: You have many questions unclosed, are it really without valid answers to be closed ?

Re: How to avoid nested loop?

walkerist79 — Mon, 22 May 2023 14:40:43 GMT

@All two fieldcatalogs have different types.

Re: How to avoid nested loop?

RaymondGiuseppi — Mon, 22 May 2023 15:39:14 GMT

Try at least something such as

LOOP AT T_FCAT1 ASSIGNING <old>.
  READ TABLE T_FCATALOG WITH KEY FIELDNAME = <old>-FIELDNAME ASSIGNING <new>.     
  IF <new> IS ASSIGNED.
     <old>-COL_POS = <new>-COL_POS.
  ENDIF.
ENDLOOP.

What's your version?

Re: How to avoid nested loop?

Sandra_Rossi — Mon, 22 May 2023 15:51:36 GMT

I guess experience says there's no need to close the questions as people keep answering...

Re: How to avoid nested loop?

Ryan-Crosby — Mon, 22 May 2023 16:32:15 GMT

I stopped answering several months ago when it was obvious that the only thing that would continue was the flow of questions.