topic Re: Neater coding technique? in Application Development and Automation Discussions

Neater coding technique?

former_member201275 — Fri, 28 Jan 2022 10:21:25 GMT

Hi All,

I have the following 2 select statements to build my internal table.

This works perfectly but I am wondering if there is a better, more efficient, neater way of doing this? Maybe with just 1 select somehow.

   SELECT * FROM trdir INTO TABLE @DATA(lt_trdir)
    WHERE name LIKE 'Z%'
    AND subc = '1'
    AND cdat GT '20210101'.

  SELECT * FROM trdir APPENDING TABLE lt_trdir
    WHERE name LIKE 'Z%'
    AND subc = 'I'
    AND varcl = abap_true
    AND cdat GT '20210101'.

Re: Neater coding technique?

Jorge_Herrero_Blanco — Fri, 28 Jan 2022 10:30:57 GMT

I think this should do the same but in one select.

SELECT * FROM trdir INTO TABLE @DATA(lt_trdir)   
WHERE name LIKE 'Z%'
AND ( subc = '1' OR ( subc = 'I' and varcl = @abap_true ) )
AND cdat GT '20210101'.

Re: Neater coding technique?

Sandra_Rossi — Fri, 28 Jan 2022 11:05:36 GMT

Please use meaningful title like "how to merge these 2 select statements into 1"

Re: Neater coding technique?

Dominik_Tylczynski — Fri, 28 Jan 2022 11:06:02 GMT

Hello gemini.twin

Just join both selects with OR:

SELECT * FROM trdir INTO TABLE @DATA(lt_trdir)
WHERE
name LIKE 'Z%'
AND subc = '1'
AND cdat GT '20210101'
OR
name LIKE 'Z%'
AND subc = 'I'
AND varcl = @abap_true
AND cdat GT '20210101'.

You could of course streamline the WHERE condition. However to me it's the most clear as it is.

Best regards

Re: Neater coding technique?

former_member201275 — Fri, 28 Jan 2022 12:28:00 GMT

Thank you Dominik

Re: Neater coding technique?

former_member201275 — Fri, 28 Jan 2022 12:28:10 GMT

Thank you Jorge