topic Re: Issue with method call and Importing Itab, Returning same Itab in Application Development and Automation Discussions

Issue with method call and Importing Itab, Returning same Itab

former_member212264 — Thu, 10 Feb 2022 12:05:56 GMT

Hello, would/could give this call:

an issue?

Signature:

No clear on it_action_log in filter_and_write_action().

I was not happy with this construction, so I allready changed it, it looks like it gave issues, but not allways(could not reproduce), helpful answers will be highly appreciated!

Best regards, Robin.

Re: Issue with method call and Importing Itab, Returning same Itab

FredericGirod — Thu, 10 Feb 2022 12:33:55 GMT

Your question is not really clear.

The signature of your method is strange. IT_ACTION_LOG & RT_ACTION_LOG should have the same TYPE

Why do you not like this ?

Re: Issue with method call and Importing Itab, Returning same Itab

former_member212264 — Thu, 10 Feb 2022 13:34:57 GMT

I don't like the same internal table as import & return.

These 2 tabletypes have the same linetype.

This one(IF_GRAC_AD_TYPES):

Is generic, so not usable for Returning Value( which I do like, I dislike EXPORTING/CHANGING )

2nd Tabletype:

So, basically the 2 used table types are the same.

The issue is that et_action_log contains entries that should have been filtered out, I suspect that is due to importing (by reference) and returning value (by value ) withouthout a: "CLEAR rt_action_log."

Re: Issue with method call and Importing Itab, Returning same Itab

former_member212264 — Thu, 10 Feb 2022 13:57:24 GMT

Uuu, in the initial question:

"No clear on it_action_log in filter_and_write_action()."

should have been: No clear on rt_action_log in filter_and_write_action().

Re: Issue with method call and Importing Itab, Returning same Itab

FredericGirod — Thu, 10 Feb 2022 14:57:42 GMT

it's little bit complex to understand the signature of a method with the view based on form, if you can click on the button "...view as text".

You will see the full code like with Eclipse

If you don't want to use Importing / Returning parameters on your method, you could by-pass it using Importing a Type Ref to .. But it is not Clean Code. Because you do not manage totally the Input / Output of the method.

Re: Issue with method call and Importing Itab, Returning same Itab

former_member212264 — Thu, 10 Feb 2022 15:16:34 GMT

Hi Frederic, you misunderstand me: I don't like EXPORTING/CHANGING parameters, how can one not like IMPORTING Parameters, I Do like RETURNING VALUE parameters( there can be only one!). But that is not answering my question, that is about entries in the Target/LHS(of the returning) Itab, there are entries in there that are not supposed to be in there.

And I know that there can be multiple EXPORTING parameters(nowadays even with a Returning Param, arghh).

Best regards, Robin.