topic Re: cl_salv_table - Problem with aggregating rows in Application Development and Automation Discussions

cl_salv_table - Problem with aggregating rows

mario_maisto — Fri, 22 Jan 2021 08:24:21 GMT

Hi,

Does anyone have a solution to an issue where the row aggregation does not display when using the cl_salv_table's add_aggregation method? I do not get any type of error (e.g. "column not found") - just the totals are not shown, whereas the add_sort method (assigned with a similar style) is working properly.

When the table is displayed and I select the corresponding column of DMBTR and press the total button, the totals are shown correctly.

Here's my sample code -

* x.1 Test
 DATA: BEGIN OF ls,
 lifnr TYPE elifn,
 dmbtr TYPE dmbtr_cs,
 END OF ls,
 lt_table LIKE TABLE OF ls
 .
 SELECT lifnr, dmbtr FROM mseg 
   INTO CORRESPONDING FIELDS OF TABLE @lt_table UP TO 15 ROWS.

 cl_salv_table=>factory( IMPORTING r_salv_table = DATA(lr_result_salv)
 CHANGING t_table = lt_table ).

 lr_result_salv->get_functions( )->set_all( 'X' ).
 lr_result_salv->get_sorts( )->add_sort( columnname = 'LIFNR' subtotal = 'X' ).
 lr_result_salv->get_aggregations( )->add_aggregation( columnname = 'DMBTR' ).

 lr_result_salv->display( ).

The displayed result:

Wished result (same as pressing the 'Total' button)

Am i missing something?

Thank you for your help 🙂 !

Regards,
Mario

Re: cl_salv_table - Problem with aggregating rows

Sandra_Rossi — Fri, 22 Jan 2021 12:35:53 GMT

Your code should work fine.

What type is data element DMBTR_CS? (you should define it with TYPE MSEG-DMBTR to avoid problems)

Did you define a default layout variant that overwrites the layout defined in your code?

Re: cl_salv_table - Problem with aggregating rows

RaymondGiuseppi — Fri, 22 Jan 2021 12:52:23 GMT

sandra.rossi , check 2628654 - S4TWL: Amount Field Length Extension

Re: cl_salv_table - Problem with aggregating rows

mario_maisto — Fri, 22 Jan 2021 12:53:18 GMT

Hi Sandra, thank you for your input!

DMBTR_CS is the data element assigned for the field DMBTR in the table of MSEG (so there shouldn't be any problem with it - I just in case tried with the dmbtr type mseg-dmbtr also - no dice, same result).

The the code should work fine - every documentation and post I went through seem to say so 🙂 - yet something is missing.

For the layout - I did not define anything else seen from the sample code (nor did I changed it in the GUI). It seems weird, because the total function works when initiated from the button in GUI.

I had a problem with optimizing the columns where r_column->set_optimized( 'X' ) did not do the trick and I had to add the overall optimize for the r_columns( )->set_optimize( 'X' ) as well - maybe there's something similar missing here with the aggregations (did not find any info on it though).

Re: cl_salv_table - Problem with aggregating rows

FredericGirod — Fri, 22 Jan 2021 12:58:27 GMT

Apparently you need to make a sort to have your subtotal

https://www.sapnuts.com/courses/Object-Oriented-ABAP/alv-factory-method/alv-totals-and-subtotals.html

Re: cl_salv_table - Problem with aggregating rows

RaymondGiuseppi — Fri, 22 Jan 2021 12:59:41 GMT

Could you perform The Consistancy Check of the ALV grid?
Did you recently apply 'Amount Field Length Extension'

Re: cl_salv_table - Problem with aggregating rows

Sandra_Rossi — Fri, 22 Jan 2021 13:00:21 GMT

raymond.giuseppi I don't have this extension, so I couldn't know. So I guess that DMBTR_CS has type CURR 23 / 2.

"In SAP S/4HANA, currency amount fields with a field length between 9-22 including 2 decimals have been extended to 23 digits including 2 decimals."

mario.maisto In that case, there must be a bug in the standard code or SAP GUI, search for SAP notes. In my case, I copied your code and it works perfectly well (except that I replaced DMBTR_CS which doesn't exist in my S/4HANA).

Re: cl_salv_table - Problem with aggregating rows

mario_maisto — Fri, 22 Jan 2021 13:01:24 GMT

Frederic - but I do, with the line of (You can see the lifnr sorted on my first image 'is.png' 😞

lr_result_salv->get_sorts()->add_sort( columnname ='LIFNR' subtotal ='X').

Re: cl_salv_table - Problem with aggregating rows

mario_maisto — Fri, 22 Jan 2021 13:05:51 GMT

Sandra Rossi - so you had the same code, but with dmbtr TYPE mseg-dmbtr ? And it worked?
I'll try one more time 🙂

Re: cl_salv_table - Problem with aggregating rows

mario_maisto — Fri, 22 Jan 2021 13:12:14 GMT

Did not work.

Re: cl_salv_table - Problem with aggregating rows

mario_maisto — Fri, 22 Jan 2021 13:49:03 GMT

Did the check - have some errors.. Can this be the reason ?

Have to check.

Re: cl_salv_table - Problem with aggregating rows

FredericGirod — Fri, 22 Jan 2021 14:02:06 GMT

Maybe because MSEG-DMBTR is also based on DMBTR_CS

did you try with a "simple" dmbtr like DMBTRV ?

Re: cl_salv_table - Problem with aggregating rows

mario_maisto — Fri, 22 Jan 2021 14:06:52 GMT

Hi Frederic, Thank you for the input - I tried with the element of DMBTRV - did not work.

If the data type is wrong, shouldn't it be the same case then when pressing the 'Totals' button manually ?

Re: cl_salv_table - Problem with aggregating rows

mario_maisto — Fri, 22 Jan 2021 14:09:14 GMT

I also tried casting with no result..

SELECT lifnr, CAST( dmbtr AS DEC( 8, 2 ) ) AS dmbtr 
FROM mseg INTO CORRESPONDING FIELDS OF TABLE @lt_table UP TO 15 ROWS.

Re: cl_salv_table - Problem with aggregating rows

FredericGirod — Fri, 22 Jan 2021 14:13:56 GMT

Honestly your problem is really strange.

This code works also for me (SAP ECC 😞

SELECT lifnr, dmbtr FROM mseg
   INTO TABLE @data(lt_table) UP TO 15 ROWS.


 cl_salv_table=>factory( IMPORTING r_salv_table = DATA(lr_result_salv)
 CHANGING t_table = lt_table ).


 lr_result_salv->get_functions( )->set_all( 'X' ).
 lr_result_salv->get_sorts( )->add_sort( columnname = 'LIFNR' subtotal = 'X' ).
 lr_result_salv->get_aggregations( )->add_aggregation( columnname = 'DMBTR' ).


 lr_result_salv->display( ).

Re: cl_salv_table - Problem with aggregating rows

mario_maisto — Fri, 22 Jan 2021 14:19:17 GMT

Yes.. strange.
First I started with a dynamic table definition also with

SELECT lifnr, CAST( dmbtr AS DEC( 8, 2 ) ) AS dmbtr FROM mseg 
INTO TABLE @DATA(lt_tablex) UP TO 15 ROWS.

.. When this didn't work, I defined a test type before hoping this would solve the issue. It did not. Apparently.

So - it may be a bug in my system then - my sample code seems to work in other systems :P.

Thank you again for your help.

Re: cl_salv_table - Problem with aggregating rows

abo — Fri, 22 Jan 2021 14:28:00 GMT

Could it be an error in the ALV code itself?

There is a corrective note with a very interesting description!

Re: cl_salv_table - Problem with aggregating rows

Sandra_Rossi — Fri, 22 Jan 2021 17:35:36 GMT

Summary of note 2957556 - ALV-OM: Totals row is not displayed:

"The ALV is called in the object model (CL_SALV_TABLE). At the interface, aggregations are set for column objects."

SAP_BASIS 781

Re: cl_salv_table - Problem with aggregating rows

RaymondGiuseppi — Mon, 25 Jan 2021 08:09:54 GMT

Could you look at f

Fields definition on MSEG with SE11 (length 13,2 or 23,2)
Fields definition in the field catalog (thru Consustency Check)
Do you work in a HANA sandbox, not every module activated?
Is somebody testing 2628654 - S4TWL: Amount Field Length Extension?

Re: cl_salv_table - Problem with aggregating rows

mario_maisto — Mon, 25 Jan 2021 09:02:49 GMT

Hi, im looking into it.
The field length in mseg for dmbtr is 13,2.