topic Re: When should I write a class instead of a function module? in Application Development and Automation Discussions

When should I write a class instead of a function module?

hagit — Sun, 27 Dec 2020 16:49:50 GMT

Hello experts,

I am familiar with functions modules and function group, but not with classes.

When should I write a class instead of a function module?

(I search for a clear answer but could not find)

Thanks in advance

Hagit

Re: When should I write a class instead of a function module?

geert-janklaps — Sun, 27 Dec 2020 17:31:06 GMT

Hi,

In my personal opinion there are mainly 3 reasons to still use function modules, these cases are:

You need an RFC / Update task enabled logic (e.g. to call it from an external system)
You need to use screens (using screens is not possible in classes directly)
You need to write logic which is to be hooked into certain frameworks which are not ABAP OO-enabled

Personally I always write my core logic in classes and if I need the logic to be RFC enabled, I just write a wrapper function module around my class-based logic.

When using screens I even divide the logic in three parts:

Core logic (class, in which you never use function modules which use screens)
Screen logic (function modules)
Application logic (class, which calls the screen logic function modules)

But again this is a personal opinion, I don't think there's just one answer to this question. Both ways of working, work perfectly although object oriented programming is more future proof and definitely the way to go.

Best regards,

Geert-Jan Klaps

Re: When should I write a class instead of a function module?

hagit — Sun, 27 Dec 2020 19:51:33 GMT

thanks for your answer.

Why do you think that a static method in a class is better than a function module?

Re: When should I write a class instead of a function module?

geert-janklaps — Sun, 27 Dec 2020 20:43:03 GMT

Hi,

There's no real advantage here, both a function module or a static method can be used to hold your logic. Although a class-based approach (using static or instance methods) in general is better than using function modules, since you can make use of certain features like better error handling using exception classes, method chaining, ...

Best regards,

Geert-Jan Klaps

Re: When should I write a class instead of a function module?

pfefferf — Mon, 28 Dec 2020 06:25:02 GMT

One additional point I want to add as a pro argument for classes/interfaces is the better testability. Instead of blowing up your productive code with test-seams in case of functions, you can use the test double framework to create test doubles for based on interfaces.

To take advantage of that pro argument, you need to do unit testing of course, but I guess that is already a standard nowadays :-).

Re: When should I write a class instead of a function module?

Jrg_Brandeis — Mon, 28 Dec 2020 07:34:04 GMT

There are very good reasons why you should always use a class and Mehtods. Function modules are only appropriate if you are forced to do so for technical reasons. But that is rarely the case.
In addition to the points mentioned by 8d8214c7f9734f45be69f95cc0d5aeee and florian.pfeffer here are some more advantages of classes/methods:

Type checking at design time for method calls. In contrast, function modules are checked at runtime, leading to dumps in case of incompatibilities. This is the most important advantage of static methods!
Better control over the reusability or visibility of methods with the keywords PUBLIC, PROTECTED and PRIVATE.
In general: All the advantages of Object Oriented Programming over Functional Programming. For example, encapsulation of data, inheritance, polymorphism and interfaces.

To benefit from this, you need to learn and understand the concepts of Object Orientation. And you have to get involved with it. But then they have a huge advantage for ABAP developers.

Regards,

Jörg

Re: When should I write a class instead of a function module?

hagit — Sun, 03 Jan 2021 11:33:47 GMT

Thank you for your valuable answer. It is pity that I can not mark more the on answer as Best answer

Hagit

Re: When should I write a class instead of a function module?

matt — Mon, 04 Jan 2021 07:04:56 GMT

Four reasons to use a static method of a class instead of a function module

1. The syntax is neater

class=>_do_my_stuff( importing .... exporting ...)

result = class=>_do_my_stuff( ... ).

against

CALL FUNCTION 'Z_DO_MY_STUFF'...

2. The name of the method and class are checked at syntax check time, as are parameter types. No more "function not found" dumps due to a typo. No more conversion errors.

3. You can group related methods together rather more conveniently than with FM

4. They work better when programming in Eclipse!

I only use FM for screen handling and where I need RFC. The work of the FM is done using local or global classes.

Re: When should I write a class instead of a function module?

matt — Mon, 04 Jan 2021 07:06:50 GMT

I put all my FM calls into a local class impelementing a local interface. That way, I can test without using test-seams. But yes, it's better to use classes directly. So long as implemented against an interface of course!

Re: When should I write a class instead of a function module?

FredericGirod — Mon, 04 Jan 2021 11:12:29 GMT

if you start using Class, forget the static method. There is a place for Abap developper who use it ... next to Hungarian notation

Re: When should I write a class instead of a function module?

matt — Mon, 04 Jan 2021 11:39:08 GMT

data(my_instance) = my_class=>get_instance( ).

Otherwise I agree.

Re: When should I write a class instead of a function module?

hagit — Sun, 10 Jan 2021 12:27:29 GMT

Matthew Billingham What did you want to say by writing:

data(my_instance) = my_class=>get_instance( ).

Is there a situation where it is better to write a static method than an instance method?

Thanks

Hagit

Re: When should I write a class instead of a function module?

matt — Mon, 11 Jan 2021 07:45:24 GMT

Exactly that. This is an occasion where a static method is appropriate - when you want to control instantiation in the class. Singleton and factory pattern.

Re: When should I write a class instead of a function module?

hagit — Tue, 12 Jan 2021 16:05:25 GMT

Matthew Billingham What do you mean in "Singleton and factory pattern."?

Thanks