topic Re: Return boolean in condition method -> best practice? in Application Development and Automation Discussions

Return boolean in condition method -> best practice?

schmelto — Fri, 19 Feb 2021 14:35:10 GMT

I wonder if this is best practice for returning a boolean variable for a given condition.

Here is an example program:

CLASS class DEFINITION.

PUBLIC SECTION.
    METHODS is_x
        IMPORTING
            string TYPE string
        RETURNING VALUE(is_x) TYPE abap_boolean.
ENDCLASS.

CLASS class IMPLEMENTATION.
  METHOD is_x.
    IF ( string = 'x' ).
        is_x = abap_true.
    ELSE.
        is_x = abap_false.
    ENDIF.
  ENDMETHOD.
ENDCLASS.

START-OF-SELECTION.
DATA(class) = NEW class( ).
IF ( class->is_x( string = 'x' ) ).
    WRITE: 'Yes'.
ELSE.
    WRITE: 'No'.
ENDIF.

Re: Return boolean in condition method -> best practice?

joltdx — Fri, 19 Feb 2021 14:47:25 GMT

Hi!

Check the sections Use ABAP_BOOL for Booleans and Use XSDBOOL to set Boolean variables in the Clean ABAP guidelines...

Re: Return boolean in condition method -> best practice?

Sandra_Rossi — Fri, 19 Feb 2021 14:57:19 GMT

You don't need parenthesis after IF (must be a java/C habit 😄 )

It's abap_bool, not abap_boolean.