topic Re: Exit Method Loop in Application Development and Automation Discussions

Exit Method Loop

former_member2492 — Tue, 03 Mar 2020 09:00:30 GMT

Hi all,

How can I exit a method in class from another method?

lets say I have the following:

method x.
loop at record into data(ls_record).
 me->check()."do smth inside here and if conditions are not met,continue with the next record
endloop.
endmethod.

Please let me know!

Re: Exit Method Loop

maheshpalavalli — Tue, 03 Mar 2020 09:18:39 GMT

Your question implies that you want to exit method 'x'. But your comment next to check() method says that you want to continue to the next record in the loop without exiting the method x.. Or did I misunderstood the question?

Re: Exit Method Loop

FredericGirod — Tue, 03 Mar 2020 09:20:15 GMT

simple is always better

class ... definition ...
  methods check
    returning
      value(result) type abap_bool.
endclass.



class ... implentation.
method check.
  result = cond #( when sun->is_shining( ) eq abap_true then abap_true else abap_false).
endmethod.


method x.
loop at record into data(ls_record).
 check me->check() eq abap_true.
endloop.
endmethod.
endclass.

Re: Exit Method Loop

former_member2492 — Tue, 03 Mar 2020 09:20:36 GMT

maheshkumar.palavalli no you are correct

Re: Exit Method Loop

Sandra_Rossi — Tue, 03 Mar 2020 09:22:50 GMT

I prefer to use IS_OKAY instead of CHECK so that the code is easier to understand (EDIT: "IF subject verb comparison" is better than "IF verb is true"):

CHECK me->is_okay( ) = abap_true.

IF me->is_okay( ) = abap_false.
  CONTINUE.
ENDIF.

You may also use Predicative Method Call since 7.40 SP 8:

CHECK me->is_okay( ).

IF NOT me->is_okay( ).
  CONTINUE.
ENDIF.

Re: Exit Method Loop

FredericGirod — Tue, 03 Mar 2020 09:26:35 GMT

I assume you used IS_<something>_OKAY ? otherwise CHECK or IS_OKAY are not clean code, We don't know what is OK or not

Re: Exit Method Loop

Sandra_Rossi — Tue, 03 Mar 2020 09:31:28 GMT

frdric.girod I agree that IS_OKAY is not good enough, but I don't know what is in OP's mind, I just think that "IF subject verb comparison" is better than "IF verb is true".

Re: Exit Method Loop

former_member2492 — Tue, 03 Mar 2020 09:35:09 GMT

both answers are correct,thank you,I have upvoted your answer also

Re: Exit Method Loop

matt — Tue, 03 Mar 2020 10:25:19 GMT

740 SP8, you don't need the eq abap_true

LOOP AT record into data(ls_record).
  check the_record_has_passed_the_check( ls_record ).
ENDLOOP.

Re: Exit Method Loop

matt — Tue, 03 Mar 2020 10:27:27 GMT

Funny thing - the clean code group don't like check, but I think it makes things clearer. Also, if you've got multiple checks - don't AND them together. It makes debugging harder - you can't figure out instantly which one failed - and in my view it's less clear.

CHECK does_it_pass_this_condition( ).
CHECK does_it_pass_that_condition( ).
CHECK does_it_pass_the_other_condition( ).

Re: Exit Method Loop

FredericGirod — Tue, 03 Mar 2020 10:31:52 GMT

Agree

but ... your CHECKs have to be in a global CHECK method. Otherwise your method has several responsibilities.

and in clean code we have to used:

LOOP AT record REFERENCE INTO data(o_record).
  check the_record_has_passed_the_check( o_record->* ).
ENDLOOP.

but I am not sure all developers could understand this.