topic Re: Modify in Switch mode in dialog programming in Application Development and Automation Discussions

Modify in Switch mode in dialog programming

Former Member — Sat, 23 May 2020 17:36:00 GMT

I have added a "save edit"button with function code 'SVE'. The function code 'switch' is to switch to editable and non-editable mode.

When i clickon 'SVE' in editable mode (upon clicking 'switch'), it should update value into database. How do i join the 'switch' event and 'SVE' event together? Which syntax to use

*&---------------------------------------------------------------------*
*& Include          MZDLGPROG_03_REPORTI01
*&---------------------------------------------------------------------*
*&---------------------------------------------------------------------*
*&      Module  USER_COMMAND_9002  INPUT
*&---------------------------------------------------------------------*
*       text
*----------------------------------------------------------------------*
MODULE USER_COMMAND_9002 INPUT.
  CASE OK_CODE.
    WHEN 'BACK'.
      SET SCREEN 0.
      LEAVE TO SCREEN 0.

    WHEN 'DEL'.
      GET CURSOR LINE GV_TABIX.
      F1 = 1.
      PERFORM FETCH_DATA.
      IF F1 = 1.
        DELETE ZEKKO_03 FROM TABLE GT_ZEKKO.
        DELETE FROM ZEKPO_03 WHERE EBELN = GWA_ZEKKO-EBELN.
        COMMIT WORK.
      ENDIF.

    WHEN 'SVE'.
      MODIFY ZEKKO_03 FROM TABLE GT_ZEKKO.


  ENDCASE.

  CLEAR GT_ZEKKO.
  CLEAR GT_ZEKPO.

Full code and screen code as shown below:

PROGRAM SAPMZDLGPROG_03_REPORT.

TABLES: ZEKKO_03,
        ZEKPO_03.

CONTROLS: TC_ZEKPO  TYPE TABLEVIEW USING SCREEN 9002.


DATA : OK_CODE   TYPE SY-UCOMM,
       GT_ZEKKO  TYPE TABLE OF ZEKKO_03,
       GWA_ZEKKO TYPE ZEKKO_03,
       GT_ZEKPO  TYPE TABLE OF ZEKPO_03,
       GWA_ZEKPO LIKE LINE OF GT_ZEKPO,
       F1        TYPE CHAR1,
       GV_LINES  TYPE I,
       GV_TABIX  TYPE SY-TABIX,
       ON_OFF    TYPE C LENGTH 1 VALUE '0',
       GV_ACTION TYPE I.



*&---------------------------------------------------------------------*
*& Include          MZDLGPROG_03_REPORTO01
*&---------------------------------------------------------------------*

*&---------------------------------------------------------------------*
*& Module STATUS_9001 OUTPUT
*&---------------------------------------------------------------------*
*&
*&---------------------------------------------------------------------*
MODULE STATUS_9001 OUTPUT.
  SET PF-STATUS 'ZSTATUS'.
  SET TITLEBAR 'ZTITLE'.
ENDMODULE.


*&---------------------------------------------------------------------*
*& Module FETCH_DATA OUTPUT
*&---------------------------------------------------------------------*
*&
*&---------------------------------------------------------------------*
MODULE FETCH_DATA OUTPUT.
* SET PF-STATUS 'xxxxxxxx'.
* SET TITLEBAR 'xxx'.

  SELECT EBELN LIFNR EKORG EKGRP BUKRS WAERS ZTERM ZDESC FROM ZEKKO_03
INTO CORRESPONDING FIELDS OF TABLE GT_ZEKKO
WHERE EBELN = GWA_ZEKKO-EBELN.

  SELECT SINGLE EBELN LIFNR EKORG EKGRP BUKRS WAERS ZTERM ZDESC FROM ZEKKO_03
    INTO CORRESPONDING FIELDS OF GWA_ZEKKO
    WHERE EBELN = GWA_ZEKKO-EBELN.

  READ TABLE GT_ZEKKO INTO GWA_ZEKKO INDEX SY-TABIX.

  SELECT EBELP MATNR WERKS LGORT MENGE MEINS
    INTO CORRESPONDING FIELDS OF TABLE GT_ZEKPO FROM ZEKPO_03
     WHERE EBELN = GWA_ZEKKO-EBELN.

ENDMODULE.


*&---------------------------------------------------------------------*
*& Module SWITCH OUTPUT
*&---------------------------------------------------------------------*
*&
*&---------------------------------------------------------------------*
MODULE SWITCH OUTPUT.
* SET PF-STATUS 'xxxxxxxx'.
* SET TITLEBAR 'xxx'.

  CASE OK_CODE.
    WHEN 'SWITCH'.
      IF ON_OFF = '0'.
        GV_ACTION = 0.
        ON_OFF = '1'.
      ELSE.
        GV_ACTION = 1.
        ON_OFF = '0'.
      ENDIF.


      LOOP AT SCREEN.

        """header
        IF SCREEN-NAME = 'GWA_ZEKKO-EKGRP'.
          SCREEN-INPUT = GV_ACTION.
          MODIFY SCREEN.
        ENDIF.

        IF SCREEN-NAME = 'GWA_ZEKKO-EKORG'.
          SCREEN-INPUT = GV_ACTION.
          MODIFY SCREEN.
        ENDIF.

        IF SCREEN-NAME = 'GWA_ZEKKO-BUKRS'.
          SCREEN-INPUT = GV_ACTION.
          MODIFY SCREEN.
        ENDIF.

        IF SCREEN-NAME = 'GWA_ZEKKO-LIFNR'.
          SCREEN-INPUT = GV_ACTION.
          MODIFY SCREEN.
        ENDIF.

        IF SCREEN-NAME = 'GWA_ZEKKO-WAERS'.
          SCREEN-INPUT = GV_ACTION.
          MODIFY SCREEN.
        ENDIF.

        IF SCREEN-NAME = 'GWA_ZEKKO-ZTERM'.
          SCREEN-INPUT = GV_ACTION.
          MODIFY SCREEN.
        ENDIF.

        IF SCREEN-NAME = 'GWA_ZEKKO-ZDESC'.
          SCREEN-INPUT = GV_ACTION.
          MODIFY SCREEN.
        ENDIF.
      ENDLOOP.

      LOOP AT SCREEN.
        """line item
        IF ( SCREEN-GROUP1 = 'GRP' ).
          SCREEN-INPUT = GV_ACTION.

        ENDIF.
        MODIFY SCREEN.

      ENDLOOP.

  ENDCASE.


ENDMODULE.


*&---------------------------------------------------------------------*
*& Module STATUS_9002 OUTPUT
*&---------------------------------------------------------------------*
*&
*&---------------------------------------------------------------------*
MODULE STATUS_9002 OUTPUT.
  SET PF-STATUS 'ZSTATUS'.
  SET TITLEBAR 'ZTITLE1'.



ENDMODULE.

*&---------------------------------------------------------------------*
*&      Module  MODIFY_IT_ZEKPO  INPUT
*&---------------------------------------------------------------------*
*       text
*----------------------------------------------------------------------*
MODULE MODIFY_GT_ZEKPO INPUT.

  MODIFY GT_ZEKPO FROM GWA_ZEKPO
  INDEX TC_ZEKPO-CURRENT_LINE.

ENDMODULE.

*&---------------------------------------------------------------------*
*& Include          MZDLGPROG_03_REPORTI01
*&---------------------------------------------------------------------*
*&---------------------------------------------------------------------*
*&      Module  USER_COMMAND_9002  INPUT
*&---------------------------------------------------------------------*
*       text
*----------------------------------------------------------------------*
MODULE USER_COMMAND_9002 INPUT.
  CASE OK_CODE.
    WHEN 'BACK'.
      SET SCREEN 0.
      LEAVE TO SCREEN 0.

    WHEN 'DEL'.
      GET CURSOR LINE GV_TABIX.
      F1 = 1.
      PERFORM FETCH_DATA.
      IF F1 = 1.
        DELETE ZEKKO_03 FROM TABLE GT_ZEKKO.
        DELETE FROM ZEKPO_03 WHERE EBELN = GWA_ZEKKO-EBELN.
        COMMIT WORK.
      ENDIF.

    WHEN 'SVE'.
      MODIFY ZEKKO_03 FROM TABLE GT_ZEKKO.


  ENDCASE.

  CLEAR GT_ZEKKO.
  CLEAR GT_ZEKPO.

ENDMODULE.

*&---------------------------------------------------------------------*
*&      Module  USER_COMMAND_9001  INPUT
*&---------------------------------------------------------------------*
*       text
*----------------------------------------------------------------------*
MODULE USER_COMMAND_9001 INPUT.
  CASE OK_CODE.
    WHEN 'BACK' OR 'EXIT' OR 'CANC'.
      LEAVE PROGRAM.
    WHEN 'DELETE' OR 'DISPLAY'.
      IF GWA_ZEKKO-EBELN IS INITIAL .
        MESSAGE 'Please enter document number' TYPE 'E'.
      ELSE.
        PERFORM FETCH_DATA.
        CALL SCREEN 9002.
      ENDIF.

    WHEN 'EDIT'  .
      CALL SCREEN 9002.


    WHEN 'CREATE'.
      CALL SCREEN 9002.


  ENDCASE.

ENDMODULE.

*&---------------------------------------------------------------------*
*& Form FETCH_DATA
*&---------------------------------------------------------------------*
*& text
*&---------------------------------------------------------------------*
*& -->  p1        text
*& <--  p2        text
*&---------------------------------------------------------------------*
FORM FETCH_DATA .

  IF F1 NE 1.

    SELECT EBELN LIFNR EKORG EKGRP BUKRS WAERS ZTERM ZDESC FROM ZEKKO_03
      INTO CORRESPONDING FIELDS OF TABLE GT_ZEKKO
      WHERE EBELN = GWA_ZEKKO-EBELN.

    SELECT SINGLE EBELN LIFNR EKORG EKGRP BUKRS WAERS ZTERM ZDESC FROM ZEKKO_03
      INTO CORRESPONDING FIELDS OF GWA_ZEKKO
      WHERE EBELN = GWA_ZEKKO-EBELN.

    READ TABLE GT_ZEKKO INTO GWA_ZEKKO INDEX SY-TABIX.

    SELECT EBELP MATNR WERKS LGORT MENGE MEINS
      INTO CORRESPONDING FIELDS OF TABLE GT_ZEKPO FROM ZEKPO_03
       WHERE EBELN = GWA_ZEKKO-EBELN.

  ENDIF.

ENDFORM.

Re: Modify in Switch mode in dialog programming

MateuszAdamus — Sat, 23 May 2020 17:41:13 GMT

Hi arnold92

Something like this?

WHEN 'SVE'.
  IF on_off = 0. " edit mode
    MODIFY ZEKKO_03 FROM TABLE GT_ZEKKO.
  ENDIF.

Regards,
Mateusz

Edit: You should probably modify your status to disable the SAVE button in display mode.

Have a look at the SET PF-STATUS keyword with EXCLUDING option.

Re: Modify in Switch mode in dialog programming

venkateswaran_k — Sat, 23 May 2020 18:02:15 GMT

Hi A.S.

As Mateusz suggested, we should disable the SAVE button when it is in display mode.

To help you, can you please show us the latest code of your "SWITCH" code. Also update the name of the SAVE button

Regards,

Venkat

Re: Modify in Switch mode in dialog programming

Former Member — Sat, 23 May 2020 18:06:32 GMT

Hi Matersz

Thanks for your reply, I am looking into it

Logically, the set pf-status excluding should apply to MODULE USER_COMMAND_9002 INPUT?

Re: Modify in Switch mode in dialog programming

MateuszAdamus — Sat, 23 May 2020 18:15:15 GMT

Something like this:

DATA:
  gt_excluded_function TYPE TABLE of syst_ucomm.

CLEAR gt_excluded_functions.
IF on_off = 0. " edit mode.
  " add functions disabled in edit mode
ELSE.
  " add functions disabled in display mode
  APPEND 'SVE' TO gt_excluded_functions.
ENDIF.

SET PF-STATUS 'ZSTATUS' EXCLUDING gt_excluded_functions.
SET TITLEBAR 'ZTITLE1'.<br>

Regards,
Mateusz

Re: Modify in Switch mode in dialog programming

Former Member — Sat, 23 May 2020 18:25:50 GMT

Hi sir,

The statement "Update name of save button", sorry i dont get it.

Here is my latest switch code

*&---------------------------------------------------------------------*
*& Module SWITCH OUTPUT
*&---------------------------------------------------------------------*
*&
*&---------------------------------------------------------------------*
MODULE SWITCH OUTPUT.
* SET PF-STATUS 'xxxxxxxx'.
* SET TITLEBAR 'xxx'.

  CASE OK_CODE.
    WHEN 'SWITCH'.
      IF ON_OFF = '0'.
        GV_ACTION = 0.
        ON_OFF = '1'.
      ELSE.
        GV_ACTION = 1.
        ON_OFF = '0'.
      ENDIF.


      LOOP AT SCREEN.

        """header
        IF SCREEN-NAME = 'GWA_ZEKKO-EKGRP'.
          SCREEN-INPUT = GV_ACTION.
          MODIFY SCREEN.
        ENDIF.

        IF SCREEN-NAME = 'GWA_ZEKKO-EKORG'.
          SCREEN-INPUT = GV_ACTION.
          MODIFY SCREEN.
        ENDIF.

        IF SCREEN-NAME = 'GWA_ZEKKO-BUKRS'.
          SCREEN-INPUT = GV_ACTION.
          MODIFY SCREEN.
        ENDIF.

        IF SCREEN-NAME = 'GWA_ZEKKO-LIFNR'.
          SCREEN-INPUT = GV_ACTION.
          MODIFY SCREEN.
        ENDIF.

        IF SCREEN-NAME = 'GWA_ZEKKO-WAERS'.
          SCREEN-INPUT = GV_ACTION.
          MODIFY SCREEN.
        ENDIF.

        IF SCREEN-NAME = 'GWA_ZEKKO-ZTERM'.
          SCREEN-INPUT = GV_ACTION.
          MODIFY SCREEN.
        ENDIF.

        IF SCREEN-NAME = 'GWA_ZEKKO-ZDESC'.
          SCREEN-INPUT = GV_ACTION.
          MODIFY SCREEN.
        ENDIF.
      ENDLOOP.

      LOOP AT SCREEN.
        """line item
        IF ( SCREEN-GROUP1 = 'GRP' ).
          SCREEN-INPUT = GV_ACTION.

        ENDIF.
        MODIFY SCREEN.

      ENDLOOP.

  ENDCASE.


ENDMODULE.

Re: Modify in Switch mode in dialog programming

Former Member — Sat, 23 May 2020 18:26:00 GMT

Thank you for your suggestion, im trying out

Re: Modify in Switch mode in dialog programming

Former Member — Sat, 23 May 2020 18:40:33 GMT

Just would like to clarify, gv_excluded_function variable should be gt_excluded_functions?

Re: Modify in Switch mode in dialog programming

MateuszAdamus — Sat, 23 May 2020 18:44:38 GMT

Yes, correct.

Regards,
Mateusz

Re: Modify in Switch mode in dialog programming

venkateswaran_k — Sat, 23 May 2020 20:49:37 GMT

Add this statement in header section screen-loop

        IF SCREEN-NAME = 'your_button_name'.   "your button name for the switch
          if ON_OFF = '1'.   "if display hide
            screen-invisible = '1'.
          endif.
          if ON_OFF = '0'.
            screen-invisible = '0'.
            screen-input = '1'
          endif.
          MODIFY SCREEN.
        ENDIF.

Regards,

Venkat

Re: Modify in Switch mode in dialog programming

Sandra_Rossi — Sat, 23 May 2020 21:15:22 GMT

You say "IF SCREEN-NAME = 'your_button_name'. I thought that the OP had designed the buttons in the application toolbar (SET PF-STATUS). Are you sure the OP has defined a "switch" button in the layout of the dynpro?

Re: Modify in Switch mode in dialog programming

Sandra_Rossi — Sat, 23 May 2020 21:24:13 GMT

You ask "How do i join the 'switch' event and 'SVE' event together?" ("switch" being the toggle between display and edit mode, and "SVE" being SAVE)

I don't understand the question.

Classical logic:

If you are in display mode, the Save button must be disabled
If you switch from display mode to edit mode, the Save button must be enabled
If you switch from edit mode to display mode, make sure that the user did not change the input. If so, display a popup to ask "save", "lose data", "cancel".

(and if the user presses the save button, just save, that's all)

Re: Modify in Switch mode in dialog programming

venkateswaran_k — Sat, 23 May 2020 21:32:30 GMT

Yes Sandra,

In the screen above the Table Control - there is a button called INPUT.. (Which he assigned as SWITCH) user-command

Regards,

Venkat

Re: Modify in Switch mode in dialog programming

Former Member — Sun, 24 May 2020 06:14:01 GMT

the on-off = 1 is display mode instead of edit?

Re: Modify in Switch mode in dialog programming

venkateswaran_k — Sun, 24 May 2020 06:20:46 GMT

I think Yes, Anyways, You can try in both way.. 0 or 1.. Just try in both option. This code should work

Re: Modify in Switch mode in dialog programming

Sandra_Rossi — Sun, 24 May 2020 07:28:36 GMT

arnold92 The name "on_off" is horrible, change it to a meaningful name as per Clean ABAP.

Re: Modify in Switch mode in dialog programming

Former Member — Sun, 24 May 2020 08:16:16 GMT

Ive tried with the following:

*&---------------------------------------------------------------------*
*& Module SVE OUTPUT
*&---------------------------------------------------------------------*
*&
*&---------------------------------------------------------------------*
MODULE SVE OUTPUT.

 DATA: GT_FUNCTION TYPE TABLE OF sy-ucomm.

  CLEAR GT_FUNCTION.
  IF
    on_off = '1'.  '"""edit mode

    SET PF-STATUS 'ZSTATUS' EXCLUDING 'SAVE'.
    APPEND 'SVE' TO GT_FUNCTION.
  ELSE.
    ON_OFF = '0'.
    SET PF-STATUS 'ZSTATUS' .
  ENDIF.


ENDMODULE.<br>

then i tried to click on switch edit mode, make changes to value in zekko field with 'sve' event, then it switches back to display mode without making any changes to the field

PROCESS BEFORE OUTPUT.
  MODULE STATUS_9002.

    MODULE fetch_data.
  LOOP AT GT_ZEKPO INTO GWA_ZEKPO WITH CONTROL TC_ZEKPO CURSOR
TC_ZEKPO-CURRENT_LINE.
  ENDLOOP.

  MODULE switch.
  MODULE sve.


PROCESS AFTER INPUT.
loop at gt_zekpo.
*  MODULE modify_gt_zekpo.
endloop.
  MODULE USER_COMMAND_9002.<br>

*&---------------------------------------------------------------------*
*& Include          MZDLGPROG_03_REPORTI01
*&---------------------------------------------------------------------*
*&---------------------------------------------------------------------*
*&      Module  USER_COMMAND_9002  INPUT
*&---------------------------------------------------------------------*
*       text
*----------------------------------------------------------------------*
MODULE USER_COMMAND_9002 INPUT.
  SET PF-STATUS 'ZSTATUS' .
  SET TITLEBAR 'ZTITLE1'.

  CASE OK_CODE.
    WHEN 'BACK'.
      SET SCREEN 0.
      LEAVE TO SCREEN 0.

    WHEN 'DEL'.
      GET CURSOR LINE GV_TABIX.
      F1 = 1.
      PERFORM FETCH_DATA.
      IF F1 = 1.
        DELETE ZEKKO_03 FROM TABLE GT_ZEKKO.
        DELETE FROM ZEKPO_03 WHERE EBELN = GWA_ZEKKO-EBELN.
        COMMIT WORK.
      ENDIF.

    WHEN 'SVE'.
      IF ON_OFF EQ '1'.
        MODIFY ZEKKO_03 FROM TABLE GT_ZEKKO.
        COMMIT WORK.

      ENDIF.

  ENDCASE.

  CLEAR GT_ZEKKO.
  CLEAR GT_ZEKPO.

ENDMODULE.<br>

Re: Modify in Switch mode in dialog programming

Former Member — Sun, 24 May 2020 08:31:52 GMT

Hi Sandra,

Ive incorporated your second point in code above

Re: Modify in Switch mode in dialog programming

Former Member — Sun, 24 May 2020 08:43:30 GMT

Hi Sandra, yes will change it

Re: Modify in Switch mode in dialog programming

MateuszAdamus — Sun, 24 May 2020 09:43:35 GMT

Please make a habit of naming variables with names which mean something. What does on_off variable mean? What its values mean? Is 1 on? Is 0 on? You try to remove the SAVE button when on_off = 1.

  IF
    on_off = '1'.  '"""edit mode

    SET PF-STATUS 'ZSTATUS' EXCLUDING 'SAVE'.
    APPEND 'SVE' TO GT_FUNCTION.
  ELSE.
    ON_OFF = '0'.
    SET PF-STATUS 'ZSTATUS' .
  ENDIF.

But later you try to modify the data in DB when on_off = 1.

    WHEN 'SVE'.
      IF ON_OFF EQ '1'.
        MODIFY ZEKKO_03 FROM TABLE GT_ZEKKO.
        COMMIT WORK.
      ENDIF.

Is on_off = 1 an EDIT or DISPLAY mode? No one can tell...

It would be much better if you had a boolean variable named for example GV_IS_EDIT_MODE which would have values 'X' = Yes and ' ' = No. This way you (and any other developer for that matter) would always be able to tell, if it's an EDIT or DISPLAY mode.

As to the button removal, you have to add the 'SVE' user command before you set the PF-STATUS of the screen. And in the SET PF-STATUS you need to use the GT_FUNCTION table. Like so:

    APPEND 'SVE' TO GT_FUNCTION.
    SET PF-STATUS 'ZSTATUS' EXCLUDING gt_function.

The way you did it won't work. You add 'SVE' just after you set the PF-STATUS and excluding the 'SAVE' user command won't disable the SAVE button, as it has the 'SVE' user command assigned.

Regards,

Mateusz