Failed Validation Handling between public caller method and private methods with same class

Former Member — Mon, 21 Sep 2015 06:43:38 GMT

I will like to know the software design to design exception handling within a class. I have a class with both private and public methods. There is a public method which is supposed to do some actions then consolidate all the warnings and errors arose from processing the actions. This is similar to the Function module BAPI_PO_CREATE1, with a return message table.

The implementation of the public method involved calling private methods within the same class for validation.

I want to ask what will be a better way for implementation for the failed validation handling:

Implement the private method to throw exception with custom error message when the validation fails, and the caller will handle the exception class
Return a false boolean/ null indicator when the validation fails, then the caller will check the return indicator. Upon the false return, the caller will place in a custom message into the message table.

Re: Failed Validation Handling between public caller method and private methods with same class

matt — Mon, 21 Sep 2015 07:22:57 GMT

I tend to use things like:

IF is_in_range( ) EQ abap_false.

RAISE EXCEPTION TYPE zcx_my_exception EXPORTING textid = zcx_my_exception=>out_of_range.

ELSEIF is_valid_in_some_other_way( ) EQ abap_false

RAISE EXCEPTION TYPE zcx_my_exception EXPORTING textid = zcx_my_exception=>invalid_some_other_way.

ENDIF.

In my view, the validation methods are making a test. What you do with the result of the test is delegated to the calling method.

topic Re: Failed Validation Handling between public caller method and private methods with same class in Application Development and Automation Discussions

Failed Validation Handling between public caller method and private methods with same class

Re: Failed Validation Handling between public caller method and private methods with same class